Packages October 2019

packages@lists.squeakfoundation.org

1 participants
132 discussions

The Trunk: Kernel-nice.1277.mcz
by commits＠source.squeak.org 18 Oct '19

18 Oct '19

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.1277.mcz ==================== Summary ==================== Name: Kernel-nice.1277 Author: nice Time: 18 October 2019, 1:20:30.016461 pm UUID: 08c3b2dd-36ff-4da9-b7b9-c70f11e47b1b Ancestors: Kernel-mt.1275 Fix my recent bug in Integer>>asFloat. Explanations: with introduction of digitsAsFloat, I removed implementation of LargeNegativeInteger>>asFloat because all the involved bitOps in superclass (LargePositiveInteger) operate on magnitude and thus work for negative too (bitShiftMagnitude: and anyBitOfMagnitudeFrom:to:). Err... All operations but one: mantissa := mantissa + 1. Unfortunately, this was not caught by our tests... We all know that 100% coverage does not mean 100% correct. But 100% coverage of a method also does not mean 100% coverage for every possible subclass! =============== Diff against Kernel-mt.1275 =============== Item was changed: ----- Method: LargePositiveInteger>>asFloat (in category 'converting') ----- asFloat "Answer a Float that best approximates the value of the receiver. This algorithm is optimized to process only the significant digits of a LargeInteger. And it does honour IEEE 754 round to nearest even mode in case of excess precision (see details below)." "How numbers are rounded in IEEE 754 default rounding mode: + A shift is applied so that the highest 53 bits are placed before the floating point to form a significand. - A shift is applied so that the highest 53 bits are placed before the floating point to form a mantissa. The trailing bits form the fraction part placed after the floating point. This fractional number must be rounded to the nearest integer. If fraction part is 2r0.1, exactly between two consecutive integers, there is a tie. The nearest even integer is chosen in this case. + Examples (First 52bits of significand are omitted for brevity): - Examples (First 52bits of mantissa are omitted for brevity): 2r0.00001 is rounded downward to 2r0 2r1.00001 is rounded downward to 2r1 2r0.1 is a tie and rounded to 2r0 (nearest even) 2r1.1 is a tie and rounded to 2r10 (nearest even) 2r0.10001 is rounded upward to 2r1 2r1.10001 is rounded upward to 2r10 + Thus, if the next bit after floating point is 0, the significand is left unchanged. + If next bit after floating point is 1, an odd significand is always rounded upper. + An even significand is rounded upper only if the fraction part is not a tie." - Thus, if the next bit after floating point is 0, the mantissa is left unchanged. - If next bit after floating point is 1, an odd mantissa is always rounded upper. - An even mantissa is rounded upper only if the fraction part is not a tie." "Algorihm details: The floating point hardware can perform the rounding correctly with several excess bits as long as there is a single inexact operation. Note 1: the inexact flag in floating point hardware must not be trusted because in some cases the operations would be exact but would not take into account some bits that were truncated before the Floating point operations. Note 2: the floating point hardware is presumed configured in default rounding mode." + | significand shift excess | - | mantissa shift excess | + "Check how many bits excess the maximum precision of a Float significand." - "Check how many bits excess the maximum precision of a Float mantissa." excess := self highBitOfMagnitude - Float precision. excess > 7 - ifTrue: - ["Remove the excess bits but seven." - mantissa := self bitShiftMagnitude: 7 - excess. - shift := excess - 7. - "An even mantissa with a single excess bit immediately following would be truncated. - But this would not be correct if above shift has truncated some extra bits. - Check this case, and round excess bits upper manually." - ((mantissa digitAt: 1) = 2r01000000 and: [self anyBitOfMagnitudeFrom: 1 to: shift]) - ifTrue: [mantissa := mantissa + 1]] ifFalse: + ["We can use naive digit by digit conversion because there will be a single inexact round off at last iteration. + But the nice thing is that Float precision + 7 excess bits = 60 which fit in a SmallInteger in Spur64. + So the best to do is to delegate this final operation" + ^self digitsAsFloat ]. - [mantissa := self. - shift := 0]. + "Remove the excess bits but seven." + significand := self bitShiftMagnitude: 7 - excess. + shift := excess - 7. + "An even significand with a single excess bit immediately following would be truncated. + But this would not be correct if above shift has truncated some extra bits. + Check this case, and move an extra bit to the last significand digit." + ((significand digitAt: 1) = 2r01000000 and: [self anyBitOfMagnitudeFrom: 1 to: shift]) + ifTrue: [significand := significand + self sign]. + + ^significand digitsAsFloat timesTwoPower: shift.! - "We can use naive digit by digit conversion because there will be a single inexact round off at last iteration. - But the nice thing is that Float precision + 7 excess bits = 60 which fit in a SmallInteger in Spur64. - So the best to do is to delegate this final operation" - ^mantissa digitsAsFloat timesTwoPower: shift.!

1 0

The Trunk: Kernel-nice.1276.mcz
by commits＠source.squeak.org 18 Oct '19

18 Oct '19

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.1276.mcz ==================== Summary ==================== Name: Kernel-nice.1276 Author: nice Time: 18 October 2019, 1:13:01.217084 pm UUID: 52c1774b-4ff6-40f3-a575-f53af8746515 Ancestors: Kernel-mt.1275 Fix my recent bug in Integer>>asFloat. Explanations: with introduction of digitsAsFloat, I removed implementation of LargeNegativeInteger>>asFloat because all the involved bitOps in superclass (LargePositiveInteger) operate on magnitude and thus work for negative too (bitShiftMagnitude: and anyBitOfMagnitudeFrom:to:). Err... All operations but one: mantissa := mantissa + 1. Unfortunately, this was not caught by our tests... We all know that 100% coverage does not mean 100% correct. But 100% coverage of a method also does not mean 100% coverage for every possible subclass! =============== Diff against Kernel-mt.1275 =============== Item was changed: ----- Method: LargePositiveInteger>>asFloat (in category 'converting') ----- asFloat "Answer a Float that best approximates the value of the receiver. This algorithm is optimized to process only the significant digits of a LargeInteger. And it does honour IEEE 754 round to nearest even mode in case of excess precision (see details below)." "How numbers are rounded in IEEE 754 default rounding mode: + A shift is applied so that the highest 53 bits are placed before the floating point to form a significand. - A shift is applied so that the highest 53 bits are placed before the floating point to form a mantissa. The trailing bits form the fraction part placed after the floating point. This fractional number must be rounded to the nearest integer. If fraction part is 2r0.1, exactly between two consecutive integers, there is a tie. The nearest even integer is chosen in this case. + Examples (First 52bits of significand are omitted for brevity): - Examples (First 52bits of mantissa are omitted for brevity): 2r0.00001 is rounded downward to 2r0 2r1.00001 is rounded downward to 2r1 2r0.1 is a tie and rounded to 2r0 (nearest even) 2r1.1 is a tie and rounded to 2r10 (nearest even) 2r0.10001 is rounded upward to 2r1 2r1.10001 is rounded upward to 2r10 + Thus, if the next bit after floating point is 0, the significand is left unchanged. + If next bit after floating point is 1, an odd significand is always rounded upper. + An even significand is rounded upper only if the fraction part is not a tie." - Thus, if the next bit after floating point is 0, the mantissa is left unchanged. - If next bit after floating point is 1, an odd mantissa is always rounded upper. - An even mantissa is rounded upper only if the fraction part is not a tie." "Algorihm details: The floating point hardware can perform the rounding correctly with several excess bits as long as there is a single inexact operation. Note 1: the inexact flag in floating point hardware must not be trusted because in some cases the operations would be exact but would not take into account some bits that were truncated before the Floating point operations. Note 2: the floating point hardware is presumed configured in default rounding mode." + | significand shift excess | - | mantissa shift excess | + "Check how many bits excess the maximum precision of a Float significand." - "Check how many bits excess the maximum precision of a Float mantissa." excess := self highBitOfMagnitude - Float precision. excess > 7 - ifTrue: - ["Remove the excess bits but seven." - mantissa := self bitShiftMagnitude: 7 - excess. - shift := excess - 7. - "An even mantissa with a single excess bit immediately following would be truncated. - But this would not be correct if above shift has truncated some extra bits. - Check this case, and round excess bits upper manually." - ((mantissa digitAt: 1) = 2r01000000 and: [self anyBitOfMagnitudeFrom: 1 to: shift]) - ifTrue: [mantissa := mantissa + 1]] ifFalse: + ["We can use naive digit by digit conversion because there will be a single inexact round off at last iteration. + But the nice thing is that Float precision + 7 excess bits = 60 which fit in a SmallInteger in Spur64. + So the best to do is to delegate this final operation" + ^self digitsAsFloat ]. - [mantissa := self. - shift := 0]. + "Remove the excess bits but seven." + significand := self bitShiftMagnitude: 7 - excess. + shift := excess - 7. + "An even significand with a single excess bit immediately following would be truncated. + But this would not be correct if above shift has truncated some extra bits. + Check this case, and move an extra bit to the last significand digit." + ((significand digitAt: 1) = 2r01000000 and: [self anyBitOfMagnitudeFrom: 1 to: shift]) + ifTrue: [significand := significand + self signBit]. + + ^significand digitsAsFloat timesTwoPower: shift.! - "We can use naive digit by digit conversion because there will be a single inexact round off at last iteration. - But the nice thing is that Float precision + 7 excess bits = 60 which fit in a SmallInteger in Spur64. - So the best to do is to delegate this final operation" - ^mantissa digitsAsFloat timesTwoPower: shift.!

1 0

The Trunk: Morphic-mt.1579.mcz
by commits＠source.squeak.org 16 Oct '19

16 Oct '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1579.mcz ==================== Summary ==================== Name: Morphic-mt.1579 Author: mt Time: 16 October 2019, 1:21:29.709451 pm UUID: bcb586f2-39da-6249-9e9c-545af09d044b Ancestors: Morphic-mt.1578 Make the lazy list morph also lazy in terms of the icon extent. Only probe the extent of the first icon and then use that for the entire list. This matches the use of a single font to determine the height of the entire list. See #maxHeight. =============== Diff against Morphic-mt.1578 =============== Item was changed: Morph subclass: #LazyListMorph + instanceVariableNames: 'listItems listIcons listFilterOffsets font selectedRow selectedRows preSelectedRow listSource maxWidth columnIndex iconExtent' - instanceVariableNames: 'listItems listIcons listFilterOffsets font selectedRow selectedRows preSelectedRow listSource maxWidth columnIndex' classVariableNames: '' poolDictionaries: '' category: 'Morphic-Widgets'! !LazyListMorph commentStamp: 'mt 10/13/2019 19:44' prior: 0! The morph that displays the list in a PluggableListMorph. It is "lazy" because it will only request the list items that it actually needs to display. I will cache the maximum width of my items in maxWidth to avoid this potentially expensive and frequent computation. The following layout properties are supported: - #cellPositioning: #leftCenter [default], #center, #rightCenter - #cellInset: [default: 3@0 corner: 3@0]! Item was changed: ----- Method: LazyListMorph>>display:atRow:on: (in category 'drawing') ----- display: item atRow: row on: canvas "display the given item at row row" | drawBounds emphasized rowColor itemAsText alignment | itemAsText := item asStringOrText. alignment := self cellPositioning. "If it is a text, we will only use the first character's emphasis." emphasized := itemAsText isText ifTrue: [font emphasized: (itemAsText emphasisAt: 1)] ifFalse: [font]. rowColor := itemAsText isText ifTrue: [itemAsText colorAt: 1 ifNone: [self colorForRow: row]] ifFalse: [self colorForRow: row]. drawBounds := self drawBoundsForRow: row. alignment ~= #leftCenter ifTrue: [ | itemWidth | itemWidth := self widthToDisplayItem: item. "includes left/right margins" alignment == #center ifTrue: [ drawBounds := (self center x - (itemWidth / 2) floor) @ drawBounds top corner: (self center x + (itemWidth / 2) ceiling) @ drawBounds bottom]. alignment == #rightCenter ifTrue: [ drawBounds := (self right - itemWidth) @ drawBounds top corner: self right @ drawBounds bottom]]. "Draw icon if existing. Adjust draw bounds in that case." drawBounds := drawBounds translateBy: (self cellInset left @ 0). (self icon: row) ifNotNil: [ :icon || top | + top := drawBounds top + ((drawBounds height - self iconExtent y) // 2). - top := drawBounds top + ((drawBounds height - icon height) // 2). canvas translucentImage: icon at: drawBounds left @ top. + drawBounds := drawBounds left: drawBounds left + self iconExtent x + 2 ]. - drawBounds := drawBounds left: drawBounds left + icon width + 2 ]. "We will only draw strings here." drawBounds := drawBounds translateBy: (0 @ self cellInset top). canvas drawString: itemAsText asString in: drawBounds font: emphasized color: rowColor. "Draw filter matches if any." self displayFilterOn: canvas for: row in: drawBounds font: emphasized.! Item was changed: ----- Method: LazyListMorph>>icon: (in category 'list access - cached') ----- icon: row "Do inst-var access on listIcons here to initialize it as late as possible." self listSource canHaveIcons ifFalse: [^ nil]. listIcons ifNil: [listIcons := Array new: self getListSize]. ^ (listIcons at: row) ifNil: [ | icon | icon := (self getListIcon: row) ifNotNil: [:form | form scaleIconToDisplay]. + "Update cache for uniform icon extent." + iconExtent ifNil: [iconExtent := icon ifNotNil: [icon extent]]. listIcons at: row put: icon. icon]! Item was added: + ----- Method: LazyListMorph>>iconExtent (in category 'layout') ----- + iconExtent + + ^ iconExtent ifNil: [ + self getListSize = 0 + ifTrue: [((14@14) * RealEstateAgent scaleFactor) truncated] + ifFalse: [(self icon: 1) ifNil: [0@0] ifNotNil: [:form | form extent]]]! Item was changed: ----- Method: LazyListMorph>>layoutChanged (in category 'layout') ----- layoutChanged "See #item:. We have to invalidate listItems or maxWidth will not be updated if you switch hResizing to #shrinkWrap." listItems := nil. maxWidth := nil. + iconExtent := nil. super layoutChanged.! Item was changed: ----- Method: LazyListMorph>>widthToDisplayItem: (in category 'layout') ----- widthToDisplayItem: item | labelWidth iconWidth leftMargin rightMargin | labelWidth := self font widthOfStringOrText: item asStringOrText. + iconWidth := self listSource canHaveIcons ifTrue: [self iconExtent x] ifFalse: [0]. - iconWidth := self listSource canHaveIcons - ifTrue: [(16 * RealEstateAgent scaleFactor) truncated] - ifFalse: [0]. leftMargin := self cellInset left. rightMargin := self cellInset right. ^ leftMargin + iconWidth + labelWidth + rightMargin!

1 0

The Trunk: EToys-mt.362.mcz
by commits＠source.squeak.org 16 Oct '19

16 Oct '19

Marcel Taeumel uploaded a new version of EToys to project The Trunk: http://source.squeak.org/trunk/EToys-mt.362.mcz ==================== Summary ==================== Name: EToys-mt.362 Author: mt Time: 16 October 2019, 1:09:43.789134 pm UUID: 7dc0a2c8-30d8-ff4e-99b2-400a969a4c8b Ancestors: EToys-mt.361 Minor fix because #select: keeps the original kind, which is a set, which cannot be sorted in-place. =============== Diff against EToys-mt.361 =============== Item was changed: ----- Method: SearchingViewer>>doSearchFrom:interactive: (in category 'search') ----- doSearchFrom: aSource interactive: isInteractive "Perform the search operation. If interactive is true, this actually happened because a search button was pressed; if false, it was triggered some other way for which an informer would be inappropriate." | searchFor aVocab aList all anInterface useTranslations scriptNames addedMorphs | searchString := aSource isString ifTrue: [aSource] ifFalse: [(aSource isKindOf: PluggableTextMorph) "old" ifTrue: [aSource text string] ifFalse: [aSource contents asString]]. searchFor := searchString asLowercaseAlphabetic. aVocab := self outerViewer currentVocabulary. (useTranslations := (scriptedPlayer isPlayerLike) and: [aVocab isEToyVocabulary]) ifTrue: [all := scriptedPlayer costume selectorsForViewer. all addAll: (scriptNames := scriptedPlayer class namedTileScriptSelectors)] ifFalse: [all := scriptNames := scriptedPlayer class allSelectors]. aList := all select: [:aSelector | (aVocab includesSelector: aSelector forInstance: scriptedPlayer ofClass: scriptedPlayer class limitClass: ProtoObject) and: [(useTranslations and: [(anInterface := aVocab methodInterfaceAt: aSelector ifAbsent: [nil]) notNil and: [anInterface wording asString asLowercaseAlphabetic includesSubstring: searchFor caseSensitive: true]]) or: [((scriptNames includes: aSelector) or: [useTranslations not]) and: [aSelector includesSubstring: searchFor caseSensitive: false]]]]. + aList := aList sorted. - aList sort. self removeAllButFirstSubmorph. "that being the header" self addAllMorphs: ((addedMorphs := scriptedPlayer tilePhrasesForSelectorList: aList inViewer: self)). self enforceTileColorPolicy. self secreteCategorySymbol. self world ifNotNil: [self world startSteppingSubmorphsOf: self]. self adjustColorsAndBordersWithin. owner ifNotNil: [owner isStandardViewer ifTrue: [owner fitFlap]. (isInteractive and: [addedMorphs isEmpty]) ifTrue: [searchFor ifNotEmpty: [self inform: ('No matches found for "' translated), searchFor, '"']]]!

1 0

The Trunk: Morphic-mt.1578.mcz
by commits＠source.squeak.org 16 Oct '19

16 Oct '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1578.mcz ==================== Summary ==================== Name: Morphic-mt.1578 Author: mt Time: 16 October 2019, 1:08:36.695134 pm UUID: 10f6ea0f-97f5-5842-8ac1-09aa23d97a69 Ancestors: Morphic-mt.1577 Reverts fix for test TestAnchorTest >> #testResizeAnchoredMorph because it breaks at least two important things. Also document those things. =============== Diff against Morphic-mt.1577 =============== Item was changed: ----- Method: TextMorph>>layoutChanged (in category 'layout') ----- layoutChanged "For embedded morphs, we have to invalidate our paragraph if those morphs invalidate their layout. Since paragraph creation will also change this morph's bounds, ignore that case." + "2019-10-16 mt Does not work. Breaks up scroll ranges after saving a method. Breaks highlight of opening parenthesis in Shout." + "(self hasProperty: #CreatingParagraph) ifFalse: [self releaseParagraph]." + - (self hasProperty: #CreatingParagraph) ifFalse: [self releaseParagraph]. ^ super layoutChanged!

1 0

The Trunk: Morphic-mt.1577.mcz
by commits＠source.squeak.org 15 Oct '19

15 Oct '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1577.mcz ==================== Summary ==================== Name: Morphic-mt.1577 Author: mt Time: 15 October 2019, 1:58:16.523992 pm UUID: 1d4a5d6b-aeee-5242-b9ef-d2c81fedd846 Ancestors: Morphic-mt.1576 Better error message in pluggable lists for misbehaving models. :-) =============== Diff against Morphic-mt.1576 =============== Item was changed: ----- Method: PluggableListMorph>>getFullList (in category 'model access - cached') ----- getFullList "The full, unfiltered list. Cached result, see #updateList. Prefer getListSelector over getListElementSelector if both a set." ^ fullList ifNil: [ fullList := getListSelector ifNotNil: [:sel | model perform: sel] ifNil: [(getListSizeSelector notNil and: [getListElementSelector notNil]) ifTrue: [ (1 to: self getListSize) collect: [:index | self getListItem: index]] + ifFalse: [#() "We cannot get the full list."]]. + fullList ifNil: [Error signal: 'The model must never provide ''nil'' as a list but only a collection.']. + fullList]! - ifFalse: [#() "We cannot get the full list."]]]! Item was changed: ----- Method: PluggableListMorph>>updateListFilter (in category 'updating') ----- updateListFilter | selection | + selection := self selectionIndex = 0 "Avoid fetching #getList here." + ifTrue: [nil] + ifFalse: [self selection]. - selection := self selection. list := nil. modelToView := nil. viewToModel := nil. self getList. "Try to restore the last selection." selection ifNotNil: [self selection: selection].!

1 0

The Trunk: Tools-mt.909.mcz
by commits＠source.squeak.org 15 Oct '19

15 Oct '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.909.mcz ==================== Summary ==================== Name: Tools-mt.909 Author: mt Time: 15 October 2019, 1:57:36.180992 pm UUID: be9090ad-70ef-f143-8a8e-8c7a509af71a Ancestors: Tools-mt.908 Models must never provide "nil" as the list to the view. =============== Diff against Tools-mt.908 =============== Item was changed: ----- Method: SelectorBrowser>>classList (in category 'class list') ----- classList + ^ classList ifNil: [#()]! - ^ classList! Item was changed: ----- Method: SelectorBrowser>>messageList (in category 'message list') ----- messageList "Find all the selectors containing what the user typed in." + ^ selectorList ifNil: [#()]! - ^ selectorList!

1 0

The Trunk: Morphic-mt.1576.mcz
by commits＠source.squeak.org 15 Oct '19

15 Oct '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1576.mcz ==================== Summary ==================== Name: Morphic-mt.1576 Author: mt Time: 15 October 2019, 1:40:15.667692 pm UUID: b5b011fc-e1f1-414d-8109-61b95c71ca78 Ancestors: Morphic-mt.1575 Fixes that annoying huge stack of progress bars that pops up when loading/refreshing code in Monticello. =============== Diff against Morphic-mt.1575 =============== Item was changed: ----- Method: PluggableListMorph>>getList (in category 'model access - cached') ----- getList "Answer the (maybe filtered) list to be displayed. Cached result, see #updateList." ^ list ifNil: [ + list := #(). "To make this call safe when re-entering it while fetching the list. This can happen, for example, when the model fetches data that opens the system progress bar which then will redraw periodically." list := self filterableList ifTrue: [self getFilteredList] ifFalse: [self getFullList]. self updateListMorph. list]!

1 0

The Trunk: Morphic-mt.1575.mcz
by commits＠source.squeak.org 15 Oct '19

15 Oct '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1575.mcz ==================== Summary ==================== Name: Morphic-mt.1575 Author: mt Time: 15 October 2019, 1:30:24.148785 pm UUID: c7bde074-ddad-864a-a5b3-8b078736fe2f Ancestors: Morphic-mt.1574 More robustness: (1) Catch both Error and Halt in Morphic drawing and (2) Reset drawing errors in morphs when restoring the Display. =============== Diff against Morphic-mt.1574 =============== Item was added: + ----- Method: MorphicProject>>restoreDisplay (in category 'scheduling & debugging') ----- + restoreDisplay + "Give all morphs a chance to draw again." + self world ifNotNil: [:w | w allMorphsDo: [:ea | ea removeProperty: #errorOnDraw ]]. + + super restoreDisplay.! Item was changed: ----- Method: WorldState>>displayWorldSafely: (in category 'update cycle') ----- displayWorldSafely: aWorld "Update this world's display and keep track of errors during draw methods." | finished classesWithErrors | finished := false. [finished] whileFalse: [ + [aWorld displayWorld. finished := true] on: Error, Halt do: [:ex | - [aWorld displayWorld. finished := true] on: Error do: [:ex | "Handle a drawing error" | err rcvr errCtx errMorph | err := ex description. rcvr := ex receiver. errCtx := thisContext. [ errCtx := errCtx sender. "Search the sender chain to find the morph causing the problem" [errCtx notNil and:[(errCtx receiver isMorph) not]] whileTrue:[errCtx := errCtx sender]. "If we're at the root of the context chain then we have a fatal drawing problem" errCtx ifNil:[^Project current fatalDrawingError: err]. errMorph := errCtx receiver. "If the morph causing the problem has already the #drawError flag set, then search for the next morph above in the caller chain." errMorph hasProperty: #errorOnDraw ] whileTrue. errMorph setProperty: #errorOnDraw toValue: true. "Catch all errors, one for each receiver class." classesWithErrors ifNil: [classesWithErrors := IdentitySet new]. (classesWithErrors includes: rcvr class) ifFalse: [ classesWithErrors add: rcvr class. ToolSet debugException: ex]. "Repaint all to catch all errors now and not if the debugger will appear." aWorld fullRepaintNeeded. ]].!

1 0

The Trunk: Morphic-mt.1574.mcz
by commits＠source.squeak.org 15 Oct '19

15 Oct '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1574.mcz ==================== Summary ==================== Name: Morphic-mt.1574 Author: mt Time: 15 October 2019, 10:35:01.68525 am UUID: 71d26af5-1618-f040-a68e-8ce47b2a5736 Ancestors: Morphic-mt.1573 Fixes a bug with list-selection restoring after changing UI themes, for example. Tweaks appearance of list filters for demo/hi-dpi mode. Removes the use of #bigDisplay property. RealEstateManage handles window resizing just fine. =============== Diff against Morphic-mt.1573 =============== Item was changed: ----- Method: LazyListMorph>>displayFilterOn:for:in:font: (in category 'drawing') ----- displayFilterOn: canvas for: row in: drawBounds font: font "Draw filter matches if any." + | fillStyle fillHeight | - | fill height | listSource filterableList ifFalse: [^ self]. + fillHeight := font height. + fillStyle := self filterColor isColor - height := font height. - fill := self filterColor isColor ifTrue: [SolidFillStyle color: self filterColor] ifFalse: [self filterColor]. + fillStyle isGradientFill ifTrue: [ + fillStyle origin: drawBounds topLeft. + fillStyle direction: 0@ fillHeight]. - fill isGradientFill ifTrue: [ - fill origin: drawBounds topLeft. - fill direction: 0@ font height]. + (self filterOffsets: row) do: [:offset | + | highlightRectangle | + highlightRectangle := ((drawBounds left + offset first first) @ drawBounds top + corner: (drawBounds left + offset first last) @ (drawBounds top + fillHeight)). - (self filterOffsets: row) do: [:offset | | r | - r := ((drawBounds left + offset first first) @ drawBounds top corner: (drawBounds left + offset first last) @ (drawBounds top + height)). canvas + frameAndFillRoundRect: (highlightRectangle outsetBy: 1@0) + radius: (3 * RealEstateAgent scaleFactor) truncated + fillStyle: fillStyle + borderWidth: (1 * RealEstateAgent scaleFactor) truncated + borderColor: fillStyle asColor twiceDarker. - frameAndFillRoundRect: (r outsetBy: 1@0) - radius: 3 - fillStyle: fill - borderWidth: 1 - borderColor: fill asColor twiceDarker. canvas drawString: offset second + in: highlightRectangle - in: r font: font color: self filterTextColor].! Item was changed: ----- Method: PluggableListMorph>>verifyContents (in category 'updating') ----- verifyContents "Verify the contents of the receiver, reconstituting if necessary. Called whenever window is reactivated, to react to possible structural changes. Also called periodically in morphic if the smartUpdating preference is true" | currentList modelList modelIndex | self flag: #performance. "mt: We do have changed/update. Why can't the tools communicate through an appropriate notifier such as the SystemChangeNotifier?" "1) Is the list still up to date?" currentList := fullList. fullList := nil. modelList := self getFullList. + modelList = currentList + ifFalse: [self updateList: modelList]. - modelList = currentList ifTrue: [^ self]. - self updateList: modelList. "2) Is the selection still up to date?" modelIndex := self getCurrentSelectionIndex. + (self modelIndexFor: self selectionIndex) = modelIndex + ifFalse: [self updateListSelection: modelIndex].! - (self modelIndexFor: self selectionIndex) = modelIndex ifTrue: [^ self]. - self updateListSelection: modelIndex.! Item was changed: ----- Method: SystemWindow>>applyModelExtent (in category 'initialization') ----- applyModelExtent + self extent: model initialExtent ! - | initialExtent | - initialExtent := Preferences bigDisplay - ifTrue: [(model initialExtent * 1.5) rounded] - ifFalse: [model initialExtent]. - self extent: initialExtent !

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Packages October 2019