Packages April 2021

packages@lists.squeakfoundation.org

1 participants
226 discussions

The Trunk: Morphic-mt.1756.mcz
by commits＠source.squeak.org 20 Apr '21

20 Apr '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1756.mcz ==================== Summary ==================== Name: Morphic-mt.1756 Author: mt Time: 20 April 2021, 10:58:45.137004 am UUID: eb1e8287-cfc4-ff47-a8d1-a4e93f3be174 Ancestors: Morphic-mt.1755 In object explorers, format the different representations of numbers in groups, following the well-known practice: hex 2, oct 3, binary 4 digits. (Piggyback the removal of an #isMutator send) =============== Diff against Morphic-mt.1755 =============== Item was changed: ----- Method: Integer>>explorerContents (in category '*Morphic-Explorer') ----- explorerContents ^#( + ('hexadecimal' 16 2) + ('octal' 8 3) + ('binary' 2 4)) collect: [ :each | | label group | + group := each third. + label := self printStringBase: each second. + label := label padded: #left to: (label size roundUpTo: group) with: $0. + label := String streamContents: [:s | + (1 to: label size by: group) + do: [:index | + 1 to: group do: [:gIndex | + s nextPut: (label at: index + gIndex - 1)]] + separatedBy: [s space]]. + - ('hexadecimal' 16) - ('octal' 8) - ('binary' 2)) collect: [ :each | ObjectExplorerWrapper + with: label - with: (self printStringBase: each second) name: each first translated model: self ]! Item was changed: ----- Method: NewColorPickerMorph class>>on:colorSelector: (in category 'create') ----- on: objectToHaveItsColorSet colorSelector: colorSymbol ^ self on: objectToHaveItsColorSet getColorSelector: colorSymbol + setColorSelector: colorSymbol asSimpleSetter! - setColorSelector: colorSymbol asMutator!

1 0

The Trunk: Environments-jr.82.mcz
by commits＠source.squeak.org 20 Apr '21

20 Apr '21

Marcel Taeumel uploaded a new version of Environments to project The Trunk: http://source.squeak.org/trunk/Environments-jr.82.mcz ==================== Summary ==================== Name: Environments-jr.82 Author: jr Time: 10 April 2021, 12:34:34.717998 am UUID: 2935eb63-046e-c344-8fba-771fb62fb5c2 Ancestors: Environments-tonyg.81 Sending resume: from defaultAction is erroneous in the ANSI standard. In Squeak, unhandled exceptions are resumed with the answer to the defaultAction message. =============== Diff against Environments-tonyg.81 =============== Item was changed: ----- Method: EnvironmentRequest>>defaultAction (in category 'exceptionDescription') ----- defaultAction | all environment | all := Environment allInstances. environment := UIManager default chooseFrom: (all collect: [:ea | ea printString]) values: all. + ^ environment! - self resume: environment.!

1 0

The Trunk: Tests-nice.455.mcz
by commits＠source.squeak.org 19 Apr '21

19 Apr '21

Nicolas Cellier uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-nice.455.mcz ==================== Summary ==================== Name: Tests-nice.455 Author: nice Time: 19 April 2021, 9:18:01.955183 pm UUID: 94f23508-c48c-0d47-8588-b2367071c298 Ancestors: Tests-nice.454 Two unrelated changes: 1) Kernel does not depend on Multilingual anymore (really?) Aknowledge this little victory before the dependecy come back. Alas, Kernel now depend on Morphic due to MouseEvent so the test still fails. Either EventSensor shouldn't be in Kernel, or MouseEvent should not be in Morphic (or both?)... 2) workaround source range test in presence of FullBlockClosure My understanding is that full block bytecodes are not hosted in their home method. As a consequence, full block also have their own PC. So a simple PC map is not elaborate enough to test the selection inside the block. By now, just skip the test of selection inside the full block closure. If some good soul wants to revise the test and make it thorough again, welcome! =============== Diff against Tests-nice.454 =============== Item was changed: ----- Method: ClosureCompilerTest>>supportTestSourceRangeAccessForInjectInto:source: (in category 'tests') ----- supportTestSourceRangeAccessForInjectInto: method source: source "Test debugger source range selection for inject:into:" ^self supportTestSourceRangeAccessForInjectInto: method source: source + selectionSequence: (method encoderClass supportsFullBlocks + ifTrue: ["Full blocks are searated from home method, with their own PC" + #( ':= thisValue' + 'do: [:each | nextValue := binaryBlock value: nextValue value: each]' + '^nextValue')] + ifFalse: [#( ':= thisValue' + 'do: [:each | nextValue := binaryBlock value: nextValue value: each]' + 'value: nextValue value: each' + ':= binaryBlock value: nextValue value: each' + 'nextValue := binaryBlock value: nextValue value: each' + 'value: nextValue value: each' + ':= binaryBlock value: nextValue value: each' + 'nextValue := binaryBlock value: nextValue value: each' + '^nextValue')]).! - selectionSequence: #( ':= thisValue' - 'do: [:each | nextValue := binaryBlock value: nextValue value: each]' - 'value: nextValue value: each' - ':= binaryBlock value: nextValue value: each' - 'nextValue := binaryBlock value: nextValue value: each' - 'value: nextValue value: each' - ':= binaryBlock value: nextValue value: each' - 'nextValue := binaryBlock value: nextValue value: each' - '^nextValue')! Item was changed: ----- Method: ClosureCompilerTest>>supportTestSourceRangeAccessForInjectInto:source:selectionSequence: (in category 'tests') ----- supportTestSourceRangeAccessForInjectInto: method source: source selectionSequence: selections "Test debugger source range selection for inject:into:" | evaluationCount sourceMap debugTokenSequence debugCount | DebuggerMethodMap voidMapCache. evaluationCount := 0. + sourceMap := method debuggerMap abstractSourceMapForMethod: method. - sourceMap := method debuggerMap abstractSourceMap. debugTokenSequence := selections collect: [:string| Scanner new scanTokens: string]. debugCount := 0. thisContext runSimulated: [(1 to: 2) withArgs: { 0. [:sum :each| evaluationCount := evaluationCount + 1. sum + each]} executeMethod: method] contextAtEachStep: [:ctxt| | range debugTokens | (ctxt method == method and: ["Exclude the send of #blockCopy: or #closureCopy:copiedValues: and braceWith:with: to create the block, and the #new: and #at:'s for the indirect temp vector. This for compilation without closure bytecodes. (Note that at:put:'s correspond to stores)" (ctxt willSend and: [(#(closureCopy:copiedValues: blockCopy: new: at: braceWith:with:) includes: ctxt selectorToSendOrSelf) not]) "Exclude the store of the argument into the home context (for BlueBook blocks) and the store of an indirection vector into an initial temp" or: [(ctxt willStore and: [(ctxt isBlock and: [ctxt pc = ctxt startpc]) not and: [(ctxt isBlock not and: [(method usesClosureBytecodes and: [ctxt abstractPC = 2])]) not]]) or: [ctxt willReturn]]]) ifTrue: [debugTokens := debugTokenSequence at: (debugCount := debugCount + 1) ifAbsent: [#(bogusToken)]. self assert: (sourceMap includesKey: ctxt abstractPC). range := sourceMap at: ctxt abstractPC ifAbsent: [(1 to: 0)]. self assert: (Scanner new scanTokens: (source copyFrom: range first to: range last)) = debugTokens]]. self assert: evaluationCount = 2! Item was changed: ----- Method: PackageDependencyTest>>testKernel (in category 'tests') ----- testKernel self testPackage: #Kernel dependsExactlyOn: #( #'Chronology-Core' Collections Compiler Environments Files - Multilingual System #'ToolBuilder-Kernel' ).!

1 0

The Trunk: ToolsTests-nice.104.mcz
by commits＠source.squeak.org 19 Apr '21

19 Apr '21

Nicolas Cellier uploaded a new version of ToolsTests to project The Trunk: http://source.squeak.org/trunk/ToolsTests-nice.104.mcz ==================== Summary ==================== Name: ToolsTests-nice.104 Author: nice Time: 19 April 2021, 7:10:52.441183 pm UUID: 1ddda785-3f79-1643-bdc5-bf74b3123646 Ancestors: ToolsTests-nice.103 Fix the somehow fragile testSelectedMessageName. Serious tests would require some form of well controlled mocks, but is it really worth? =============== Diff against ToolsTests-nice.103 =============== Item was changed: ----- Method: DependencyBrowserTest>>testSelectedMessageName (in category 'tests - message list') ----- testSelectedMessageName "Warning!! When Collections' dependencies change, this test may start to fail!!" self assert: browser selectedMessageName isNil. browser packageListIndex: (browser packageList indexOf: #Collections). self assert: browser selectedMessageName isNil. browser packageDepsIndex: (browser packageDeps indexOf: #Compiler). self assert: browser selectedMessageName isNil. browser classDepsIndex: (browser classDeps indexOf: #Scanner). self assert: browser selectedMessageName isNil. browser classListIndex: (browser classList indexOf: #Symbol). + self assert: browser selectedMessageName == #isMessageSelector. - self assert: browser selectedMessageName == #storeOn:. browser messageListIndex: 1. + self assert: browser selectedMessageName == #isMessageSelector. - self assert: browser selectedMessageName == #storeOn:. browser messageListIndex: 0. self assert: browser selectedMessageName isNil.!

1 0

The Trunk: Kernel-nice.1390.mcz
by commits＠source.squeak.org 19 Apr '21

19 Apr '21

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.1390.mcz ==================== Summary ==================== Name: Kernel-nice.1390 Author: nice Time: 19 April 2021, 6:37:54.360183 pm UUID: 3ba56195-f0d4-454c-b3f7-d07e1eadcad7 Ancestors: Kernel-nice.1389 Fixes regression in Context >> #runSimulated:contextAtEachStep: when the message is sent to something else than thisContext. This happens when tallying sends (see MessageTally class >> #tallySendsTo:inBlock:showTree: ) This commit integrates the change poposed in: https://source.squeak.org/treated/Kernel-ct.1363.diff which was a commented version of: https://source.squeak.org/treated/Kernel-ct.1362.diff Thanks Christoph for the fix! Also implement #asContextWithSender: in Context so that testRunSimulatedContextAtEachStep continues to work. Thanks Jaromir for the suggestion. =============== Diff against Kernel-nice.1389 =============== Item was added: + ----- Method: Context>>asContextWithSender: (in category 'closure support') ----- + asContextWithSender: aContext + self privSender: aContext. + ^ self! Item was changed: ----- Method: Context>>runSimulated:contextAtEachStep: (in category 'system simulation') ----- runSimulated: aBlock contextAtEachStep: anotherBlock "Simulate the execution of the argument, aBlock, until it ends or is curtailed. If any exception is signaled during the execution, simulate it being handled on the present caller stack. Evaluate anotherBlock with the current context prior to each instruction executed. Answer the simulated value of aBlock." | current resume ensure | resume := false. + "Affect the context stack of the receiver during the simulation of aBlock." + current := aBlock asContextWithSender: self. + "Insert outer context denoting the end of the simulation." + ensure := (ensure := current) insertSender: (Context contextEnsure: + [resume := true. + ensure privSender: thisContext home sender]). - current := aBlock asContext. - ensure := current insertSender: (Context contextEnsure: [resume := true]). - ensure sender ifNil: [ensure privSender: self]. "For backward compatibility, do not fail if aBlock is dead." (anotherBlock numArgs = 0 ifTrue: ["optimized" [resume]] ifFalse: ["stop execution on time, don't expose simulation details to caller" [current == ensure or: ["Context >> #resume:" current size >= 2 and: [(current at: 2) == ensure]]] ]) whileFalse: [anotherBlock cull: current. current := current step]. + "Continue with the execution in the previous context." ^ current jump!

1 0

The Trunk: System-mt.1229.mcz
by commits＠source.squeak.org 19 Apr '21

19 Apr '21

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1229.mcz ==================== Summary ==================== Name: System-mt.1229 Author: mt Time: 19 April 2021, 4:25:07.545053 pm UUID: e30af833-38ea-524f-b023-4657894a7d92 Ancestors: System-mt.1228 Fixes #changeStampPerSe and use it to remove interruptions from the update stream (again). =============== Diff against System-mt.1228 =============== Item was changed: ----- Method: ChangeSet>>event: (in category 'change logging') ----- event: anEvent "Hook for SystemChangeNotifier" anEvent itemKind = SystemChangeNotifier classKind ifTrue: [ anEvent isRemoved ifTrue: [self noteRemovalOf: anEvent item]. anEvent isAdded ifTrue: [self addClass: anEvent item]. anEvent isModified ifTrue: [anEvent anyChanges ifTrue: [self changeClass: anEvent item from: anEvent oldItem]]. anEvent isCommented ifTrue: [self commentClass: anEvent item]. anEvent isRenamed ifTrue: [self renameClass: anEvent item from: anEvent oldName to: anEvent newName]. anEvent isReorganized ifTrue: [self reorganizeClass: anEvent item]. anEvent isRecategorized ifTrue: [self changeClass: anEvent item from: anEvent item]. ]. anEvent itemKind = SystemChangeNotifier methodKind ifTrue: [ anEvent isAdded ifTrue: [self noteNewMethod: anEvent item forClass: anEvent itemClass selector: anEvent itemSelector priorMethod: nil]. anEvent isModified ifTrue: [self noteNewMethod: anEvent item forClass: anEvent itemClass selector: anEvent itemSelector priorMethod: anEvent oldItem]. anEvent isRemoved + ifTrue: [self removeSelector: anEvent itemSelector class: anEvent itemClass priorMethod: anEvent item lastMethodInfo: {anEvent item sourcePointer. anEvent itemProtocol. Utilities changeStampPerSe}]. - ifTrue: [self removeSelector: anEvent itemSelector class: anEvent itemClass priorMethod: anEvent item lastMethodInfo: {anEvent item sourcePointer. anEvent itemProtocol. Utilities changeStamp}]. anEvent isRecategorized ifTrue: [self reorganizeClass: anEvent itemClass]. ].! Item was changed: ----- Method: ClassChangeRecord>>noteChangeType:fromClass: (in category 'all changes') ----- noteChangeType: changeSymbol fromClass: class + timeStamp := Utilities changeStampPerSe. - timeStamp := Utilities changeStamp. (changeSymbol = #new or: [changeSymbol = #add]) ifTrue: [changeTypes add: #add. changeTypes remove: #change ifAbsent: []. revertable := false. ^ self]. changeSymbol = #change ifTrue: [(changeTypes includes: #add) ifTrue: [^ self]. ^ changeTypes add: changeSymbol]. changeSymbol == #addedThenRemoved ifTrue: [^ self]. "An entire class was added but then removed" changeSymbol = #comment ifTrue: [^ changeTypes add: changeSymbol]. changeSymbol = #reorganize ifTrue: [^ changeTypes add: changeSymbol]. changeSymbol = #rename ifTrue: [^ changeTypes add: changeSymbol]. (changeSymbol beginsWith: 'oldName: ') ifTrue: ["Must only be used when assimilating other changeSets" (changeTypes includes: #add) ifTrue: [^ self]. priorName := changeSymbol copyFrom: 'oldName: ' size + 1 to: changeSymbol size. ^ changeTypes add: #rename]. changeSymbol = #remove ifTrue: [(changeTypes includes: #add) ifTrue: [changeTypes add: #addedThenRemoved] ifFalse: [changeTypes add: #remove]. ^ changeTypes removeAllFoundIn: #(add change comment reorganize)]. self error: 'Unrecognized changeType'! Item was changed: ----- Method: Utilities class>>changeStampPerSe (in category 'identification') ----- changeStampPerSe "Answer a string to be pasted into source code to mark who changed it and when." ^String streamContents: [ : stream | + stream nextPutAll: (self authorInitialsPerSe isEmptyOrNil - self authorInitialsPerSe isEmptyOrNil ifTrue: [ '·' ] + ifFalse: [ self authorInitialsPerSe ]). - ifFalse: [ self authorInitialsPerSe ]. stream space ; nextPutAll: Date today mmddyyyy ; space. + stream nextPutAll: ((String streamContents: - (String streamContents: [ : s | Time now print24: true on: s ]) copyFrom: 1 + to: 5) ]! - to: 5 ]!

1 0

The Trunk: MorphicTests-mt.79.mcz
by commits＠source.squeak.org 19 Apr '21

19 Apr '21

Marcel Taeumel uploaded a new version of MorphicTests to project The Trunk: http://source.squeak.org/trunk/MorphicTests-mt.79.mcz ==================== Summary ==================== Name: MorphicTests-mt.79 Author: mt Time: 19 April 2021, 10:04:21.810053 am UUID: 7bae0322-f841-224f-ac06-f4e370992115 Ancestors: MorphicTests-mt.78 Update test03EventHandler to be more realistic. Avoid triggering the mouse-focus-event-disptach path. =============== Diff against MorphicTests-mt.78 =============== Item was changed: ----- Method: MorphicEventTests>>test03EventHandler (in category 'tests') ----- test03EventHandler + "Test a morph's event handler, which is configured via #on:send:to:. Note that the handler only reacts on #mouseDown but we do send a #mouseUp to reset the mouse focus to ensure the same event-dispatching flow for all three mouse buttons." | m | m := Morph new. m extent: 20@20; topLeft: 0@0. m wantsHaloFromClick: false. m wantsYellowButtonMenu: false. m wantsMetaMenu: false. m on: #mouseDown send: #value: to: [:evt| evt redButtonPressed ifTrue:[m color: Color red]. evt yellowButtonPressed ifTrue:[m color: Color yellow]. evt blueButtonPressed ifTrue:[m color: Color blue]]. m color: Color blue. m openInWorld: world. + self assert: hand mouseFocus isNil. hand handleEvent: (self redMouseDownAt: m center). + hand handleEvent: (self redMouseUpAt: m center). self assert: Color red equals: m color. + self assert: hand mouseFocus isNil. hand handleEvent: (self yellowMouseDownAt: m center). + hand handleEvent: (self yellowMouseUpAt: m center). self assert: Color yellow equals: m color. + + self assert: hand mouseFocus isNil. - hand handleEvent: (self blueMouseDownAt: m center). + hand handleEvent: (self blueMouseUpAt: m center). self assert: Color blue equals: m color.! Item was added: + ----- Method: UserInputEventTests>>blueMouseUpAt: (in category 'support') ----- + blueMouseUpAt: point + + ^ MouseButtonEvent new + setType: #mouseUp + position: point + which: 2r001 "blue changed" + buttons: 2r000 "nothing pressed" + hand: hand + stamp: Time millisecondClockValue! Item was added: + ----- Method: UserInputEventTests>>yellowMouseUpAt: (in category 'support') ----- + yellowMouseUpAt: point + + ^ MouseButtonEvent new + setType: #mouseUp + position: point + which: 2r010 "yellow changed" + buttons: 2r000 "nothing pressed" + hand: hand + stamp: Time millisecondClockValue!

1 0

The Trunk: Morphic-mt.1755.mcz
by commits＠source.squeak.org 18 Apr '21

18 Apr '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1755.mcz ==================== Summary ==================== Name: Morphic-mt.1755 Author: mt Time: 18 April 2021, 7:00:43.878254 pm UUID: e5705780-2988-a54e-b6c7-21b4194fcd5c Ancestors: Morphic-mt.1754, Morphic-ct.1659 Fix our two menu-invocating buttons to act on mouse-down and actually look like menus: (1) menu button in system window and (2) change-set button in world-main-docking-bar. Merges Morphic-ct.1659. Thanks Christoph (ct) for pointing out this issue about menu invocation through buttons. See http://forum.world.st/The-Inbox-Morphic-ct-1659-mcz-tp5116728.html By example, this commit also adds a menu to the change-set button in the docking bar. This menu lists the latest method and class changes. To make this work, the following things got addressed: - Fixes DockingBarUpdatingItemMorph, which missed several changes from DockingBarItemMorph. (Interesting specialization challenge...) - Let menus #rubberBandCells to allow for changing menu item's widths. - Adds query about latest changes to #listChangesOn:. (Feel free to improve this. Maybe add preference for number of elements?) Complements (and depends on) System-mt.1228 and Tools-mt.1042. =============== Diff against Morphic-mt.1754 =============== Item was changed: ----- Method: DockingBarMorph>>addUpdatingItem: (in category 'construction') ----- addUpdatingItem: aBlock | item | item := DockingBarUpdatingItemMorph new. aBlock value: item. + item subMenu ifNotNil: [:menu | + "Docking bar and protruding menu should appear visually merged." + menu morphicLayerNumber: self morphicLayerNumber + 1]. self addMorphBack: item! Item was changed: ----- Method: DockingBarMorph>>ensureSelectedItem: (in category 'events') ----- ensureSelectedItem: evt self selectedItem ifNil: [ self selectItem: ( self submorphs + detect: [ :each | each isMenuItemMorph ] - detect: [ :each | each isKindOf: DockingBarItemMorph ] ifNone: [ ^self ]) event: evt ]! Item was changed: ----- Method: DockingBarMorph>>filterEvent:for: (in category 'events-processing') ----- filterEvent: aKeyboardEvent for: anObject "Provide keyboard shortcuts." | index itemToSelect | aKeyboardEvent controlKeyPressed ifFalse: [^ aKeyboardEvent]. aKeyboardEvent isKeystroke ifFalse: [^ aKeyboardEvent]. "Search field." aKeyboardEvent keyCharacter = $0 ifTrue: [ self searchBarMorph ifNotNil: [ :morph | morph model activate: aKeyboardEvent in: morph ]. ^ aKeyboardEvent ignore "hit!!"]. "Select menu items." (aKeyboardEvent keyValue between: $1 asciiValue and: $9 asciiValue) ifFalse: [^ aKeyboardEvent]. index := aKeyboardEvent keyValue - $1 asciiValue + 1. itemToSelect := (self submorphs select: [ :each | + each isMenuItemMorph ]) - each isKindOf: DockingBarItemMorph ]) at: index ifAbsent: [^ aKeyboardEvent]. self activate: aKeyboardEvent. self selectItem: itemToSelect event: aKeyboardEvent. ^ aKeyboardEvent ignore "hit!!"! Item was changed: ----- Method: DockingBarMorph>>moveSelectionDown:event: (in category 'control') ----- moveSelectionDown: direction event: evt "Move the current selection up or down by one, presumably under keyboard control. direction = +/-1" | index | index := (submorphs indexOf: selectedItem ifAbsent: [1-direction]) + direction. submorphs do: "Ensure finite" [:unused | | m | m := submorphs atWrap: index. + (m isMenuItemMorph and: [m isEnabled]) ifTrue: - ((m isKindOf: DockingBarItemMorph) and: [m isEnabled]) ifTrue: [^ self selectItem: m event: evt]. "Keep looking for an enabled item" index := index + direction sign]. ^ self selectItem: nil event: evt! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>adjacentTo (in category 'selecting') ----- + adjacentTo + + | roundedCornersOffset verticalOffset | + roundedCornersOffset := MenuMorph roundedMenuCorners + ifTrue: [Morph preferredCornerRadius negated] + ifFalse: [0]. + verticalOffset := 2. + + owner isFloating + ifTrue: [^ {self bounds bottomLeft + (roundedCornersOffset @ verticalOffset)}]. + owner isAdheringToTop + ifTrue: [^ {self bounds bottomLeft + (roundedCornersOffset @ verticalOffset)}]. + owner isAdheringToLeft + ifTrue: [^ {self bounds topRight + (roundedCornersOffset @ verticalOffset)}]. + owner isAdheringToBottom + ifTrue: [^ {self bounds topLeft + (roundedCornersOffset @ verticalOffset)}]. + owner isAdheringToRight + ifTrue: [^ {self bounds topLeft + (roundedCornersOffset @ verticalOffset negated)}]. + ^ {self bounds bottomLeft + (roundedCornersOffset @ 5)}! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>createSubmenu (in category 'private') ----- + createSubmenu + + ^DockingBarMenuMorph new! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>createUpdatingSubmenu (in category 'private') ----- + createUpdatingSubmenu + + ^DockingBarUpdatingMenuMorph new! Item was changed: + ----- Method: DockingBarUpdatingItemMorph>>decorateOwner (in category 'world') ----- - ----- Method: DockingBarUpdatingItemMorph>>decorateOwner (in category 'as yet unclassified') ----- decorateOwner "Ignore."! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>drawIconOn: (in category 'drawing') ----- + drawIconOn: aCanvas + + | pos | + self hasIcon ifTrue: [ + | iconForm | + iconForm := self iconForm. + + pos := (contents + ifEmpty: [self left + (self width - iconForm width // 2)] + ifNotEmpty: [self left]) + @ (self top + (self height - iconForm height // 2)). + + aCanvas + translucentImage: iconForm + at: pos].! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>drawLabelOn: (in category 'drawing') ----- + drawLabelOn: aCanvas + + | stringBounds | + self contents ifEmpty: [^ self]. + + stringBounds := bounds. + + self hasIcon ifTrue: [ + stringBounds := stringBounds left: stringBounds left + self iconForm width + 2 ]. + + "Vertical centering." + stringBounds := stringBounds top: stringBounds top + stringBounds bottom - self fontToUse height // 2. + "Horizontal centering." + stringBounds := stringBounds left: stringBounds left + (stringBounds width - (self fontToUse widthOfString: contents) // 2) abs. + + aCanvas + drawString: contents + in: stringBounds + font: self fontToUse + color: self colorToUse.! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>drawSubMenuMarkerOn: (in category 'drawing') ----- + drawSubMenuMarkerOn: aCanvas + "Ignore."! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>mouseDown: (in category 'events') ----- + mouseDown: evt + "Handle a mouse down event. Menu items get activated when the mouse is over them." + + (evt shiftPressed and:[self wantsKeyboardFocusOnShiftClick]) ifTrue: [ ^super mouseDown: evt ]. "enable label editing" + isSelected + ifTrue: [ + owner selectItem: nil event: evt. ] + ifFalse: [ + owner activate: evt. "Redirect to menu for valid transitions" + owner selectItem: self event: evt. ] + ! Item was changed: + ----- Method: DockingBarUpdatingItemMorph>>mouseEnter: (in category 'events') ----- - ----- Method: DockingBarUpdatingItemMorph>>mouseEnter: (in category 'as yet unclassified') ----- mouseEnter: evt "Do not hover docking bar items directory. Mouse-down required. But if you already see a submenu, support hovering." owner selectedItem ifNotNil: [owner selectItem: self event: evt]! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>mouseUp: (in category 'events') ----- + mouseUp: evt + "Handle a mouse up event. Menu items get activated when the mouse is over them. Do nothing if we're not in a 'valid menu transition', meaning that the current hand focus must be aimed at the owning menu." + + evt hand mouseFocus == owner ifFalse: [ ^self ]. + self contentString ifNotNil: [ + self contents: self contentString withMarkers: true inverse: true. + self refreshWorld. + (Delay forMilliseconds: 200) wait ].! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>select: (in category 'selecting') ----- + select: evt + + super select: evt. + subMenu ifNotNil: [ + evt hand newKeyboardFocus: subMenu ]! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>wantsKeyboardFocusOnShiftClick (in category 'events') ----- + wantsKeyboardFocusOnShiftClick + "set this preference to false to prevent user editing of docking bar menu items" + ^Preferences valueOfPreference: #allowMenubarItemEditing ifAbsent: [false]! Item was added: + ----- Method: DockingBarUpdatingMenuMorph>>morphicLayerNumber: (in category 'update') ----- + morphicLayerNumber: n + + super morphicLayerNumber: n. + ! Item was changed: ----- Method: MenuMorph>>initialize (in category 'initialization') ----- initialize super initialize. self setDefaultParameters. self changeTableLayout. self listDirection: #topToBottom. self hResizing: #shrinkWrap. self vResizing: #shrinkWrap. + self rubberBandCells: true. self disableLayout: true. self morphicLayerNumber: self class menuLayer. defaultTarget := nil. selectedItem := nil. stayUp := false. popUpOwner := nil.! Item was changed: ----- Method: SystemWindow>>createMenuBox (in category 'initialization') ----- createMenuBox ^ (self createBox: self class menuBoxImage) actionSelector: #offerWindowMenu; + setBalloonText: 'window menu' translated; + actWhen: #buttonDown; + yourself! - setBalloonText: 'window menu' translated! Item was changed: + ----- Method: TheWorldMainDockingBar>>browseChanges (in category 'submenu - changes') ----- - ----- Method: TheWorldMainDockingBar>>browseChanges (in category 'right side') ----- browseChanges ChangeSorter open.! Item was changed: + ----- Method: TheWorldMainDockingBar>>browseChangesLabel (in category 'submenu - changes') ----- - ----- Method: TheWorldMainDockingBar>>browseChangesLabel (in category 'right side') ----- browseChangesLabel "The project name is the same as the current change set." ^ Project current name! Item was added: + ----- Method: TheWorldMainDockingBar>>changesMenuOn: (in category 'submenu - changes') ----- + changesMenuOn: aDockingBar + + aDockingBar addUpdatingItem: [:item | + item + help: 'Browse this project''s changes' translated; + wordingProvider: self + wordingSelector: #browseChangesLabel; + subMenuUpdater: self + selector: #listChangesOn:].! Item was changed: ----- Method: TheWorldMainDockingBar>>fillDockingBar: (in category 'construction') ----- fillDockingBar: aDockingBar "Private - fill the given docking bar" self menusOn: aDockingBar. aDockingBar addSpacer. + self changesMenuOn: aDockingBar. - self projectNameOn: aDockingBar. aDockingBar addSpacer. self rightSideOn: aDockingBar. aDockingBar setProperty: #mainDockingBarTimeStamp toValue: self class timeStamp.! Item was added: + ----- Method: TheWorldMainDockingBar>>listChangesOn: (in category 'submenu - changes') ----- + listChangesOn: menu + + | latestMethodChanges latestClassChanges| + latestMethodChanges := (Array streamContents: [:s | + ChangeSet current changedMethodsDo: [:method :changeType :dateAndTime :category | + s nextPut: { dateAndTime. method. changeType. category }]]) + sorted: [:a :b | a first >= b first]. + + 1 to: (10 min: latestMethodChanges size) do: [:index | | spec method | + spec := latestMethodChanges at: index. + method := spec second. + menu addItem: [:item | + item + contents: ('{1} {2} \{{3}\} \{{4}\}' format: {method methodClass. method selector. spec fourth. method methodClass category}) ; + target: ToolSet; + balloonText: spec third asString; + icon: ((#(remove addedThenRemoved) includes: spec third) ifTrue: [MenuIcons smallDeleteIcon] ifFalse: [ + spec third = #add ifTrue: [MenuIcons smallNewIcon] ifFalse: [MenuIcons blankIcon]]); + selector: (method isInstalled ifTrue: [#browseMethod:] ifFalse: [#browseMethodVersion:]); + arguments: {method}]]. + + latestClassChanges := (Array streamContents: [:s | + ChangeSet current changedClassesDo: [:class :changeTypes :dateAndTime :category | + "We are not interested in classes whose method's did only change." + changeTypes ifNotEmpty: [s nextPut: { dateAndTime. class. changeTypes. category }]]]) + sorted: [:a :b | a first >= b first]. + + latestClassChanges ifNotEmpty: [menu addLine]. + 1 to: (10 min: latestClassChanges size) do: [:index | | spec class | + spec := latestClassChanges at: index. + class := spec second. + menu addItem: [:item | + item + contents: ('{1} \{{2}\}' format: {class name. spec fourth }) ; + target: ToolSet; + balloonText: (spec third sorted joinSeparatedBy: Character space); + icon: ((spec third includesAnyOf: #(remove addedThenRemoved)) + ifTrue: [MenuIcons smallDeleteIcon] + ifFalse: [ + (spec third includes: #add) + ifTrue: [MenuIcons smallNewIcon] + ifFalse: [MenuIcons blankIcon]]); + selector: ((spec third includes: #remove) ifTrue: [#inspect:] ifFalse: [#browseClass:]); + arguments: {class}]]. + + menu addLine; addItem: [:item | + item + contents: 'Browse current change set...' translated; + target: self; + selector: #browseChanges].! Item was removed: - ----- Method: TheWorldMainDockingBar>>projectNameOn: (in category 'right side') ----- - projectNameOn: aDockingBar - - aDockingBar addUpdatingItem: [:item | - item - help: 'Browse this project''s changes'; - target: self; - selector: #browseChanges; - wordingProvider: self - wordingSelector: #browseChangesLabel].! Item was changed: + (PackageInfo named: 'Morphic') postscript: 'TheWorldMainDockingBar updateInstances.'! - (PackageInfo named: 'Morphic') postscript: 'Transcript showln: ''[NOTICE] There is a new preference called "Interactive print-it". Please check your preference browser to choose the preferred value.'''!

1 0

The Trunk: System-mt.1228.mcz
by commits＠source.squeak.org 18 Apr '21

18 Apr '21

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1228.mcz ==================== Summary ==================== Name: System-mt.1228 Author: mt Time: 18 April 2021, 6:49:05.736254 pm UUID: 513db764-6353-204e-9724-18519504a7b5 Ancestors: System-ul.1227 Adds queries to enumerate actual domain objects for changed classes or methods. Adds change stamps for class changes and method removal. Note that I followed the not-so-good practice of using "Utilities changeStamp" to assure a single kind of timestamp (to sort later). In the future, we should change all this to DateAndTime and deprecate TimeStamp. =============== Diff against System-ul.1227 =============== Item was changed: ----- Method: ChangeSet>>changedClasses (in category 'class changes') ----- changedClasses - "Answer an OrderedCollection of changed or edited classes. - Does not include removed classes. Sort alphabetically by name." + ^ Array streamContents: [:stream | + self changedClassesDo: [:class | + stream nextPut: class]]! - "Much faster to sort names first, then convert back to classes. Because metaclasses reconstruct their name at every comparison in the sorted collection. - 8/91 sw chgd to filter out non-existent classes (triggered by problems with class-renames" - - ^ self changedClassNames - collect: [:className | Smalltalk classNamed: className] - thenSelect: [:aClass | aClass notNil]! Item was added: + ----- Method: ChangeSet>>changedClassesDo: (in category 'class changes') ----- + changedClassesDo: block + "Answer an OrderedCollection of changed or edited classes. + Does not include removed classes. Sort alphabetically by name." + + "Much faster to sort names first, then convert back to classes. Because metaclasses reconstruct their name at every comparison in the sorted collection. + 8/91 sw chgd to filter out non-existent classes (triggered by problems with class-renames" + + self flag: #environmentsMissing. + self changedClassNames do: [:className | | record class changeTypes dateAndTime category | + record := changeRecords at: className. + class := (Smalltalk classNamed: className) ifNil: [ + PseudoClass new + name: className; + definition: record priorDefinition; + yourself]. + changeTypes := record allChangeTypes. + dateAndTime := [TimeStamp fromMethodTimeStamp: record timeStamp] + ifError: [TimeStamp epoch]. + category := [class category] ifError: ['unknown']. + block + cull: class + cull: changeTypes + cull: dateAndTime + cull: category].! Item was added: + ----- Method: ChangeSet>>changedMethods (in category 'method changes') ----- + changedMethods + + ^ Array streamContents: [:stream | + self changedMethodsDo: [:class | + stream nextPut: class]]! Item was added: + ----- Method: ChangeSet>>changedMethodsDo: (in category 'method changes') ----- + changedMethodsDo: block + + self flag: #environmentsMissing. + changeRecords keysAndValuesDo: [:className :classRecord | + (Smalltalk classNamed: className) ifNotNil: [:class | + classRecord methodChanges keysAndValuesDo: [:selector :methodRecord | + | method category sourcePointer dateAndTime | + (class includesSelector: selector) + ifTrue: [ + method := class compiledMethodAt: selector. + category := class organization categoryOfElement: selector. + sourcePointer := method sourcePointer. + dateAndTime := method timeStamp] + ifFalse: [ "Method was removed. Try to reconstruct information." + methodRecord methodInfoFromRemoval ifNotNil: [:spec | + sourcePointer := spec first. + category := spec second. + method := CompiledMethod toReturnSelfTrailerBytes: + (CompiledMethodTrailer new sourcePointer: sourcePointer). + method methodClass: class; selector: selector. + dateAndTime := spec size > 2 ifTrue: [spec third]]]. + method ifNotNil: [ + dateAndTime := [TimeStamp fromMethodTimeStamp: dateAndTime] + ifError: [TimeStamp epoch]. + block + cull: method + cull: methodRecord changeType + cull: dateAndTime + cull: category]]]].! Item was added: + ----- Method: ChangeSet>>classChanges (in category 'accessing') ----- + classChanges + + ^ changeRecords keys select: + [:className | (changeRecords at: className) allChangeTypes notEmpty]! Item was changed: ----- Method: ChangeSet>>event: (in category 'change logging') ----- event: anEvent "Hook for SystemChangeNotifier" anEvent itemKind = SystemChangeNotifier classKind ifTrue: [ anEvent isRemoved ifTrue: [self noteRemovalOf: anEvent item]. anEvent isAdded ifTrue: [self addClass: anEvent item]. anEvent isModified ifTrue: [anEvent anyChanges ifTrue: [self changeClass: anEvent item from: anEvent oldItem]]. anEvent isCommented ifTrue: [self commentClass: anEvent item]. anEvent isRenamed ifTrue: [self renameClass: anEvent item from: anEvent oldName to: anEvent newName]. anEvent isReorganized ifTrue: [self reorganizeClass: anEvent item]. anEvent isRecategorized ifTrue: [self changeClass: anEvent item from: anEvent item]. ]. anEvent itemKind = SystemChangeNotifier methodKind ifTrue: [ anEvent isAdded ifTrue: [self noteNewMethod: anEvent item forClass: anEvent itemClass selector: anEvent itemSelector priorMethod: nil]. anEvent isModified ifTrue: [self noteNewMethod: anEvent item forClass: anEvent itemClass selector: anEvent itemSelector priorMethod: anEvent oldItem]. anEvent isRemoved + ifTrue: [self removeSelector: anEvent itemSelector class: anEvent itemClass priorMethod: anEvent item lastMethodInfo: {anEvent item sourcePointer. anEvent itemProtocol. Utilities changeStamp}]. - ifTrue: [self removeSelector: anEvent itemSelector class: anEvent itemClass priorMethod: anEvent item lastMethodInfo: {anEvent item sourcePointer. anEvent itemProtocol}]. anEvent isRecategorized ifTrue: [self reorganizeClass: anEvent itemClass]. ].! Item was changed: Object subclass: #ClassChangeRecord + instanceVariableNames: 'inForce revertable changeTypes thisDefinition priorDefinition thisName priorName thisOrganization priorOrganization thisComment priorComment thisMD priorMD methodChanges timeStamp' - instanceVariableNames: 'inForce revertable changeTypes thisDefinition priorDefinition thisName priorName thisOrganization priorOrganization thisComment priorComment thisMD priorMD methodChanges' classVariableNames: '' poolDictionaries: '' category: 'System-Changes'! !ClassChangeRecord commentStamp: 'fbs 9/6/2013 17:32' prior: 0! A ClassChangeRecorder keeps track of most substantive changes permissible in a project, isolated or not. Structure: inForce a boolean Tells whether these changes are in effect. true for all changeSets in and above the current project. It should be sufficient only to record this for the changeSet as a whole, but this redundancy could help in error recovery. classIsLocal a boolean True if and only if this class is defined in this layer of the project structure. changeTypes an identitySet Summarizes which changes have been made in this class. Values include #comment, #reorganize, #rename, and the four more summarized below. thisName a string Retains the class name for this layer. priorName a string Preserves the prior name. thisComment a text Retains the class comment for this layer. priorComment a text Preserves the prior comment. thisOrganization a classOrganizer Retains the class organization for this layer. priorOrganization a classOrganizer Preserves the prior organization. thisMD a methodDictionary Used to prepare changes for nearly atomic invocation of this layer (see below). priorMD a methodDictionary Preserves the state of an altered class as it exists in the next outer layer of the project structure. methodChanges a dictionary of classChangeRecords Retains all the method changes for this layer. Four of the possible changeTypes are maintained in a mutually exclusive set, analogously to MethodChangeRecords. Here is a simple summary of the relationship between these four changeType symbols and the recording of prior state | prior == nil | prior not nil --------- |---------------------------- |-------------------- add | add | change --------- |---------------------------- |-------------------- remove | addedThenRemoved | remove A classChangeRecorder is notified of changes by the method noteMethodChange: <ClassChangeRecord>. ClassChangeRecorders are designed to invoke a set of changes relative to the definition of a class in an prior layer. It is important that both invocation and revocation of these changes take place in a nearly atomic fashion so that interdependent changes will be adopted as a whole, and so that only one flush of the method cache should be necessary. A further reason for revocation to be simple is that it may be requested as an attempt to recover from an error in a project that is failing.! Item was changed: ----- Method: ClassChangeRecord>>noteChangeType:fromClass: (in category 'all changes') ----- noteChangeType: changeSymbol fromClass: class + timeStamp := Utilities changeStamp. (changeSymbol = #new or: [changeSymbol = #add]) ifTrue: [changeTypes add: #add. changeTypes remove: #change ifAbsent: []. revertable := false. ^ self]. changeSymbol = #change ifTrue: [(changeTypes includes: #add) ifTrue: [^ self]. ^ changeTypes add: changeSymbol]. changeSymbol == #addedThenRemoved ifTrue: [^ self]. "An entire class was added but then removed" changeSymbol = #comment ifTrue: [^ changeTypes add: changeSymbol]. changeSymbol = #reorganize ifTrue: [^ changeTypes add: changeSymbol]. changeSymbol = #rename ifTrue: [^ changeTypes add: changeSymbol]. (changeSymbol beginsWith: 'oldName: ') ifTrue: ["Must only be used when assimilating other changeSets" (changeTypes includes: #add) ifTrue: [^ self]. priorName := changeSymbol copyFrom: 'oldName: ' size + 1 to: changeSymbol size. ^ changeTypes add: #rename]. changeSymbol = #remove ifTrue: [(changeTypes includes: #add) ifTrue: [changeTypes add: #addedThenRemoved] ifFalse: [changeTypes add: #remove]. ^ changeTypes removeAllFoundIn: #(add change comment reorganize)]. self error: 'Unrecognized changeType'! Item was added: + ----- Method: ClassChangeRecord>>timeStamp (in category 'accessing') ----- + timeStamp + + ^ timeStamp!

1 0

The Trunk: Tools-mt.1042.mcz
by commits＠source.squeak.org 18 Apr '21

18 Apr '21

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.1042.mcz ==================== Summary ==================== Name: Tools-mt.1042 Author: mt Time: 18 April 2021, 6:43:53.338254 pm UUID: 3fd43581-c48b-154a-9dfa-7d666d9d5076 Ancestors: Tools-nice.1041 In change records, make info about removal more robust and extensible. =============== Diff against Tools-nice.1041 =============== Item was changed: ----- Method: ChangeSorter>>browseVersions (in category 'message list') ----- browseVersions "Create and schedule a changelist browser on the versions of the selected message." | class selector method category pair sourcePointer | (selector := self selectedMessageName) ifNil: [^ self]. class := self selectedClassOrMetaClass. (class includesSelector: selector) ifTrue: [method := class compiledMethodAt: selector. category := class whichCategoryIncludesSelector: selector. sourcePointer := nil] ifFalse: [pair := myChangeSet methodInfoFromRemoval: {class name. selector}. pair ifNil: [^ nil]. sourcePointer := pair first. method := CompiledMethod toReturnSelfTrailerBytes: (CompiledMethodTrailer new sourcePointer: sourcePointer). + category := pair second]. - category := pair last]. VersionsBrowser browseVersionsOf: method class: self selectedClass meta: class isMeta category: category selector: selector lostMethodPointer: sourcePointer. ! Item was changed: ----- Method: StandardToolSet class>>browseVersionsOf:selector: (in category 'browsing') ----- browseVersionsOf: class selector: selector "Open and answer a browser on versions of the method. If the method doesn't exist try and find version from the current change set. If not found there, answer nil." | methodOrNil methodCategory | methodOrNil := class compiledMethodAt: selector ifAbsent: []. methodOrNil ifNil: [(ChangeSet current methodInfoFromRemoval: {class name. selector}) ifNil: [^nil] ifNotNil: [:pair| methodOrNil := CompiledMethod toReturnSelfTrailerBytes: (CompiledMethodTrailer new sourcePointer: pair first). + methodCategory := pair second]]. - methodCategory := pair last]]. ^VersionsBrowser browseVersionsOf: methodOrNil class: class theNonMetaClass meta: class isMeta category: (methodCategory ifNil: [class organization categoryOfElement: selector]) selector: selector!

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
23
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Packages April 2021