Marcel Taeumel uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-mt.751.mcz
==================== Summary ====================
Name: Monticello-mt.751 Author: mt Time: 25 August 2021, 2:10:46.685495 pm UUID: 2b8f812c-fa9e-2240-bd68-92cff0f7015a Ancestors: Monticello-ct.750
Removes dependecy from Services package. Implement "browse revisions" hooks via simple menu extensions in CodeHolder.
=============== Diff against Monticello-ct.750 ===============
Item was removed: - ----- Method: BrowserRequestor>>browseMcClassRevisions (in category '*monticello-revisions') ----- - browseMcClassRevisions - "Open a browser on all versions of this class available in the MC repository for this package." - self getClass - ifNil: [ UIManager inform: 'No class selected' ] - ifNotNilDo: - [ : theClass | theClass theNonMetaClass mcModel - ifNil: [ UIManager inform: 'Only Magma-backed HTTP repositories (or MCMagmaRepositorys) support browsing Monticello revisions.' ] - ifNotNil: - [ : mcModel | (MCOperationsList operations: (Cursor wait showWhile: [ theClass theNonMetaClass mcPatchOperations ])) browse ] ]!
Item was removed: - ----- Method: BrowserRequestor>>browseMcMethodRevisions (in category '*monticello-revisions') ----- - browseMcMethodRevisions - "Open a browser on all versions of this method available in the MC repository for this package." - self selectedMethodReference - ifNil: [ UIManager inform: 'No method selected' ] - ifNotNilDo: - [ : methodReference | methodReference mcModel - ifNil: [ UIManager inform: 'Only Magma-backed HTTP repositories (or MCMagmaRepositorys) support browsing Monticello revisions.' ] - ifNotNil: [ (MCOperationsList operations: (Cursor wait showWhile: [ methodReference mcPatchOperations ])) browse ] ]!
Item was removed: - ----- Method: BrowserRequestor>>selectedMethodReference (in category '*monticello-revisions') ----- - selectedMethodReference - ^ MethodReference - class: self getClass - selector: self getBrowser selectedMessageName!
Item was added: + ----- Method: ClassReference>>mcModel (in category '*monticello') ----- + mcModel + + ^ self actualClass theNonMetaClass mcModel!
Item was added: + ----- Method: ClassReference>>mcPatchOperations (in category '*monticello') ----- + mcPatchOperations + + ^ self actualClass theNonMetaClass mcPatchOperations!
Item was added: + ----- Method: CodeHolder>>classListMenuMonticello: (in category '*monticello-revisions') ----- + classListMenuMonticello: aMenu + <classListMenu> + <menuPriority: 140> + + | selectedClassReference | + selectedClassReference := self selectedClassOrMetaClass + ifNotNil: [:class | ClassReference class: class ]. + selectedClassReference ifNil: [^ aMenu]. + aMenu + add: 'browse revisions' translated + target: MCRepository + selector: #browseClassRevisionsOf: + argument: selectedClassReference. + ^ aMenu!
Item was added: + ----- Method: CodeHolder>>messageListMenuMonticello: (in category '*monticello-revisions') ----- + messageListMenuMonticello: aMenu + <messageListMenu> + <menuPriority: 140> + + | selectedMethodReference | + selectedMethodReference := self selectedClassOrMetaClass + ifNotNil: [:class | self selectedMessageName ifNotNil: [:selector | + MethodReference class: class selector: selector]]. + selectedMethodReference ifNil: [^ aMenu]. + aMenu + add: 'browse revisions' translated + target: MCRepository + selector: #browseMethodRevisionsOf: + argument: selectedMethodReference. + ^ aMenu!
Item was removed: - ----- Method: MCHttpRepository class>>initialize (in category 'class initialization') ----- - initialize - self unload. - (ServiceRegistry current serviceWithId: #browserMethodMenu) services add: self browseMethodRevisionsService. - (ServiceRegistry current serviceWithId: #browserClassMenu) services add: self browseClassRevisionsService!
Item was removed: - ----- Method: MCHttpRepository class>>unload (in category 'class initialization') ----- - unload - | methodMenuServiceCategory classMenuServiceCategory | - methodMenuServiceCategory := ServiceRegistry current serviceWithId: #browserMethodMenu. - methodMenuServiceCategory services copy do: - [ : each | (#(#browseMcMethodRevisions #browseMcMethodOrigin ) includes: each id) ifTrue: [ methodMenuServiceCategory services remove: each ] ]. - classMenuServiceCategory := ServiceRegistry current serviceWithId: #browserClassMenu. - classMenuServiceCategory services copy do: - [ : each | (#(#browseMcClassRevisions #browseMcClassOrigin ) includes: each id) ifTrue: [ classMenuServiceCategory services remove: each ] ]!
Item was added: + ----- Method: MCRepository class>>browseClassRevisionsOf: (in category 'ui-support') ----- + browseClassRevisionsOf: classReference + + classReference ifNil: [ Project uiManager inform: 'No class selected' ]. + + classReference mcModel + ifNil: [ Project uiManager inform: 'Only Magma-backed HTTP repositories (or MCMagmaRepositorys) support browsing Monticello revisions.' ] + ifNotNil: [ (MCOperationsList operations: (Cursor wait showWhile: [ classReference mcPatchOperations ])) browse ] !
Item was removed: - ----- Method: MCRepository class>>browseClassRevisionsService (in category 'ui-support') ----- - browseClassRevisionsService - ^ ServiceAction - id: #browseMcClassRevisions - text: 'browse revisions' - button: 'mc' - description: 'Browse revisions of this class definition from the first-listed HTTP repository of this package.' - action: - [ : aBrowserRequestor | aBrowserRequestor browseMcClassRevisions ] - condition: - [ : aBrowserRequestor | true ]!
Item was added: + ----- Method: MCRepository class>>browseMethodRevisionsOf: (in category 'ui-support') ----- + browseMethodRevisionsOf: methodReference + + methodReference ifNil: [ ^ Project uiManager inform: 'No method selected' ]. + + methodReference mcModel + ifNil: [ Project uiManager inform: 'Only Magma-backed HTTP repositories (or MCMagmaRepositorys) support browsing Monticello revisions.' ] + ifNotNil: [ (MCOperationsList operations: (Cursor wait showWhile: [ methodReference mcPatchOperations ])) browse ].!
Item was removed: - ----- Method: MCRepository class>>browseMethodRevisionsService (in category 'ui-support') ----- - browseMethodRevisionsService - ^ ServiceAction - id: #browseMcMethodRevisions - text: 'browse revisions' - button: 'mc' - description: 'Browse revisions of this method from the first-listed HTTP repository of this package.' - action: - [ : aBrowserRequestor | aBrowserRequestor browseMcMethodRevisions ] - condition: - [ : aBrowserRequestor | true ]!
Item was added: + (PackageInfo named: 'Monticello') postscript: '(ServiceRegistry current serviceWithId: #browserMethodMenu) services + removeAllSuchThat: [:service | #(browseMcMethodRevisions browseMcMethodOrigin) includes: service id]. + (ServiceRegistry current serviceWithId: #browserClassMenu) services + removeAllSuchThat: [:service | #(browseMcClassRevisions browseMcClassOrigin) includes: service id].'!
packages@lists.squeakfoundation.org