To me, the server should try and read in utf8, then fallback to old encoding like current trunk does.
Then, whether it should continue to write with old encoding or utf8 is a question of how we want to support serving older images.
Would it be possible to provide a hackish transition: create mcd with same encoding as mcz?


2013/7/30 Nicolas Cellier <nicolas.cellier.aka.nice@gmail.com>
A possible scenario:
For some reason (?) the snapshot.bin fails. In that case, the server used the sources in .st format.
But newly produced sources are in utf8 and the server is probably not utf8 aware...
In which case the server re-interprets bad characters for building the .mcd and put them in patch.bin stone
Makes sense?

Is it possible to backport the utf8 correction to the server ?
I mean, is it going to cause forward compatibility problems ?




2013/7/30 Bert Freudenberg <bert@freudenbergs.de>
If the MCZ works and the MCD does not, then whatever fix we make needs to be applied to our squeaksource server image, which generates the MCDs.

- Bert -

On 2013-07-30, at 14:59, Nicolas Cellier <nicolas.cellier.aka.nice@gmail.com> wrote:

I tried to debug late at night and it seems to come from the patch.bin member of a .mcd
I'm not an expert of MC and I do not really know when a .mcd is used vs a .mcz, nor how this binary member is created.
But presumably, there is an extra or missing utf8 conversion in some path...
I had to stop to get some sleep...
I suggest we keep trying a couple of days and solve the problem while under our hands.

Nicolas


2013/7/30 Frank Shearar <frank.shearar@gmail.com>
On 30 July 2013 02:17, Nicolas Cellier
<nicolas.cellier.aka.nice@gmail.com> wrote:
> Hmm it looks like some UTF8 mess
> I did only change Base64MimeConverter... Did I break it?

Yep, I'm afraid so. When it loads it throws a SyntaxError:

asCharacter
"Answer the receiver's first character, or '*' if none.
Idiosyncratic, provisional."

^ self size > 0 ifTrue: [self first] ifFalse:[$·Argument expected ->]

Is that supposed to be a middle dot just before "Argument" ? Note how
the original source doesn't show the A-with-caret.

frank

> 2013/7/30 <commits@source.squeak.org>
>
>> Nicolas Cellier uploaded a new version of Collections to project The
>> Trunk:
>> http://source.squeak.org/trunk/Collections-nice.527.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Collections-nice.527
>> Author: nice
>> Time: 30 July 2013, 2:13:07.506 am
>> UUID: 17e38fb5-76dd-499b-aa6d-bfe07045c28d
>> Ancestors: Collections-fbs.526
>>
>> Simplify Base64MimeConverter class initialization with Character>>to:
>>
>> =============== Diff against Collections-fbs.526 ===============