Hi Dave,
why not answer nil instead of 0? I think with your change, non-VMMaker Spur VMs will start to skip all ImageSegmentTests. Maybe senders of #vmVMMakerVersion should also check it for nil or send a new check #vmIsVMMaker before?
Best,
CHristoph
---
Sent from Squeak Inbox Talk
On 2024-01-05T02:08:55+00:00, commits@source.squeak.org wrote:
> David T. Lewis uploaded a new version of System to project The Trunk:
> http://source.squeak.org/trunk/System-dtl.1442.mcz
>
> ==================== Summary ====================
>
> Name: System-dtl.1442
> Author: dtl
> Time: 4 January 2024, 8:07:18.703979 pm
> UUID: 2ef3f6e2-a4fd-4d82-a79c-6ed6f4eb05b2
> Ancestors: System-ct.1441
>
> Do not fail loading package postscript when calling upscaleDisplayOnHighDPI: if VM is not OSVM
>
> =============== Diff against System-ct.1441 ===============
>
> Item was changed:
> ----- Method: SmalltalkImage>>vmVMMakerVersion (in category 'system attributes') -----
> vmVMMakerVersion
> + "Answer the version number of the VMMaker package from which the main VM was compiled,
> + or zero if the version number cannot be determined."
> - "Answer the version number of the VMMaker package from which the main VM was compiled."
> "Smalltalk vmVMMakerVersion"
>
> | vmMakerID |
> + vmMakerID := self vmVersion substrings
> + detect: [:token| token beginsWith: 'VMMaker']
> + ifNone: [ '0' ].
> - vmMakerID := self vmVersion substrings detect: [:token| token beginsWith: 'VMMaker'].
> ^Integer readFrom: (vmMakerID subStrings: '.') last!