This one was moved to Treated because I think only #sendersOfIt needed reverted.  MessageTrace already has protective overrides for #browseAllCallsOn: and browseAllImplementorsOf:.


On Sun, Jan 9, 2022 at 6:40 PM <commits@source.squeak.org> wrote:
Chris Muller uploaded a new version of Morphic to project The Inbox:
http://source.squeak.org/inbox/Morphic-cmm.1838.mcz

==================== Summary ====================

Name: Morphic-cmm.1838
Author: cmm
Time: 9 January 2022, 6:40:28.562851 pm
UUID: 44f58dc2-b94c-476a-aa46-17a4a564c65e
Ancestors: Morphic-mt.1837

Revert Morphic-mt.1652 because it corrupts the representation of a valid execution flow in MessageTrace and prevents spawning of independent traces.

=============== Diff against Morphic-mt.1837 ===============

Item was changed:
  ----- Method: TextEditor>>browseIt (in category 'menu messages') -----
  browseIt
        "Launch a browser for the current selection, if appropriate."

        Preferences alternativeBrowseIt ifTrue: [^ self browseClassFromIt].

        self lineSelectAndEmptyCheck: [^ morph flash].

        "First, try to show all accesses to instance or class variables."
        self selectedInstanceVariable ifNotNil:
                [:nameToClass | self systemNavigation
                        browseAllAccessesTo: nameToClass key
                        from: nameToClass value].
        self selectedClassVariable ifNotNil:
+               [:binding | self systemNavigation browseAllCallsOn: binding].
-               [:binding | self model browseAllCallsOn: binding].

        "Then, either browse the class (from a binding) or all implementors of a selector."
        self selectedBinding ifNotNil:
                [:binding | ^ self systemNavigation browseClass: binding].
        self selectedSelector ifNotNil:
+               [:selector | ^ self systemNavigation browseAllImplementorsOf: selector].
-               [:selector | ^ self model browseAllImplementorsOf: selector].

        morph flash!

Item was changed:
  ----- Method: TextEditor>>sendersOfIt (in category 'menu messages') -----
  sendersOfIt
        "Open a senders browser on the selected selector"

        self lineSelectAndEmptyCheck: [^ self].
+       self selectedSelector ifNotNil:
+               [:aSelector| ^self systemNavigation browseAllCallsOn: aSelector].
+       self selectedLiteral ifNotNil:
+               [:aLiteral| ^self systemNavigation browseAllCallsOn: aLiteral].
+       morph flash!
-       self selectedSelector ifNotNil: [:aSelector |
-               ^ self model browseAllCallsOn: aSelector].
-       self selectedLiteral ifNotNil: [:aLiteral |
-               ^ self model browseAllCallsOn: aLiteral].
-       morph flash.!