Hey Karl, would you like to repost your changes to the Inbox?  Some of them still had too little consensus to go into trunk, but the other ones I couldn't diff, sorry.  Let's route them back through Inbox and discuss and watch it closely see if that ancestry issue or empty package pops up again..



On Thu, Jul 31, 2014 at 1:54 PM, <commits@source.squeak.org> wrote:
Chris Muller uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-cmm.730.mcz

==================== Summary ====================

Name: Morphic-cmm.730
Author: cmm
Time: 31 July 2014, 1:54:13.695 pm
UUID: 51d16b4a-f89e-4a51-9a6a-5647a4cde024
Ancestors: Morphic-kfr.729

There are some issues with recent Morphic packages:

- 730 is missing its log message and from trunk.
- 731 is entirely missing from trunk repository and inbox.  It was moved to treated after flash discussion it should not be in trunk ancestry.
- 732 is an empty mcz.
- 733 broke color rendering in multi-select lists.

I've loaded back to Morphic-kfr.729 and merged the changes from 736-737, but not 730-733 because of the problems.

=============== Diff against Morphic-kfr.729 ===============

Item was changed:
  ----- Method: MorphicProject class>>compileNewDefaultBackgroundFrom: (in category 'utilities') -----
  compileNewDefaultBackgroundFrom: aForm
        "Compile a new #defaultBackgroundForm method in this class-side which uses aForm as the background."
+       | formStream base64 |
+       formStream := ByteArray new writeStream.
-       | formStream base64Stream |
-       formStream := RWBinaryOrTextStream on: ByteArray new.
        PNGReadWriter
                putForm: aForm
                onStream: formStream.
+       base64 := formStream base64Encoded.
-       base64Stream := Base64MimeConverter mimeEncode: formStream.
        self class
                compile:
                        (String streamContents:
                                [ : stream | stream
                                         nextPutAll: 'defaultBackgroundForm
        ^ Form fromBinaryStream: ' ;
                                         nextPut: $' ;
+                                        nextPutAll: base64 ;
-                                        nextPutAll: base64Stream contents ;
                                         nextPut: $' ;
                                        nextPutAll: ' base64Decoded asByteArray readStream' ])
                classified: 'class initialization'!

Item was changed:
  ----- Method: TextEditor>>selectionAsStream (in category 'accessing-selection') -----
  selectionAsStream
        "Answer a ReadStream on the text in the paragraph that is currently  selected."

+       ^ReadStream
-       ^ReadWriteStream
                on: paragraph string
                from: self startIndex
                to: self stopIndex - 1!