From jens at impara.de Mon Nov 27 19:20:05 2006 From: jens at impara.de (Jens Lincke) Date: Mon Nov 27 20:35:41 2006 Subject: [Balloon] [Bug+Fix] in BalloonCanvas>>drawString: ... Message-ID: <456B3A65.30802@impara.de> Hi, I found a bug in the BalloonCanvas when drawing a String with an offset transformation the method drawString: s from: firstIndex to: lastIndex in: boundsRect font: fontOrNil color: c was marked TODO and did only draw when it can fall back to FormCanvas But the offset in the Transformation was ignored, so I changed it into: drawString: s from: firstIndex to: lastIndex in: boundsRect font: fontOrNil color: c (self ifNoTransformWithIn: boundsRect) ifTrue:[ | offset | offset := transform a13 @ transform a23. ^super drawString: s from: firstIndex to: lastIndex in: boundsRect + offset font: fontOrNil color: c] and uploaded a iSqueak3.8 package Balloon-jl.4 to the source.impara.de/Stuff - Jens Lincke - From andreas.raab at gmx.de Mon Nov 27 21:11:39 2006 From: andreas.raab at gmx.de (Andreas Raab) Date: Mon Nov 27 21:13:56 2006 Subject: [Balloon] [Bug+Fix] in BalloonCanvas>>drawString: ... In-Reply-To: <456B3A65.30802@impara.de> References: <456B3A65.30802@impara.de> Message-ID: <456B548B.1090603@gmx.de> Can you email me the patch? Thanks, - Andreas Jens Lincke wrote: > Hi, > > I found a bug in the BalloonCanvas when drawing a String with an offset > transformation > > the method > drawString: s from: firstIndex to: lastIndex in: boundsRect font: > fontOrNil color: c > was marked TODO and did only draw when it can fall back to FormCanvas > > But the offset in the Transformation was ignored, so I changed it into: > > drawString: s from: firstIndex to: lastIndex in: boundsRect font: > fontOrNil color: c > (self ifNoTransformWithIn: boundsRect) > ifTrue:[ | offset | > offset := transform a13 @ transform a23. > > ^super drawString: s from: firstIndex to: lastIndex in: boundsRect > + offset font: fontOrNil color: c] > > > and uploaded a iSqueak3.8 package Balloon-jl.4 to the > source.impara.de/Stuff > > - Jens Lincke - > > _______________________________________________ > Balloon mailing list > Balloon@lists.squeakfoundation.org > http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/balloon > From jens at impara.de Mon Nov 27 21:49:21 2006 From: jens at impara.de (Jens Lincke) Date: Mon Nov 27 21:52:33 2006 Subject: [Balloon] [Bug+Fix] in BalloonCanvas>>drawString: ... In-Reply-To: <456B548B.1090603@gmx.de> References: <456B3A65.30802@impara.de> <456B548B.1090603@gmx.de> Message-ID: <456B5D61.909@impara.de> here is the changeset Andreas Raab schrieb: > Can you email me the patch? > > Thanks, > - Andreas > > Jens Lincke wrote: >> Hi, >> >> I found a bug in the BalloonCanvas when drawing a String with an >> offset transformation >> >> the method >> drawString: s from: firstIndex to: lastIndex in: boundsRect font: >> fontOrNil color: c >> was marked TODO and did only draw when it can fall back to FormCanvas >> >> But the offset in the Transformation was ignored, so I changed it into: >> >> drawString: s from: firstIndex to: lastIndex in: boundsRect font: >> fontOrNil color: c >> (self ifNoTransformWithIn: boundsRect) >> ifTrue:[ | offset | >> offset := transform a13 @ transform a23. >> >> ^super drawString: s from: firstIndex to: lastIndex in: >> boundsRect + offset font: fontOrNil color: c] >> >> >> and uploaded a iSqueak3.8 package Balloon-jl.4 to the >> source.impara.de/Stuff >> >> - Jens Lincke - >> >> _______________________________________________ >> Balloon mailing list >> Balloon@lists.squeakfoundation.org >> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/balloon >> -------------- next part -------------- A non-text attachment was scrubbed... Name: Balloon-Fix-drawString-offset.1.cs.gz Type: application/x-gzip Size: 309 bytes Desc: not available Url : http://lists.squeakfoundation.org/pipermail/balloon/attachments/20061127/b84b6e04/Balloon-Fix-drawString-offset.1.cs.bin From jens at impara.de Mon Nov 27 22:33:37 2006 From: jens at impara.de (Jens Lincke) Date: Mon Nov 27 22:36:37 2006 Subject: [Balloon] [Bug+Fix] in BalloonCanvas>>drawString: ... In-Reply-To: <456B5D61.909@impara.de> References: <456B3A65.30802@impara.de> <456B548B.1090603@gmx.de> <456B5D61.909@impara.de> Message-ID: <456B67C1.3030603@impara.de> Hi, I added drawing of a red rectangle, to show that there is something that can not be drawn in the second change set. It would be better to actually fix this method, but I think, for that we now have Rome... Jens Lincke schrieb: > here is the changeset > > Andreas Raab schrieb: >> Can you email me the patch? >> >> Thanks, >> - Andreas >> >> Jens Lincke wrote: >>> Hi, >>> >>> I found a bug in the BalloonCanvas when drawing a String with an >>> offset transformation >>> >>> the method >>> drawString: s from: firstIndex to: lastIndex in: boundsRect font: >>> fontOrNil color: c >>> was marked TODO and did only draw when it can fall back to FormCanvas >>> >>> But the offset in the Transformation was ignored, so I changed it into: >>> >>> drawString: s from: firstIndex to: lastIndex in: boundsRect font: >>> fontOrNil color: c >>> (self ifNoTransformWithIn: boundsRect) >>> ifTrue:[ | offset | >>> offset := transform a13 @ transform a23. >>> >>> ^super drawString: s from: firstIndex to: lastIndex in: >>> boundsRect + offset font: fontOrNil color: c] >>> >>> >>> and uploaded a iSqueak3.8 package Balloon-jl.4 to the >>> source.impara.de/Stuff >>> >>> - Jens Lincke - >>> >>> _______________________________________________ >>> Balloon mailing list >>> Balloon@lists.squeakfoundation.org >>> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/balloon >>> > > ------------------------------------------------------------------------ > > _______________________________________________ > Balloon mailing list > Balloon@lists.squeakfoundation.org > http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/balloon > -------------- next part -------------- A non-text attachment was scrubbed... Name: Balloon-Fix-drawString-offset.2.cs.gz Type: application/x-gzip Size: 415 bytes Desc: not available Url : http://lists.squeakfoundation.org/pipermail/balloon/attachments/20061127/836190bd/Balloon-Fix-drawString-offset.2.cs.bin