<br><br><div class="gmail_quote">On Feb 20, 2008 8:09 AM, Randal L. Schwartz <<a href="mailto:merlyn@stonehenge.com">merlyn@stonehenge.com</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">>>>>> "goran" == goran <<a href="mailto:goran@krampe.se">goran@krampe.se</a>> writes:<br>>> I'd just do:<br>>><br>>> removeAll<br>>> self notEmpty ifTrue: [self become: self species new].<br>
>><br>>> and let subclasses make it more efficient using implementation knowledge.<br><br></div>goran> I would never use become: in "regular code" like this. :)<br><br>First, how "regular" is it if the method hasn't been missed by anyone<br>
in 27 years. :)<br><br>Second, what are you objecting to? #become: is clearly a part of the image,<br>and works fine. This code also cleans out a grown collection to be the<br>smallest it possiby can become, where delete-one-at-a-time solutions don't.<br>
</blockquote></div><br><br>#become: and its friends are voodoo. Don't use them in your code unless you have absolutely no other option.<br><br>It doesn't work fine. It breaks code that relies on hashes; specifically, a Dictionary elsewhere in your image can start acting screwy if you do a #become: variant that doesn't preserve an object's hash. See #becomeForward>>copyHash:. You would then also be relying on a Squeakish behaviour and your code would become less portable across Smalltalk dialects.<br>
<br>They are also a fantastic way to introduce bugs of various sorts, and can even cause an image to crash (as in, stack trace and exit to the OS). Say, for example, that one of the arguments you pass is accidently nil, true or false? Your image would continue working... for a while.<br>
<br>#become: and variants are also very slow and causes the equivalent of a full GC on every invocation.<br><br>Gulik.<br><br clear="all"><br>-- <br><a href="http://people.squeakfoundation.org/person/mikevdg">http://people.squeakfoundation.org/person/mikevdg</a><br>
<a href="http://gulik.pbwiki.com/">http://gulik.pbwiki.com/</a>