[etoys-dev] Fwd: Etoys-To-Go-4.0.2253-beta slow when a viewer is open

[Timothy Falconer]

Hi all,

Make sure to create issues in the tracker for any bugs & fixes.   This  
helps us make release notes, etc.  (Not sure if this was done, just  
making the larger point anyway.)

Tim


On Aug 25, 2009, at 12:44 AM, Scott Wallace wrote:

> Thank you, Ricardo, for tracking down and fixing this serious  
> performance bug!
>
> The fix has been promptly pushed to the etoys4.0 update stream, as  
> update 2255viewerSpanFix-rm.
>
> -- Scott
>
>
> On Aug 24, 2009, at 8:45 PM, Ricardo Moran wrote:
>
>> Actually, commenting one line of the method is a nicer fix. I think  
>> it keeps the expected behavior but it works faster.
>>
>>
>> spanWorld
>> 	"Make the receiver's height and width be harmonious with those of  
>> the container."
>>
>> 	| container ht nav |
>> 	container _ self pasteUpMorph ifNil: [self currentWorld].
>> 	ht := (nav := ActiveWorld findA: SugarNavTab)
>> 		ifNotNil:
>> 			[nav height]
>> 		ifNil:
>> 			[0].
>> 	"referent height:  (container height - ht)."
>> 	referent width: (referent width min: container width - self width).
>> 	referent top: container top + ht
>>
>>
>>
>> I don't know why that line is so slow, though.
>> Cheers. Richo
>>
>> On Mon, Aug 24, 2009 at 11:29 PM, Ricardo Moran <richi.moran at gmail.com 
>> > wrote:
>> I found that ViewerFlapTab #spanWorld is the responsible for the  
>> slow down. It is on the change set 2234viewerBeneath-sw. If I  
>> remove this method it starts working correctly.
>>
>>
>>
>> On Mon, Aug 24, 2009 at 5:44 PM, Bert Freudenberg <bert at freudenbergs.de 
>> > wrote:
>>
>> On 24.08.2009, at 21:32, Karl Ramberg wrote:
>>
>>> On 2009-08-24 18:24, Ricardo Moran wrote:
>>>>
>>>> How strange, I tried it some minutes ago in another machine with  
>>>> Ubuntu 9.04 and it behaves exactly the same. And it is very  
>>>> noticeable if you make a new project, draw a simple sketch, make  
>>>> a script with forward: 5 turn: 5, change the tickRate to 100 and  
>>>> run. Then opening a viewer should slow down the script, and  
>>>> keeping the mouse down on a button should make it go faster.
>>> I see this on Windows as well, just clicking anywhere when a  
>>> Viewer is open will make the morph move faster.
>>
>> In the non-dev image, clicking in an empty part of the world makes  
>> no difference.
>>
>> But e.g. bringing up a menu does. Even by keyboard (Cmd-Shift-W).
>>
>> - Bert -
>>
>>
>>
>> _______________________________________________
>> etoys-dev mailing list
>> etoys-dev at squeakland.org
>> http://lists.squeakland.org/mailman/listinfo/etoys-dev
>>
>>
>>
>> _______________________________________________
>> etoys-dev mailing list
>> etoys-dev at squeakland.org
>> http://lists.squeakland.org/mailman/listinfo/etoys-dev
>
> _______________________________________________
> etoys-dev mailing list
> etoys-dev at squeakland.org
> http://lists.squeakland.org/mailman/listinfo/etoys-dev