[etoys-dev] Re: Method Properties issue (was: Bug when creating new script in latest etoys-dev image)

[karl ramberg]

Great work Bert and Eliot

Karl



On Mon, May 3, 2010 at 9:49 AM, Bert Freudenberg <bert at freudenbergs.de>wrote:

>  Thanks Eliot. Your blind fix works :)
>
> Here is how to make an Etoys script if you want to test yourself:
> * right-click (or cmd/alt click) on any object (e.g., a sketch, window,
> button, about any Morph). Its halo pops up.
> * click the cyan "viewer" halo handle. You get a viewer for the object
> * drag out a command tile (those with the yellow exclamation mark button to
> the left). That creates a script.
>
> Before, this would give a walkback. With your fix, it works as expected.
>
> I just committed the fix. Ah, I see the commit message came in already.
> Cool.
>
> Btw, I *love* how straight-forward it is to get such simple fixes into
> Etoys now. Much less cumbersome than pushing a changeset to the update
> stream. Everyone should try it. If you commit to the etoysinbox, that does
> no harm at all :)
>
>  - Bert -
>
> On 03.05.2010, at 03:32, Eliot Miranda wrote:
>
> Hi Bert,
>
>     there are 2.5 ways to fix this.  1. change senders
> of selector:arguments:precedence:temporaries:block:encoder:primitive: to
> send selector:arguments:precedence:temporaries:block:encoder:primitive:properties:
> with a new AdditionalMethodState (silly).
> 2a add the initialization of MethodNode's properties
> to selector:arguments:precedence:temporaries:block:encoder:primitive: (find
> attached)
> 2b
> implement selector:arguments:precedence:temporaries:block:encoder:primitive:
> in terms
> of selector:arguments:precedence:temporaries:block:encoder:primitive:properties:
> passing a new AdditionalMethodState.
>
> I'll leave to to you to implement 2b if you prefer it.
>
> Beware, this is a completely untested fix because I haven't yet reproduced
> the bug, but it has a good chance of being correct.
>
> best
> Eliot
>
> On Sun, May 2, 2010 at 6:13 PM, Eliot Miranda <eliot.miranda at gmail.com>wrote:
>
>> Hi Bert,
>>
>>     I've downloaded the dev package but so far haven't figured out how to
>> reproduce.  Let me know.
>>
>> best
>> Eliot
>>
>> On Sat, May 1, 2010 at 11:15 AM, Bert Freudenberg <bert at freudenbergs.de>wrote:
>>
>>>  On 01.05.2010, at 18:17, Ricardo Moran wrote:
>>>
>>> Hi guys, I just wanted to tell you the new dev image throws a DNU when I
>>> try to create a script by throwing a tile in the world.
>>>
>>>
>>> Something to do with nil method properties. Eliot, can you take a look?
>>> See attached debug log, and let me know if you need help reproducing.
>>>
>>> Dev package is at http://etoys.squeak.org/download/
>>>
>>>  - Bert -
>>>
>>>
>>>
>>>
>>
> <MethodNode-selectorargumentsprecedencetemporariesblockencoderprimitive.st>
>
>
>
>
> _______________________________________________
> etoys-dev mailing list
> etoys-dev at squeakland.org
> http://lists.squeakland.org/mailman/listinfo/etoys-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakland.org/pipermail/etoys-dev/attachments/20100503/a5b57505/attachment.html