[etoys-dev] [etoys-notify] [JIRA] Updated: (SQ-554) Etoys does not work with Chinese input

K. K. Subramaniam kksubbu.ml at gmail.com
Fri Oct 1 08:09:48 EDT 2010


On Friday 01 Oct 2010 3:26:39 pm Bert Freudenberg wrote:
> asciiValue is misnamed, it is actually the raw value of the character
> (including the language tag), not limited to ASCII.
That may be the intention but there are many senders of asciiValue that assume 
ASCII encoding.

A better idea would be to introduce two methods 'value' to return raw value 
(i.e. lang and code) and asAscii to return value converted to ASCII. Retain 
asciiValue only for the case where value < 256 and raise an exception if this 
is violated. This should help catch all assumptions about char codes in the 
image (including in comments. see KeyboardEvent).

Would you like a changeset for this?

Subbu


More information about the etoys-dev mailing list