[etoys-dev] Etoys: MorphicExtras-kfr.41.mcz

[karl ramberg]

On Fri, Oct 14, 2011 at 2:53 PM, Bert Freudenberg <bert at freudenbergs.de> wrote:
> On 13.10.2011, at 20:47, commits at source.squeak.org wrote:
>
>> Karl Ramberg uploaded a new version of MorphicExtras to project Etoys:
>> http://source.squeak.org/etoys/MorphicExtras-kfr.41.mcz
>>
>> ==================== Summary ====================
>>
>> Name: MorphicExtras-kfr.41
>> Author: kfr
>> Time: 13 October 2011, 10:47:37 pm
>> UUID: 999c47e0-2257-0249-8f43-87899271a4d4
>> Ancestors: MorphicExtras-kfr.40
>>
>> Some more fixing.
>> I'll say this is pretty much good to gow now.
>> Famous last words...
>
>
> I just committed the Mac CameraPlugin, and tried your code. Worked on first try, great!

Great :-)
>
> Things I noticed:
>
> The camera stays on when I leave the project. It should turn off - we're not spying on users ;)
>
> After loading a project with a "running" camera, it does not restart automatically.
>
> For both of these I think we should use the intoWorld/outOfWorld mechanism. See VideoMorph.

I'll fix this.
>
> When I duplicate the camera I get two cameras. When I delete the one camera, the other one stops, too. However, the tile still says it's "on".

I'm not sure how to fix this yet.
>
> We should hide the old camera from the object catalog. Maybe just remove it from the "multimedia" page and still leave it in the alphabetical list. And rename the new one to Camera (we don't really have to rename the class, but it would be consistent to do so).

Yes.
>
> Got errors in Player when I tried to rotate the camera. All the getters should use the "getValueFromCostume:" idiom. Similarly, the setters should use "setCostumeSlot:toValue:".

I noticed to that some extension method did not use the costume idiom.
I'll fix that.
>
> The viewer category should simply be named "camera", not "camera settings".

Yes.
>
> Not sure about the "last frame" tile. Do we need that? If so we should find a nicer name. In any case the help balloon should not mention "morph". In > Etoys we generally do not distinguish between the player and its costume. (idea: maybe a copy of the camera should just return a sketch)

The lastFrame returns a SketchMorph.
It's easier to get a player than to get just the graphics. Then you
can just add it to a holder or something like that without converting
etc.
I'll look into it a bit more.

>
> And we should make a test release for others to try this, soonish.
>

Yes, this need testing.

Thanks for feedback.

Karl