[etoys-dev] Sound volume control in navigator bar

[Bert Freudenberg]

On 23.02.2012, at 13:36, Bert Freudenberg wrote:

> On 22.02.2012, at 21:49, karl ramberg wrote:
> 
>> I added a class variable to SoundPlayer called Volume and just changed
>> the SoundPlayer accessors.
>> 
>> This works really well on Windows XP.
>> Could someone try this on other platforms ?
>> 
>> http://source.squeak.org/etoysinbox/Sound-kfr.22.mcz
>> http://source.squeak.org/etoysinbox/Sugar-kfr.19.mcz
>> 
>> Karl
> 
> 
> Works on Mac, and really should work everywhere since it's done all in-image.
> 
> For performance, you should make sure fullVol is an integer.
> 
> Also, the volume slider in the tool bar feels odd. Maybe it should appear in a fixed position below the button and be larger? 
> 
> - Bert -


And there is no need to take the average of the volume - why not use left and right separately, as intended?

- Bert -