[etoys-dev] Etoys: Etoys-kfr.116.mcz

commits at source.squeak.org commits at source.squeak.org
Tue Mar 6 18:50:09 EST 2012


Karl Ramberg uploaded a new version of Etoys to project Etoys:
http://source.squeak.org/etoys/Etoys-kfr.116.mcz

==================== Summary ====================

Name: Etoys-kfr.116
Author: kfr
Time: 7 March 2012, 12:49:16 am
UUID: 89a815ba-d103-234d-aba0-3407f2a3c738
Ancestors: Etoys-kfr.115

Fix SimpleWatchers for variable types sound leaves a WatcherWrapper on handle delete
http://tracker.squeakland.org/browse/SQ-1018

=============== Diff against Etoys-kfr.115 ===============

Item was changed:
+ SymbolListTile subclass: #SoundReadoutTile
- StringReadoutTile subclass: #SoundReadoutTile
  	instanceVariableNames: ''
  	classVariableNames: ''
  	poolDictionaries: ''
  	category: 'Etoys-Scripting Tiles'!
  
  !SoundReadoutTile commentStamp: 'sw 11/24/2003 15:25' prior: 0!
  A tile comprising a readout for a sound-valued instance variable in a Viewer.  It sports up/down  arrows, and a click on the sound name results in a pop-up menu, offering the user the opportunity to choose a new one.!

Item was removed:
- ----- Method: SoundReadoutTile>>arrowAction: (in category 'arrows') -----
- arrowAction: delta
- 	"Do what is appropriate when an arrow on the tile is pressed; delta will be +1 or -1"
- 
- 	| soundChoices index |
- 	soundChoices _ self soundChoices.
- 	index _ soundChoices indexOf: literal.
- 	self literal: (soundChoices atWrap: (index + delta)).
- 	self playSoundNamed: literal!

Item was added:
+ ----- Method: SoundReadoutTile>>choices (in category 'arrows') -----
+ choices
+  ^self soundChoices.
+ !

Item was removed:
- ----- Method: SoundReadoutTile>>handlerForMouseDown: (in category 'arrows') -----
- handlerForMouseDown: anEvent
- 	"Return the (prospective) handler for a mouse down event. The handler is temporarily installed and can be used for morphs further down the hierarchy to negotiate whether the inner or the outer morph should finally handle the event"
- 
- 	^ ((self findA: UpdatingStringMorph) bounds containsPoint: anEvent cursorPoint)
- 		ifTrue:
- 			[self]
- 		ifFalse:
- 			[super handlerForMouseDown: anEvent]!

Item was removed:
- ----- Method: SoundReadoutTile>>mouseDown: (in category 'arrows') -----
- mouseDown: evt
- 	"Handle a mouse down event"
- 
- 	| aPoint index isUp soundChoices adjustment |
- 	upArrow ifNotNil: [((isUp _ upArrow containsPoint: (aPoint _ evt cursorPoint)) or:  [downArrow containsPoint: aPoint])
- 		ifTrue:
- 			[soundChoices _ self soundChoices.
- 			index _ soundChoices indexOf: literal ifAbsent: [1].
- 			index > 0 ifTrue:
- 				[adjustment _ isUp ifTrue: [1] ifFalse: [-1].
- 				self literal: (soundChoices atWrap: (index + adjustment))].
- 			self playSoundNamed: literal.
- 			^ self]].
- 	self soundNameFromUser ifNotNilDo:
- 		[:aSoundName |
- 			self literal: aSoundName.
- 			self playSoundNamed: literal]!

Item was removed:
- ----- Method: SoundReadoutTile>>setLiteral: (in category 'arrows') -----
- setLiteral: aLiteral
- 	super  setLiteral: aLiteral.
- 	(self findA: UpdatingStringMorph) useSymbolFormat; lock!

Item was removed:
- ----- Method: SoundReadoutTile>>setLiteralTo:width: (in category 'literal') -----
- setLiteralTo: anObject width: w
- 	"Set the literal and width of the tile as indicated"
- 
- 	| soundChoices index |
- 	soundChoices _ self soundChoices.
- 	index _ soundChoices indexOf: anObject.
- 	self setLiteral: (soundChoices atWrap: index)!

Item was removed:
- ----- Method: SoundReadoutTile>>soundNameFromUser (in category 'arrows') -----
- soundNameFromUser
- 	"Obtain a sound from the user.  Exclude the items designated as being discouraged, except that if the current selection is one of those, show it anyway"
- 
- 	| choices |
- 	choices _ self soundChoices.
- 	^ (SelectionMenu labels: (choices collect: [:t | t translated]) selections: self soundChoices) startUpWithCaption: 'Sounds' translated!

Item was removed:
- ----- Method: SoundReadoutTile>>updateLiteralLabel (in category 'private') -----
- updateLiteralLabel
- 	"Update the wording emblazoned on the tile, if needed"
- 
- 	super updateLiteralLabel.
- 	(self findA: UpdatingStringMorph) useSymbolFormat; lock!



More information about the etoys-dev mailing list