[etoys-dev] Category not showing up in viewer

[Scott Wallace]

Ah, I can see that *setting* the hue, saturation, or brightness of a bitmap is well-defined and can be useful for color effects.

But what would be the definitions of the *getters* for these three quantities?  How could one expect to *get* meaningful values for hue, saturation, and brightness from a bitmap, which can have a different value for each of these quantities at each pixel?

So… a suggestion:  for bitmaps, how about offering filtering *commands* rather than trying to use variables?  For example "applySaturation: foo"?  This avoids the issue of ill-defined getters...

  -- Scott



On Mar 11, 2012, at 12:56 PM, karl ramberg wrote:

> But these are really for doing color filters for sketches and  images so we should make them available.
> It's possible to do all sorts of color changing etc. and it's pretty fast because they are run with the scratch plugin.
> 
> I'm not sure if we should use the standard color category or another.
> 
> Karl
> 
> On Sat, Mar 10, 2012 at 4:42 AM, Scott Wallace <scott.wallace at squeakland.org> wrote:
> On Mar 9, 2012, at 5:10 PM, karl ramberg wrote:
> 
>> 
>> 
>> On Sat, Mar 10, 2012 at 12:48 AM, Scott Wallace <scott.wallace at squeakland.org> wrote:
>> > Hi
>> > I have made the category in morph but it does not show up correctly.
>> > The viewer category is showing but not the tiles.
>> > I don't understand why I dont see the tiles...
>> >
>> > Karl
>> >
>> >
>> > additionsToViewerCategoryColorFilters
>> >       "Answer viewer additions for the 'color filter' category"
>> >
>> >       ^#(colorFilters
>> >               (
>> >                       (slot hue       'Hue value of my color from -180 to 180' Number  readWrite Player getHue Player setHue:)
>> >                       (slot saturation        'Saturation value of my color from 0 to 100' Number      readWrite Player getSaturation Player setSaturation:)
>> >                       (slot brightness        'Brightness value of my color from 0 to 100' Number readWrite Player getBrightness Player setBrightness:)
>> 
>> Seemingly has to do with camel-casing.
>> 
>> This works:
>> 
>> additionsToViewerCategoryColorFilters
>>        "Answer viewer additions for the 'color filter' category"
>> 
>>        ^#(#'color filters'
>>                (
>>                        (slot hue       'Hue value of my color from -180 to 180' Number  readWrite Player getHue Player setHue:)
>>                        (slot saturation        'Saturation value of my color from 0 to 100' Number      readWrite Player getSaturation Player setSaturation:)
>>                        (slot brightness        'Brightness value of my color from 0 to 100' Number readWrite Player getBrightness Player setBrightness:)
>>                )
>>        )
>> 
>> 
>> Aha, that works for most morphs, but it still don't show up for SketchMorph.
>> 
>> Karl
> 
> Right -- since SketchMorphs have no single "color", many of the color-related variables are meaningless for them, and hence are excluded from their viewers.  The three variables in your example are among those excluded; if you look in a Sketch's "fill & border" category you'll notice that they're absent there as well.
> 
>   -- Scott
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakland.org/pipermail/etoys-dev/attachments/20120311/fb3aa692/attachment-0001.html>