[etoys-notify] [JIRA] Updated: (SQ-424) Can't save because of naughty blocks

[tracker at squeakland.org]

     [ http://tracker.immuexa.com/browse/SQ-424?page=all ]

Scott Wallace updated SQ-424:
-----------------------------

    Attachment: reduceBlockUsage-sw.4.cs

Fileout "reduceBlockUsage-sw.4.cs" undertakes to convert all uses of the actionBlock in EToyProjectDetailsMorph and friends over to storing message-sends rather than blocks in the #actionBlock inst var.  Because of the annoyingly large number of methods in the change-set, this really needs some careful scrutiny by at least one other person before we push it to the update stream.  Because it was not simply blocks but blocks passed as arguments to other blocks, the changes were not as simple nor as brief as I would have liked.  If anyone vetting this change set can make any simplifications, please do!

> Can't save because of naughty blocks
> ------------------------------------
>
>          Key: SQ-424
>          URL: http://tracker.immuexa.com/browse/SQ-424
>      Project: squeakland
>         Type: Bug
>   Components: etoys
>     Reporter: Bert Freudenberg
>     Priority: Blocker
>      Fix For: etoys 4.0 - summer 2009
>  Attachments: SqueakDebug.log, reduceBlockUsage-sw.4.cs
>
>
> I just ran into the same issue Tim did when making his screencast with Scott. I did nothing unusual but loading an old project and trying to save it to squeakland, but it complained about bad blocks. The "naughtyBlocks" instance variable contained this:
>  #(MouseButtonEvent>>sentTo:
>  EToyProjectDetailsMorph>>doOK
>  SimpleButtonMorph>>mouseUp:
>  PasteUpMorph>>doOneCycle
>  Project>>storeOnServerShowProgressOn:forgetURL:
>  HandMorph>>processEvents
>  SimpleButtonMorph>>doButtonAction
>  Project>>validateProjectNameIfOK:
>  HandMorph>>handleEvent:
>  [] in Project>>storeOnServerShowProgressOn:forgetURL: {[self isCurrentProject   ifTrue: [forget     ifTrue: [self forgetExistingURL...]}
>  HandMorph>>sendEvent:focus:clear:
>  WorldState>>handsDo:)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://tracker.immuexa.com/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira