[etoys-notify] [JIRA] Commented: (SQ-1052) Incorrect watcher labels in some cases

[Karl Ramberg (JIRA)]

    [ http://tracker.squeakland.org/browse/SQ-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=40463#action_40463 ] 

Karl Ramberg commented on SQ-1052:
----------------------------------

That must be this fix. There was a walkback with 'aMethodInterface wording'


Name: Etoys-kfr.79
Author: kfr
Time: 16 July 2011, 9:56:14 pm
UUID: 43237a5e-06fc-fc42-9a1f-5c7e34151f29
Ancestors: Etoys-kfr.78

Small fixup in WatcherWrapper so it build valid watchers

=============== Diff against Etoys-kfr.78 ===============

Item was changed:
 ----- Method: WatcherWrapper>>buildForPlayer:getter: (in category 'initialization') -----
 buildForPlayer: aPlayer getter: aGetter
       "Build up basic structure"
+       | aColor aMethodInterface interface |
+       interface := ScriptingSystem currentVocabulary methodInterfaceAt: aGetter ifAbsent: [ nil ].
+       interface ifNotNil:[aMethodInterface := interface wording]
+                                               ifNil:[ aMethodInterface :=Utilities inherentSelectorForGetter: aGetter].
-       | aColor aMethodInterface |
-       aMethodInterface := self currentVocabulary methodInterfaceAt: aGetter  ifAbsent: [nil].
-       aMethodInterface ifNil:[ aMethodInterface :=Utilities inherentSelectorForGetter: aGetter]
-                                               ifNotNil:[ aMethodInterface := aMethodInterface wording].
       self
               player: aPlayer
               variableName: aMethodInterface.
       aColor := self detailedWatcherColor.
       self listDirection: #leftToRight;
                hResizing: #shrinkWrap;
                vResizing: #shrinkWrap;
                color: aColor;
                layoutInset: -1;
                borderWidth: 1;
                borderColor: aColor darker;
                listCentering: #center.
       self
               addMorphBack: (self buildReadout: aGetter)!


> Incorrect watcher labels in some cases
> --------------------------------------
>
>                 Key: SQ-1052
>                 URL: http://tracker.squeakland.org/browse/SQ-1052
>             Project: squeakland
>          Issue Type: Bug
>          Components: etoys
>            Reporter: Scott Wallace
>            Priority: Blocker
>             Fix For: etoys 5.0
>
>         Attachments: wrongWatcherLabel-sw.1.cs.gz
>
>
> The labels on certain "detailed watchers" -- those for which the variable-name and the "getter selector" do not bear the default relationship -- are wrong.  The attached fileout hopefully addresses the issue; here is the preamble, with some commentary:
> Change Set:		wrongWatcherLabel-sw
> Date:			18 March 2012
> Author:			Scott Wallace
> Fix for a bug seemngly introduced in july 2011 that resulted in some detailed watchers having the wrong labels.  For example, a detailed watcher for a playfield's 'graphic' or a Sector's 'angle' would have 'pasteUpGraphic' and 'sectorAngle', respectively, as their labels. 
> I'm uncertain of the history of this change, but it appears that the version in etoys 4.1 stamped kfr 5/22/2011 did not show this bug, but the version stamped  kfr 7/16/2011 does.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tracker.squeakland.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira