<div>Hi Chris,<br></div><div><br></div><div>I've tested the change you provided; reran the previous scenario which generated the large file. And the result is that the bug seems fixed indeed. The applied.images file stays a few megabytes, but does not become 2 gig.</div>
<div><br></div><div>Thanks for the bugfix!</div><div><br></div><div>Kind Regards,</div><div><br></div><div>Bart</div><div><br>-- <br>imagination is more important than knowledge - Albert Einstein<br>Logic will get you from A to B. Imagination will take you everywhere - Albert Einstein<br>
Learn from yesterday, live for today, hope for tomorrow. The important thing is not to stop questioning. - Albert Einstein<br>The true sign of intelligence is not knowledge but imagination. - Albert Einstein<br>However beautiful the strategy, you should occasionally look at the results. - Sir Winston Churchill<br>
It's not enough that we do our best; sometimes we have to do what's required. - Sir Winston Churchill</div><br><div class="gmail_quote">On Sat, Dec 26, 2009 at 10:37 PM, Chris Muller <span dir="ltr"><<a href="mailto:asqueaker@gmail.com">asqueaker@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Thanks for the report Bart. On July 8th, it appears I changed the<br>
method MaRecoveryRecord>>#writeTo: to add a call to setToEnd, and this<br>
would appear to be the cause of this file-growth problem.<br>
<br>
The reason for the change was that a warm-backup could request an<br>
earlier commit-log record in the current active commits.log file,<br>
which would cause a reposition of the file-pointer. I therefore made<br>
it the responsibility of the process doing the writing to position to<br>
its desired position just before writing, rather than assuming it<br>
would be in the correct position (eof).<br>
<br>
What I failed to remember at the time is that method is generic, being<br>
also used for the before-images file (applied.images), which expects<br>
to be writing always from the *beginning* of the file, not the end.<br>
So my fix was put in at too low a level and inadvertently introduced<br>
this new bad bug, sorry.<br>
<br>
I've moved the fix to the proper place and released it as r44Beta1 on<br>
the "MagmaTester" project of squeaksource. I'm quite certain this<br>
will fix the problem for you. Would you please let me know if you<br>
encounter any further problems?<br>
<br>
- Chris<br>
<br>
PS - Shut down the db, you can then delete your old applied.images.<br>
<br>
<br>
On Fri, Dec 25, 2009 at 8:40 AM, Bart Gauquie <<a href="mailto:bart.gauquie@gmail.com">bart.gauquie@gmail.com</a>> wrote:<br>
> Dear all,<br>
><br>
> I'm getting following error trying to add a new entry to a Magma Database:<br>
> aString: 'File write failed'<br>
> see attachment for more details.<br>
> The error is that the 'applied.images' file has reached 2 Gigabyte on my<br>
> machine. All the commits I've done, happened in the same session ...<br>
> Stopping and starting database does not work, because Magma again tries to<br>
> write to the applied.images file. Restarting the image does work, since the<br>
> applied.images file is empty again.<br>
> Is this a known issue ? Should Magma not 'rotate' the file if it reaches the<br>
> maximum ? I'm using Ubuntu Linux 9.10 64 bit; with ext4 as a filesystem.<br>
> Thanks for any help,<br>
> Kind Regards,<br>
> Bart<br>
> --<br>
> imagination is more important than knowledge - Albert Einstein<br>
> Logic will get you from A to B. Imagination will take you everywhere -<br>
> Albert Einstein<br>
> Learn from yesterday, live for today, hope for tomorrow. The important thing<br>
> is not to stop questioning. - Albert Einstein<br>
> The true sign of intelligence is not knowledge but imagination. - Albert<br>
> Einstein<br>
> Gravitation is not responsible for people falling in love. - Albert Einstein<br>
><br>
> _______________________________________________<br>
> Magma mailing list<br>
> <a href="mailto:Magma@lists.squeakfoundation.org">Magma@lists.squeakfoundation.org</a><br>
> <a href="http://lists.squeakfoundation.org/mailman/listinfo/magma" target="_blank">http://lists.squeakfoundation.org/mailman/listinfo/magma</a><br>
><br> ></blockquote></div><br>