[Pkg] SystemEditor: SystemEditor-Squeak-mtf.163.mcz

[squeak-dev-noreply at lists.squeakfoundation.org]

A new version of SystemEditor-Squeak was added to project SystemEditor:
http://www.squeaksource.com/SystemEditor/SystemEditor-Squeak-mtf.163.mcz

==================== Summary ====================

Name: SystemEditor-Squeak-mtf.163
Author: mtf
Time: 11 December 2008, 2:19:58 pm
UUID: d14be531-9e22-4cda-9fcb-190941f1a6ee
Ancestors: SystemEditor-Squeak-mtf.162

changed progress bar display from a per-object setting to a per-commit setting, mostly for the benifit of the test suite

=============== Diff against SystemEditor-Squeak-mtf.162 ===============

Item was changed:
  ----- Method: SystemEditor>>commit (in category 'building') -----
  commit
- 	| migration export |
- 	showProgress ifNil: [showProgress := false].
- 	self validate.
  
+ 	self commitWithProgress: false withGC: true!
- 	self edExpandEditors.
- 
- 	migration := MigrationTransaction new.
- 	self edPrepareMigration: migration.
- 
- 	export := ClassExporter on: subject.
- 	self edPrepareExport: export.
- 
- 	showProgress ifTrue: [(1 to: 2) do: [:ea | ] displayingProgress: 'Committing...'].
- 	[migration commit.
- 	export commit.
- 	self edPostLoad.
- 	self edCommitRemovals.
- 	self edRecategorize.
- 	Smalltalk garbageCollect.
- 	"See ClassBuilder>>update:to: for an explanation of why the garbageCollect is necessary"
- 	] valueUnpreemptively.
- 	
- 	^ true!

Item was changed:
  ----- Method: SystemEditor>>commitWithProgress (in category 'building') -----
  commitWithProgress
  
+ 	self commitWithProgress: true withGC: true!
- 	showProgress := true.
- 	self commit.
- 	showProgress := false.!

Item was added:
+ ----- Method: SystemEditor>>edPrepareExport:withProgress: (in category 'building') -----
+ edPrepareExport: exporter withProgress: showProgress
+ 
+ 	showProgress
+ 		ifFalse:	[additions do: [:ea | ea edPrepareExport: exporter]]
+ 		ifTrue:	[additions do: [:ea | ea edPrepareExport: exporter] displayingProgress: 'Preparing Classes...']!

Item was added:
+ ----- Method: SystemEditor>>edPrepareMigration:withProgress: (in category 'building') -----
+ edPrepareMigration: txn withProgress: showProgress
+ 
+ 	showProgress
+ 		ifFalse:	[additions do: [:ea | ea edPrepareMigration: txn]]
+ 		ifTrue:	[additions do: [:ea | ea edPrepareMigration: txn] displayingProgress: 'Preparing Transaction...']!

Item was added:
+ ----- Method: SystemEditor>>commitWithProgress:withGC: (in category 'building') -----
+ commitWithProgress: showProgress withGC: gc
+ 
+ 	| migration export |
+ 	self validate.
+ 
+ 	self edExpandEditors.
+ 
+ 	migration := MigrationTransaction new.
+ 	self edPrepareMigration: migration withProgress: showProgress.
+ 
+ 	export := ClassExporter on: subject.
+ 	self edPrepareExport: export withProgress: showProgress.
+ 
+ 	showProgress ifTrue: [(1 to: 2) do: [:ea | ] displayingProgress: 'Committing...'].
+ 	[migration commit.
+ 	export commit.
+ 	self edPostLoad.
+ 	self edCommitRemovals.
+ 	self edRecategorize.
+ 	gc ifTrue: [
+ 		"See ClassBuilder>>update:to: for an explanation of why the
+ 		garbageCollect is necessary. It is optional because some tools,
+ 		like Monticello, already need to do a gc after their own cleanup,
+ 		and the gc's can be merged for efficiency"
+ 		Smalltalk garbageCollect].
+ 	] valueUnpreemptively!

Item was changed:
  ----- Method: SystemEditor>>edPrepareMigration: (in category 'building') -----
  edPrepareMigration: txn
  
+ 	self edPrepareMigration: txn withProgress: false!
- 	showProgress
- 		ifFalse:	[additions do: [:ea | ea edPrepareMigration: txn]]
- 		ifTrue:	[additions do: [:ea | ea edPrepareMigration: txn] displayingProgress: 'Preparing Transaction...']!

Item was changed:
  DictionaryEditor subclass: #SystemEditor
+ 	instanceVariableNames: 'organization debug'
- 	instanceVariableNames: 'organization showProgress debug'
  	classVariableNames: ''
  	poolDictionaries: ''
  	category: 'SystemEditor-Squeak'!

Item was changed:
  ----- Method: SystemEditor>>edPrepareExport: (in category 'building') -----
  edPrepareExport: exporter
  
+ 	self edPrepareExport: exporter withProgress: false!
- 	showProgress
- 		ifFalse:	[additions do: [:ea | ea edPrepareExport: exporter]]
- 		ifTrue:	[additions do: [:ea | ea edPrepareExport: exporter] displayingProgress: 'Preparing Classes...']!