[Pkg] Tasks: Tasks-Squeak310-kph.59.mcz
squeak-dev-noreply at lists.squeakfoundation.org
squeak-dev-noreply at lists.squeakfoundation.org
Tue Dec 16 13:00:36 UTC 2008
A new version of Tasks-Squeak310 was added to project Tasks:
http://www.squeaksource.com/Tasks/Tasks-Squeak310-kph.59.mcz
==================== Summary ====================
Name: Tasks-Squeak310-kph.59
Author: kph
Time: 16 December 2008, 1:00:32 pm
UUID: cc2031d4-0f7f-47d5-8eb7-00b1f4c14a69
Ancestors: Tasks-Squeak310-kph.58
saved by Squeak310MakeBuildCandidate class
=============== Diff against Tasks-Squeak310-kph.58 ===============
Item was changed:
----- Method: Squeak310MakeBuildCandidate>>m05669WorkspaceopenFileconvenience (in category 'confirmed-open') -----
m05669WorkspaceopenFileconvenience
Installer mantis bug: 5669 fix: 'Workspace-openFile.2.cs'.
""""""
Bug ID: 0005669
Category: [Squeak] Tools
Severity: tweak
Reproducibility: always
Date Submitted: 12-23-06 06:21
+ Date Updated: 12-16-08 12:42
- Date Updated: 12-15-08 20:11
Reporter: Keith_Hodges
View Status: public
Handler:
Priority: normal
Resolution: open
Status: confirmed
Product Version:
Summary: 0005669: Workspace openFile: convenience method
Description: There is no convenience method for opening a workspace on text.<br />
<br />
Nor is there a way of saving a file such that it opens a workspace.<br />
<br />
And Workspace always adds '.text' to the name even if it already has it
Additional Information:
Notes:
(0008755 - 397 - 469 - 469 - 697 - 697 - 697)
wiz 12-25-06 08:46
See 0002993 and the recomplaint #4656.
You can actually ask to put a file in a workspace thusly:
In a file list read a text file. Using the menu (from the text pane)
select read text into workspace.
The problem is in 3.9 it doesn't quite work. and the fix in 0002993 never got in nor was a substitute fix ever created.
The fix AFAIK works quite well.
Yours in service, --Jerome Peace
(0008756 - 43 - 43 - 43 - 43 - 43 - 43)
Keith_Hodges 12-25-06 22:21
But there are STILL no convenience methods.
(0008757 - 631 - 719 - 719 - 719 - 719 - 719)
wiz 12-26-06 01:51
Cool, I piped up because I knew some things that were relevant.
What do you mean by convenience methods?
What do you see. And where do you see it being?
In other words, in positive terms, what is the users story?
The complaint here may make perfect sense to you. But how is the reader to understand what you mean? Please don't assume I have the same body of knowledge or vocabulary as you. In truth this is the first time I've come across the term "convenience methods" and I am totally at sea (i.e. pretty dang ignorant) as to what special meaning that has in this context.
Yours in curiosity, -- Jerome Peace
(0011294 - 163 - 205 - 205 - 205 - 205 - 205)
Keith_Hodges 10-10-07 23:03
ok example
A := Workspace open.
is A useful for addressing the workspace?
A := Workspace withContents: 'test'.
A := Workspace fromFile: 'test.txt'. etc
(0011305 - 430 - 496 - 496 - 496 - 496 - 496)
wiz 10-12-07 04:39
Hi Keith, Your examples start to get there. What I really want to see is the user story in the form
context: I wanted to do this( where you descirbe this generally and specifially enough that you give the reader of what you want)
problem: Why this can't be done yet
solution: Add these methods to here and its done. (Be inclusive of most all you want done.)
Then later you or others can upload the solution code.
(0011988 - 344 - 356 - 356 - 356 - 356 - 356)
kbrown 04-10-08 05:04
Here's an example of how to read text from a file into an appropriately named Workspace so you can use the Workspace windowbar menu to save the contents of the Workspace back into the same file easily.
(SHWorkspace new openLabel: 'myWorkspace') contents: ((FileStream fileNamed: 'myWorkspace.text') contentsOfEntireFile); changed: #contents.
(0012842 - 84 - 128 - 128 - 128 - 128 - 128)
Keith_Hodges 12-11-08 16:49
edited on: 12-15-08 20:12 "fix begin"
Installer mantis bug: 5669 fix: 'Workspace-openFile.2.cs'.
"fix end"
(0012843 - 65 - 71 - 71 - 71 - 71 - 71)
Keith_Hodges 12-11-08 17:42
w := Workspace openFile: 'Readme.txt'.
w label: 'Welcome to...'.
(0012846 - 153 - 187 - 187 - 187 - 187 - 187)
Keith_Hodges 12-13-08 01:47
edited on: 12-15-08 20:31 Included Workspace-openFile.1.cs in 081214-0249-Squeak3.10.2bc-beta
Workspace-openFile.2.cs - adds "open..." menu item to provide a file opening UI.
+ Files: #('M5669-Workspace-openFile.1.cs' 'Workspace-openFile.1.cs' 'Workspace-openFile.2.cs')!
- Files: #('Workspace-openFile.1.cs' 'Workspace-openFile.2.cs')!
Item was changed:
----- Method: Squeak310MakeBuildCandidate>>m07219ImproveStreamsUsageReadabili (in category 'assigned-open') -----
m07219ImproveStreamsUsageReadabili
Installer mantis bug: 7219 fix: 'Stream-Readability.4.cs'.
""""""
Bug ID: 0007219
Category: [Squeak] Collections
Severity: feature
Reproducibility: always
Date Submitted: 11-02-08 01:20
Date Updated: 12-12-08 02:16
Reporter: Keith_Hodges
View Status: public
Handler: Keith_Hodges
Priority: normal
Resolution: open
Status: assigned
Product Version: 3.10.2
Summary: 0007219: Improve Streams Usage Readability
Description: For making code gen more readable<br />
<br />
Used in Sake/Pacakges and Css generation code for much improved readability.
Additional Information: Part of what was Kernel-Extensions for 3.10/LPF. Is now no longer needed for LPF, but is needed for Sake.
Notes:
(0012758 - 159 - 221 - 221 - 221 - 221 - 221)
Keith_Hodges 11-02-08 01:21
edited on: 12-12-08 02:17 3 - has methods categorized
4 - added ByteArray-putOn: which got away.
"fix begin"
Installer mantis bug: 7219 fix: 'Stream-Readability.4.cs'.
"fix end"
Files: #('Stream-Readability.2.cs' 'Stream-Readability.3.cs' 'Stream-Readability.4.cs' 'Stream-Readability.1.cs')!
Item was changed:
----- Method: Squeak310MakeBuildCandidate>>m06086CannotuseCrLfFileStreamon (in category 'assigned-open') -----
m06086CannotuseCrLfFileStreamon
Installer mantis bug: 6086 fix: 'MultiByteFileStream.1.cs'.
""""""
Bug ID: 0006086
Category: [Squeak] Files
Severity: minor
Reproducibility: always
Date Submitted: 02-15-07 03:49
Date Updated: 02-15-07 04:23
Reporter: Keith_Hodges
View Status: public
Handler: cdegroot
Priority: normal
Resolution: open
Status: assigned
Product Version: 3.9
Summary: 0006086: Cannot use CrLfFileStream on '/dev/stdout'
Description: In the process of #detectLineEndConvention a primitive fails trying to obtain the position of '/dev/stdout'.<br />
<br />
Additional Information:
Notes:
(0009824 - 83 - 115 - 115 - 115 - 115 - 115)
Keith_Hodges 02-15-07 04:21
"fix begin"
Installer mantis bug: 6086 fix: 'MultiByteFileStream.1.cs'.
"fix end"
(0009825 - 171 - 183 - 183 - 183 - 183 - 183)
Keith_Hodges 02-15-07 04:23
MultiByteFileStream.1.cs
enables user to explicitly specify the lineEndConvention as an argument to #wantsLineEndConversion: doing so bypasses #detectLineEndConvention.
Files: #('MultiByteFileStream.1.cs')!
Item was changed:
----- Method: Squeak310MakeBuildCandidate>>m05851RefactorSmalltalkImagesaveAs (in category 'new-open') -----
m05851RefactorSmalltalkImagesaveAs
Installer mantis bug: 5851 fix: 'SmalltalkImage-M5851.3.cs'.
""""""
Bug ID: 0005851
Category: [Squeak] Kernel
Severity: trivial
Reproducibility: always
Date Submitted: 01-29-07 01:58
Date Updated: 06-10-08 04:35
Reporter: Keith_Hodges
View Status: public
Handler:
Priority: normal
Resolution: open
Status: new
Product Version: 3.10
Summary: 0005851: Refactor SmalltalkImage saveAs
Description: Refactor SmalltalkImage-#saveAs to pull out the code that actually saves the image under a new name, into #saveAs: newName<br />
<br />
Refactor some other methods that duplicate the use of the same code, to use #saveAs:
Additional Information:
Notes:
(0009235 - 80 - 124 - 124 - 124 - 124 - 124)
Keith_Hodges 01-29-07 01:59
edited on: 02-14-07 12:15 "fix begin"
Installer mantis bug: 5851 fix: 'SmalltalkImage.2.cs'.
"fix end"
(0009762 - 76 - 76 - 76 - 76 - 76 - 76)
Keith_Hodges 02-14-07 12:14
SmalltalkImage.2.cs ensures that the resuming flag is returned from #saveAs:
(0012290 - 84 - 116 - 116 - 116 - 116 - 116)
matthewf 06-10-08 04:35
"fix begin"
Installer mantis bug: 5851 fix: 'SmalltalkImage-M5851.3.cs'.
"fix end"
(0012291 - 58 - 58 - 58 - 58 - 58 - 58)
matthewf 06-10-08 04:35
SmalltalkImage-M5851.3.cs removes an underscore assignment
Files: #('SmalltalkImage-M5851.3.cs' 'SmalltalkImage.1.cs' 'SmalltalkImage.2.cs')!
Item was changed:
----- Method: Squeak310MakeBuildCandidate>>m06868SystemNavigationobsoleteBehav (in category 'new-open') -----
m06868SystemNavigationobsoleteBehav
Installer mantis bug: 6868 fix: 'SystemNavigation-obsoleteBehaviors.1.st'.
""""""
Bug ID: 0006868
Category: [Squeak] System
Severity: minor
Reproducibility: always
Date Submitted: 01-21-08 22:30
Date Updated: 01-22-08 21:53
Reporter: Keith_Hodges
View Status: public
Handler:
Priority: normal
Resolution: open
Status: new
Product Version:
Summary: 0006868: SystemNavigation-#obsoleteBehaviours chokes on ProtoObjects
Description: Traversing all objects in the system, breaks on ProtoObjects which do not implement #isBehavior<br />
Additional Information:
Notes:
(0011694 - 100 - 144 - 144 - 144 - 144 - 144)
Keith_Hodges 01-21-08 22:36
edited on: 01-22-08 11:37 "fix begin"
Installer mantis bug: 6868 fix: 'SystemNavigation-obsoleteBehaviors.1.st'.
"fix end"
(0011696 - 219 - 243 - 243 - 243 - 243 - 243)
Keith_Hodges 01-22-08 00:01
edited on: 01-22-08 11:08 SystemNavigation-obsoleteBehaviors.1.st is a reimplementation in terms of (obj inheritsFrom: Behavior)
As an alternative ProtoObject-isBehavior.1.cs moves the implementation of isBehavior from Object to ProtoObject
Files: #('SystemNavigation-obsoleteBehaviors.st' 'ProtoObject-isBehavior.1.cs' 'SystemNavigation-obsoleteBehaviors.1.st')!
Item was changed:
----- Method: Squeak310MakeBuildCandidate>>m07131SyntaxErrordialogsraisemore (in category 'new-open') -----
m07131SyntaxErrordialogsraisemore
Installer mantis bug: 7131 fix: 'SyntaxErrorUsesNonInteractiveParser-M7131.1.cs'.
""""""
Bug ID: 0007131
Category: [Squeak] Compiler
Severity: minor
Reproducibility: always
Date Submitted: 07-22-08 04:33
Date Updated: 07-22-08 04:36
Reporter: matthewf
View Status: public
Handler:
Priority: normal
Resolution: open
Status: new
Product Version:
Summary: 0007131: Syntax Error dialogs raise more errors than does the calling Parser
Description: A syntax error dialog is created to fix a very specific error in a non-interactive parser; however, it runs in interactive mode, so it rejects code that the calling parser would have accepted. The syntax error dialog should accept exactly the same code as the calling parser would have - no more, no less.
Additional Information: In non-interactive mode, the following errors prompt for user interaction in the form of a SyntaxError dialog:<br />
- Syntax error<br />
<br />
In interactive mode, the following errors cause user interaction in the form of pop-ups and text prompts:<br />
- Syntax error<br />
- Unknown global variable/local variable/selector<br />
- Changing some special selectors
Notes:
(0012400 - 97 - 97 - 97 - 97 - 97 - 97)
matthewf 07-22-08 04:34
The attached change set makes SyntaxError dialogs compile in non-interactive mode, fixing the bug
(0012401 - 105 - 137 - 137 - 137 - 137 - 137)
matthewf 07-22-08 04:36
"fix begin"
Installer mantis bug: 7131 fix: 'SyntaxErrorUsesNonInteractiveParser-M7131.1.cs'.
"fix end"
Files: #('SyntaxErrorUsesNonInteractiveParser-M7131.1.cs')!
Item was changed:
----- Method: Squeak310MakeBuildCandidate>>m07166speedupallSelectorsaddallSel (in category 'new-open') -----
m07166speedupallSelectorsaddallSel
Installer mantis bug: 7166 fix: 'Speedup-AllSelectors-M7166.1.cs'.
""""""
Bug ID: 0007166
Category: [Squeak] Kernel
Severity: tweak
Reproducibility: always
Date Submitted: 08-27-08 21:43
Date Updated: 09-28-08 16:26
Reporter: Keith_Hodges
View Status: public
Handler:
Priority: normal
Resolution: open
Status: new
Product Version: 3.10.2
Summary: 0007166: speedup allSelectors add allSelectorsBelow:
Description: Firstly #allSelectors inefficiently creates multiple intermediate collections. Refactoring this yields a 27% speed improvement. <br />
<br />
Secondly many users of #allSelectors forget that when applied to the class side it doesnt stop at ProtoObject class, it continues to Class ClassDescription, Behavior, Object and ProtoObject. This is catered for by adding #allSelectorsBelow:<br />
<br />
Magritte and SUnit are heavy users which benefit.
Additional Information:
Notes:
(0012533 - 88 - 120 - 120 - 120 - 120 - 120)
Keith_Hodges 08-27-08 21:44
"fix begin"
Installer mantis bug: 7166 fix: 'Speedup-AllSelectors-M7166.cs'.
"fix end"
(0012702 - 141 - 141 - 141 - 141 - 141 - 141)
Damien Cassou 09-28-08 14:01
I've sent that fix to PharoInbox. I replaced 'withAllSuperclasses do:' by 'withAllSuperclassDo:' to avoid the creation of another collection.
(0012703 - 283 - 343 - 343 - 343 - 343 - 343)
Damien Cassou 09-28-08 14:47
I also added the following test:
testAllSelectors
self assert: ProtoObject allSelectors = ProtoObject selectors.
self assert: Object allSelectors = (Object selectors union: ProtoObject selectors).
self assert: (Object allSelectorsBelow: ProtoObject) = (Object selectors).
(0012704 - 90 - 122 - 122 - 122 - 122 - 122)
Damien Cassou 09-28-08 16:26
"fix begin"
Installer mantis bug: 7166 fix: 'Speedup-AllSelectors-M7166.1.cs'.
"fix end"
Files: #('Speedup-AllSelectors-M7166.1.cs' 'Speedup-AllSelectors-M7166.cs')!
Item was changed:
----- Method: Squeak310MakeBuildCandidate>>m06466LazyListMorphlistChagedfixupl (in category 'new-open') -----
m06466LazyListMorphlistChagedfixupl
Installer mantis bug: 6466 fix: 'LazyListMorph-listChanged.st'.
""""""
Bug ID: 0006466
Category: [Squeak] Morphic
Severity: minor
Reproducibility: always
Date Submitted: 05-06-07 15:02
Date Updated: 12-13-08 01:39
Reporter: Keith_Hodges
View Status: public
Handler:
Priority: normal
Resolution: open
Status: new
Product Version: 3.9
Summary: 0006466: LazyListMorph-listChaged fixuploaded to squeak-dev
Description: This fixes the fact that some list morphs need to be resized in order to be used, this is particularly noticable in 3.9 buy opening a PackagePaneBrowser, the left hand list is not scrollable.
Additional Information:
Notes:
(0010668 - 88 - 120 - 120 - 120 - 120 - 120)
Keith_Hodges 05-06-07 15:03
"fix begin"
Installer mantis bug: 6466 fix: 'LazyListMorph-listChanged.st'.
"fix end"
(0010669 - 427 - 475 - 475 - 475 - 475 - 475)
wiz 05-06-07 20:54
Hi Keith,
Tried it. Fix works for PackagePaneBrowsers.
I did notice that the fileout uses unix line endings (lfs) which made the source look like it was all on one line on my Mac.
I am also wondering what an appropriate test would be. Genning up a package browser and mucking around in its package list looking at scrollbars would seem to be excessive. I wonder if there is an easier way to demostrate the problem.
(0010670 - 11 - 11 - 11 - 11 - 11 - 11)
KenCausey 05-07-07 18:24
categorized
(0012845 - 41 - 41 - 41 - 41 - 41 - 41)
Keith_Hodges 12-13-08 01:39
uploaded file has had lf problem resolved
Files: #('LazyListMorph-listChanged.st')!
Item was changed:
----- Method: Squeak310MakeBuildCandidate>>m07218ClassOrganizercategoriesbreak (in category 'new-open') -----
m07218ClassOrganizercategoriesbreak
Installer mantis bug: 7218 fix: 'Categorizer-categories.st'.
""""""
Bug ID: 0007218
Category: [Squeak] Kernel
Severity: minor
Reproducibility: always
Date Submitted: 10-26-08 02:01
Date Updated: 10-26-08 02:22
Reporter: Keith_Hodges
View Status: public
Handler:
Priority: normal
Resolution: open
Status: new
Product Version: 3.10.2
Summary: 0007218: ClassOrganizer categories breaks if given an empty array
Description: ClassOrganizer categories: attempts to ensure that the list of categories matches the existing ones. However if the class has no methods/elements this test fails.<br />
<br />
So if you call categorizer with an empty array, on a class with no elements/methods the net result is that the data structure is corrupted.<br />
<br />
categoryStops gets set to #() when it should be at least #(0)
Additional Information:
Notes:
(0012752 - 84 - 116 - 116 - 116 - 116 - 116)
Keith_Hodges 10-26-08 02:19
"fix begin"
Installer mantis bug: 7218 fix: 'Categorizer-categories.st'.
"fix end"
(0012753 - 71 - 71 - 71 - 71 - 71 - 71)
Keith_Hodges 10-26-08 02:22
SystemEditor was the culprit that calls categories: with an empty array
Files: #('Categorizer-categories.st')!
Item was changed:
----- Method: Squeak310MakeBuildCandidate>>m07244ImagecleanUpmethods (in category 'new-open') -----
m07244ImagecleanUpmethods
+ Installer mantis bug: 7244 fix: 'M7244-CleanUps.1.cs'.
- Installer mantis bug: 7244 fix: 'CleanUps.2.cs'.
""""""
Bug ID: 0007244
Category: [Squeak] Kernel
Severity: major
Reproducibility: always
Date Submitted: 12-12-08 03:03
+ Date Updated: 12-16-08 12:40
- Date Updated: 12-15-08 21:58
Reporter: Keith_Hodges
View Status: public
Handler:
Priority: high
Resolution: open
Status: new
Product Version: 3.10.2
Summary: 0007244: Image cleanUp methods
Description: Methods implementing<br />
<br />
SmalltalkImage current cleanUpAll.<br />
&<br />
SmalltalkImage current freeSpace.<br />
Additional Information:
Notes:
+ (0012844 - 80 - 124 - 124 - 124 - 124 - 124)
- (0012844 - 74 - 118 - 118 - 118 - 118 - 118)
Keith_Hodges 12-12-08 03:05
+ edited on: 12-16-08 12:41 "fix begin"
+ Installer mantis bug: 7244 fix: 'M7244-CleanUps.1.cs'.
- edited on: 12-15-08 21:55 "fix begin"
- Installer mantis bug: 7244 fix: 'CleanUps.2.cs'.
"fix end"
+ (0012850 - 155 - 185 - 185 - 185 - 185 - 185)
- (0012850 - 108 - 132 - 132 - 132 - 132 - 132)
Keith_Hodges 12-15-08 21:56
+ edited on: 12-16-08 12:41 CleanUps.2.cs - adds cleanUpAllExcept: aListOfClassNames
+ M7244-CleanUps.1.cs - fix to cleanUpAllExcept
- edited on: 12-15-08 21:59 CleanUps.2.cs - adds cleanUpAllExcept: aListOfClassNames
Fix intended for 3.10.2, included in 3.10.2-bc
+ Files: #('CleanUps.1.cs' 'CleanUps.2.cs' 'M7244-CleanUps.1.cs')!
- Files: #('CleanUps.2.cs' 'CleanUps.1.cs')!
Item was changed:
----- Method: Squeak310MakeBuildCandidate>>m05706Needminimalsocketstats (in category 'assigned-open') -----
m05706Needminimalsocketstats
Installer mantis bug: 5706 fix: 'SocketStats.6.cs'.
"fix test"
Installer mantis bug: 5706 fix: 'SocketStatsTest.2.cs'.
""""""
Bug ID: 0005706
Category: [Squeak] Network
Severity: minor
Reproducibility: always
Date Submitted: 01-06-07 20:13
Date Updated: 01-10-07 13:02
Reporter: Keith_Hodges
View Status: public
Handler: cdegroot
Priority: normal
Resolution: open
Status: assigned
Product Version: 3.10
Summary: 0005706: Need minimal socket stats
Description: There is no way to easily work out whether a particular block of code accessed the network. Simple StatsOpened and StatsClosed counters would solve this problem. <br />
<br />
This is needed to categorize tests that do make use of the network.
Additional Information:
Notes:
(0008844 - 303 - 381 - 381 - 381 - 381 - 381)
Keith_Hodges 01-06-07 20:15
edited on: 01-10-07 13:03 The StatsOpened counter is incremented by #register: and StatsClosed is incremented by #unregister: Counters are reset on initial network initialization.
"fix begin"
Installer mantis bug: 5706 fix: 'SocketStats.6.cs'.
"fix test"
Installer mantis bug: 5706 fix: 'SocketStatsTest.2.cs'.
"fix end"
Files: #('SocketStats.2.cs' 'SocketStatsTest.2.cs' 'SocketStats.3.cs' 'SocketStats.4.cs' 'SocketStatsTest.1.cs' 'SocketStats.5.cs' 'SocketStats.6.cs' 'SocketStats.1.cs')!
Item was changed:
----- Method: Squeak310MakeBuildCandidate>>m07205MonticelloSnapshotSpeedupvia (in category 'resolved-fixed') -----
m07205MonticelloSnapshotSpeedupvia
Installer mantis bug: 7205 fix: 'MethodReference-category-M7205.2.cs'.
""""""
Bug ID: 0007205
Category: [Squeak] Monticello
Severity: tweak
Reproducibility: N/A
Date Submitted: 10-04-08 17:14
Date Updated: 10-05-08 04:58
Reporter: matthewf
View Status: public
Handler: matthewf
Priority: normal
Resolution: fixed
Status: resolved
Product Version:
Summary: 0007205: Monticello Snapshot Speedup via new MethodReference ivar
Description: Adding the ivar 'category' to methodReference allows a 25% speedup in Monticello snapshotting, after source caching. This capability is exploited as of PackageInfo-Base-mtf.56
Additional Information:
Notes:
(0012717 - 96 - 140 - 140 - 140 - 140 - 140)
matthewf 10-04-08 17:21
edited on: 10-05-08 04:57 "fix begin"
Installer mantis bug: 7205 fix: 'MethodReference-category-M7205.2.cs'.
"fix end"
(0012718 - 60 - 60 - 60 - 60 - 60 - 60)
matthewf 10-05-08 04:58
oops; the changeset didn't actually have the class def. oops
Files: #('MethodReference-category-M7205.2.cs' 'MethodReference-category-M7205.1.cs')!
Item was removed:
- ----- Method: Squeak310MakeBuildCandidate>>m07076testsTherevision529of (in category 'resolved-fixed') -----
- m07076testsTherevision529of
-
- """"""
- Bug ID: 0007076
- Category: [Squeak] Janitorial
- Severity: major
- Reproducibility: always
- Date Submitted: 05-31-08 03:18
- Date Updated: 06-05-08 19:24
- Reporter: wiz
- View Status: public
- Handler: KenCausey
- Priority: urgent
- Resolution: fixed
- Status: resolved
- Product Version: 3.10.1
- Summary: 0007076: [tests] The revision (5-29) of the release still leaves problems and 5 classes with no category in system
- Description: In a fresh 3.10.1<br />
- <br />
- run the uploaded tests.<br />
- at least one will fail.<br />
- <br />
- click on the fix code<br />
- then run the up loaded tests again.<br />
- <br />
- one test now runs but the other will break.<br />
- <br />
- See: <a href="view.php?id=7070" title="[closed] Browser category Morphic-CandidatesForGo contains missing classes">0007070</a><br />
- <br />
- <br />
- Additional Information: The fixing code removes the five substantial classes from the catagory but not from the system.<br />
- <br />
- The classes will not show up in a browser but are still in the Smalltalk dictionary and so included in #allClasses.<br />
- <br />
- If anything assumes there will be a catagory for each class it will break.<br />
- <br />
- The final steps of the release seem to have been done in a much more complicated way than needed.<br />
- <br />
- Updating via the update stream from 7160-7175 will give an image that passes both tests. <br />
- Then all that would be needed is a cs with a postscript to condense changes.<br />
- <br />
- Sometimes the last bug is a difficult one to remove. I encourage the release team to take whatever effort to get this right.<br />
- Squeaks reputation is at stake.<br />
- <br />
- Yours in service and curiosity, --Jerome Peace<br />
- <br />
- Notes:
- (0012232 - 420 - 529 - 529 - 645 - 645 - 645)
- wiz 05-31-08 03:42
- M7076ReleaseTests-wiz.1.cs
- adds two tests to ReleaseTests
- both pass in a version of 7175 from the updatestream.
- in the 5-29 revision of 7175 the #testSystemCategoryClasses fails before the "click fix"
- and #testClassesSystemCategory fails after the "click fix" Yours in service and curiosity, --Jerome Peace.
- This supercedes my suggested fix in 0007070 and fixes some of my creative spelling. :-)
-
- (0012233 - 194 - 236 - 236 - 236 - 236 - 236)
- wiz 05-31-08 03:46
- Reminder sent to: edgardec, KenCauseyHi Ken, Hi Edgar,
- I think you need to make these tests work in a corrected release of 3.10.1 Thanks for you attention to these matters.
- Yours in service and curiosity, --Jerome Peace
-
- (0012235 - 1619 - 2081 - 2283 - 2283 - 2283 - 2283)
- wiz 06-02-08 05:48
- Ha. commenting out a section was all that was needed. If the classes are not removed individually then
- removing the category will delete the classes as well. Which is what is wanted.
- See also:
- http://lists.squeakfoundation.org/pipermail/squeak-dev/2008-June/129026.html [^]
- my reply to Klaus.
- I think there might be some more issues with the release.
- Ken: how did you actually complete things?
- How was the phantom category reintroduced?
- Did the process risk other things coming back as well?
- How similar can we prove this image to the image genned up by updating a 7160 from the update stream?
- How would we build a test to see if the similarity is there or not?
- E.g. (the number of classes should be the same. ditto the number of compiled methods. What else would be worth checking?)
- Can we check method timestamps for equality between the two images?
- Anyway the corrected code is below.
- I could not figure how to get the click action to work again once I edited it.
- SystemOrganization categories do: [:catName |
- (SystemOrganization listAtCategoryNamed: catName)
- do: [:className |
- (Smalltalk includesKey: className) ifFalse: [
- Transcript show: 'Removing ', className printString, String cr.
- SystemOrganization removeElement: className]]].
- SystemOrganization classify: #ClassRepresentativeMorph under: 'EToys-Scripting'.
- "#(CommandTilesMorph DrawErrorMorph PhraseWrapperMorph ViewerEntry ViewerRow) do: [ :symbol | SystemOrganization removeElement: symbol ]."
- SystemOrganization removeSystemCategory: 'Morphic-CandidatesForGo'.
-
- (0012257 - 138 - 138 - 138 - 138 - 138 - 138)
- KenCausey 06-05-08 18:53
- These tests have been added to the update stream for 3.10.2beta as update 7177, an improved fix for the problem is intended as update 7178
-
- (0012258 - 113 - 113 - 113 - 113 - 113 - 113)
- KenCausey 06-05-08 19:24
- A proper fix for this which passes the tests attached and included in update 7177 has been issued as update 7178.
-
- Files: #('M7076ReleaseTests-wiz.1.cs')!
More information about the Packages
mailing list