[Pkg] Squeak3.11 Contributions: MethodAuthorship-mtf.19.mcz
bert at freudenbergs.de
Tue Feb 10 06:23:08 UTC 2009
On 09.02.2009, at 20:15, Matthew Fulmer wrote:
> On Mon, Feb 09, 2009 at 06:16:26PM +0100, Bert Freudenberg wrote:
>> So you have tons of FileStreams open at the same time? Say you have
>> 1000 files open and the common path is 100 characters long that would
>> save 100 KB. Are you sure this problem is severe enough to warrant
>> such evil hacks?
> Yes. Before, the source code for every single method in the
> update stream was stored in the history image:
> MethodHistoryChangeRecord allInstances size -> 158547
> Now, I changed MethodHistoryChangeRecord to use a (closed)
> FileStream instance and pointer, as its superclass ChangeRecord
> already does.
So you do *not* have many filestreams open at once. The right thing to
deal with this would have been to just store the relative file name in
the change record, and open a stream on-the-fly.
> Given that this image and the MethodAuthorship package are only
> useful for the next month, while we relicense squeak, and not
> thereafter, I think the hackery is justifiable.
Well, you never know where code ends up being used again. OTOH I agree
that hackery is warranted in one-off uses. I do that a lot, I just do
not check it into a public repo ;)
Anyway, thanks for doing this!
- Bert -
More information about the Packages