[Pkg] The Trunk: Tools-dtl.172.mcz

commits at source.squeak.org commits at source.squeak.org
Tue Feb 9 13:10:01 UTC 2010


David T. Lewis uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-dtl.172.mcz

==================== Summary ====================

Name: Tools-dtl.172
Author: dtl
Time: 9 February 2010, 8:09:24.851 am
UUID: 52e4298f-2ca1-4806-84c8-f7ee3832f559
Ancestors: Tools-nice.171

Remove explicit MVC and Morphic dependencies from SyntaxError. SyntaxError is a model in Debugger (not an exception class).

=============== Diff against Tools-nice.171 ===============

Item was changed:
  ----- Method: SyntaxError class>>open: (in category 'instance creation') -----
  open: aSyntaxError
  	"Answer a standard system view whose model is an instance of me."
+ 	
+ 	^ Project current
+ 		dispatchTo: self
+ 		addPrefixAndSend: #Open:
+ 		withArguments: {aSyntaxError}
- 	| topView |
- 	<primitive: 19> "Simulation guard"
- 	Smalltalk isMorphic
- 		ifTrue:
- 			[self buildMorphicViewOn: aSyntaxError.
- 			Project spawnNewProcessIfThisIsUI: Processor activeProcess.
- 			^ Processor activeProcess suspend].
- 	topView := self buildMVCViewOn: aSyntaxError.
- 	topView controller openNoTerminateDisplayAt: Display extent // 2.
- 	Cursor normal show.
- 	Processor activeProcess suspend.
  !

Item was removed:
- ----- Method: SyntaxError class>>buildMVCViewOn: (in category 'instance creation') -----
- buildMVCViewOn: aSyntaxError
- 	"Answer an MVC view on the given SyntaxError."
- 
- 	| topView aListView aCodeView |
- 	topView := StandardSystemView new
- 		model: aSyntaxError;
- 		label: 'Syntax Error';
- 		minimumSize: 380 at 220.
- 
- 	aListView := PluggableListView on: aSyntaxError
- 		list: #list
- 		selected: #listIndex
- 		changeSelected: nil
- 		menu: #listMenu:.
- 	aListView window: (0 at 0 extent: 380 at 20).
- 	topView addSubView: aListView.
- 
- 	aCodeView := PluggableTextView on: aSyntaxError
- 		text: #contents
- 		accept: #contents:notifying:
- 		readSelection: #contentsSelection
- 		menu: #codePaneMenu:shifted:.
- 	aCodeView window: (0 at 0 extent: 380 at 200).
- 	topView addSubView: aCodeView below: aListView.
- 
- 	^ topView
- !

Item was removed:
- ----- Method: SyntaxError class>>buildMorphicViewOn: (in category 'instance creation') -----
- buildMorphicViewOn: aSyntaxError
- 	"Answer an Morphic view on the given SyntaxError."
- 	| window |
- 	window := (SystemWindow labelled: 'Syntax Error') model: aSyntaxError.
- 
- 	window addMorph: (PluggableListMorph on: aSyntaxError list: #list
- 			selected: #listIndex changeSelected: nil menu: #listMenu:)
- 		frame: (0 at 0 corner: 1 at 0.15).
- 
- 	window addMorph: (PluggableTextMorph on: aSyntaxError text: #contents
- 			accept: #contents:notifying: readSelection: #contentsSelection
- 			menu: #codePaneMenu:shifted:)
- 		frame: (0 at 0.15 corner: 1 at 1).
- 
- 	^ window openInWorldExtent: 380 at 220!



More information about the Packages mailing list