[Pkg] The Trunk: System-nice.377.mcz

[commits at source.squeak.org]

Nicolas Cellier uploaded a new version of System to project The Trunk:
http://source.squeak.org/trunk/System-nice.377.mcz

==================== Summary ====================

Name: System-nice.377
Author: nice
Time: 21 September 2010, 10:43:37.706 am
UUID: 732120dc-fc62-9e4f-871c-c4954d75292c
Ancestors: System-nice.376

1) Fix broken logic used to set user name in mail sender.
2) Import a few ifNil: refactorings from Cuis.

=============== Diff against System-nice.376 ===============

Item was changed:
  ----- Method: Beeper class>>default (in category 'customize') -----
  default
  	"When the default is not defined it is
  	initialized using #newDefault."
  
+ 	^ default ifNil: [ default := self newDefault ]!
- 	default isNil 
- 		ifTrue: [default := self newDefault ].
- 	^ default!

Item was changed:
  ----- Method: BreakpointManager class>>installed (in category 'private') -----
  installed
+ 	^Installed ifNil: [Installed := IdentityDictionary new]!
- 	Installed isNil ifTrue:[Installed := IdentityDictionary new].
- 	^Installed!

Item was changed:
  ----- Method: MailSender class>>setUserName (in category 'settings') -----
  setUserName
  	"Change the user's email name for use in composing messages."
  
+ 	(UIManager default
+ 			request: 'What is your email address?\(This is the address other people will reply to you)' withCRs
+ 			initialAnswer: (UserName ifNil: [UserName := '']))
+ 		ifNotNil: [:answer | UserName := answer]!
- 	(UserName isNil) ifTrue: [UserName := ''].
- 	UserName := UIManager default
- 		request: 'What is your email address?\(This is the address other people will reply to you)' withCRs
- 		initialAnswer: UserName.
- 	UserName ifNotNil: [UserName := UserName]!

Item was changed:
  ----- Method: PseudoClass>>comment (in category 'class') -----
  comment
+ 	^self organization commentRemoteStr
+ 		ifNil: [ self name,' has not been commented in this file']
+ 		ifNotNil: [:rStr | rStr string]!
- 	| rStr |
- 	rStr := self organization commentRemoteStr.
- 	^rStr isNil
- 		ifTrue:[self name,' has not been commented in this file']
- 		ifFalse:[rStr string]!

Item was changed:
  ----- Method: PseudoClass>>hasChanges (in category 'testing') -----
  hasChanges
  
  	self sourceCode isEmpty ifFalse:[^true].
  	self organization hasNoComment ifFalse:[^true].
+ 	definition ifNotNil: [ ^true].
+ 	metaClass ifNotNil: [ ^metaClass hasChanges].
- 	definition isNil ifFalse:[^true].
- 	metaClass isNil ifFalse:[^metaClass hasChanges].
  	^false!

Item was changed:
  ----- Method: PseudoClass>>removeAllUnmodified (in category 'removing') -----
  removeAllUnmodified
  	| stClass |
  	self exists ifFalse:[^self].
  	self removeUnmodifiedMethods: self selectors.
  	stClass := self realClass.
  	(self hasDefinition and:[stClass definition = self definition]) ifTrue:[definition := nil].
  	(self hasComment and:[stClass comment asString = self commentString]) ifTrue:[ self classComment: nil].
+ 	metaClass ifNotNil: [ metaClass removeAllUnmodified]!
- 	metaClass isNil ifFalse:[metaClass removeAllUnmodified].!

Item was changed:
  ----- Method: SimpleServiceEntry>>printOn: (in category 'printing') -----
  printOn: aStream
  
  	aStream nextPutAll: self class name; nextPutAll: ': ('.
+ 	self provider
+ 		ifNotNil: [ aStream nextPutAll: provider printString].
- 	self provider notNil
- 		ifTrue: [aStream nextPutAll: provider printString].
  	aStream nextPutAll: ' --- '. 
+ 	self selector
+ 		ifNotNil: [ aStream nextPutAll: selector asString].
- 	self selector notNil
- 		ifTrue: [aStream nextPutAll: selector asString].
  	aStream nextPut: $)
  
  !

Item was changed:
  ----- Method: SpaceTallyItem>>printOn: (in category 'printing') -----
  printOn: aStream
  
+ 	analyzedClassName
+ 		ifNotNil: [ aStream nextPutAll: analyzedClassName asString]. 
- 	analyzedClassName isNil
- 		ifFalse: [aStream nextPutAll: analyzedClassName asString]. 
  	aStream nextPutAll: ' ('.
+ 	codeSize
+ 		ifNotNil: [ aStream nextPutAll: 'code size: ' ;  nextPutAll: codeSize asString]. 
+ 	instanceCount
+ 		ifNotNil: [ aStream nextPutAll: ' instance count: ' ;  nextPutAll: instanceCount asString]. 
+ 	spaceForInstances
+ 		ifNotNil: [ aStream nextPutAll: ' space for instances: ' ;  nextPutAll: spaceForInstances asString]. 
- 	codeSize isNil
- 		ifFalse: [aStream nextPutAll: 'code size: ' ;  nextPutAll: codeSize asString]. 
- 	instanceCount isNil
- 		ifFalse: [aStream nextPutAll: ' instance count: ' ;  nextPutAll: instanceCount asString]. 
- 	spaceForInstances isNil
- 		ifFalse: [aStream nextPutAll: ' space for instances: ' ;  nextPutAll: spaceForInstances asString]. 
  	aStream nextPut: $).
  	!