[Pkg] The Trunk: Tools-fbs.320.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Apr 20 23:12:41 UTC 2011


Levente Uzonyi uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-fbs.320.mcz

==================== Summary ====================

Name: Tools-fbs.320
Author: fbs
Time: 17 March 2011, 5:41:21.841 pm
UUID: 78aae8c7-90bd-3442-a0b1-d2fb8d211359
Ancestors: Tools-fbs.319

Replace references to messageListIndex in places that are either difficult/impossible to test, or are Very Dangerous (and impossible for me to test right now).

=============== Diff against Tools-fbs.319 ===============

Item was changed:
  ----- Method: Browser>>buildMessageCategoryBrowserEditString: (in category 'message category functions') -----
  buildMessageCategoryBrowserEditString: aString 
  	"Create and schedule a message category browser for the currently 
  	selected	 message category. The initial text view contains the characters 
  	in aString."
  	"wod 6/24/1998: set newBrowser classListIndex so that it works whether the
  	receiver is a standard or a Hierarchy Browser."
  
  	| newBrowser |
  	^ self hasMessageCategorySelected
  		ifFalse: [ nil ]
  		ifTrue: 
  			[newBrowser := Browser new.
  			newBrowser selectSystemCategory: self selectedSystemCategory.
  			newBrowser classListIndex: (newBrowser classList indexOf: self selectedClassName).
  			newBrowser metaClassIndicated: metaClassIndicated.
  			newBrowser messageCategoryListIndex: messageCategoryListIndex.
+ 			newBrowser selectMessageNamed: self selectedMessageName.
- 			newBrowser messageListIndex: messageListIndex.
  			self class openBrowserView: (newBrowser openMessageCatEditString: aString)
  				label: 'Message Category Browser (' , 
  						newBrowser selectedClassOrMetaClassName , ')'.
  			newBrowser.].!

Item was changed:
  ----- Method: Browser>>classHierarchy (in category 'multi-window support') -----
  classHierarchy
  	| behavior newBrowser |
  	(behavior := self selectedClassOrMetaClass) isNil ifTrue:
  		[^self].
  
  	(self isPackage "PackageBrowser pains can't support a hierarchy browser; not sure why."
  	 or: [multiWindowState isNil]) ifTrue:
  		[^super classHierarchy].
  
  	(newBrowser := HierarchyBrowser new initHierarchyForClass: behavior)
  		messageCategoryListIndex: messageCategoryListIndex;
+ 		selectMessageNamed: self selectedMessageName;
- 		messageListIndex: messageListIndex;
  		editSelection: editSelection.
  
  	multiWindowState addWindow: newBrowser
  !

Item was changed:
  ----- Method: Browser>>removeMessage (in category 'message functions') -----
  removeMessage
  	"If a message is selected, create a Confirmer so the user can verify that  
  	the currently selected message should be removed from the system. If 
  	so,  
  	remove it. If the Preference 'confirmMethodRemoves' is set to false, the 
  	confirmer is bypassed."
  	| messageName confirmation |
+ 	self hasMessageSelected not
- 	messageListIndex = 0
  		ifTrue: [^ self].
  	self okToChange
  		ifFalse: [^ self].
  	messageName := self selectedMessageName.
  	confirmation := self systemNavigation   confirmRemovalOf: messageName on: self selectedClassOrMetaClass.
  	confirmation = 3
  		ifTrue: [^ self].
  	self selectedClassOrMetaClass removeSelector: messageName.
+ 	self selectMessageNamed: nil.
- 	self messageListIndex: 0.
  	self changed: #messageList.
  	self setClassOrganizer.
  	"In case organization not cached"
  	confirmation = 2
  		ifTrue: [self systemNavigation browseAllCallsOn: messageName]!

Item was changed:
  ----- Method: FileContentsBrowser>>browseSenders (in category 'other') -----
  browseSenders
  	"Create and schedule a message set browser on all senders of the 
  	currently selected message selector. Do nothing if no message is selected."
  
+ 	self hasMessageSelected 
- 	messageListIndex ~= 0 
  		ifTrue: [self systemNavigation browseAllCallsOn: self selectedMessageName]!

Item was changed:
  ----- Method: FileContentsBrowser>>removeMessage (in category 'removing') -----
  removeMessage
  	| messageName |
+ 	self hasMessageSelected
+ 		ifFalse: [^ self].
- 	messageListIndex = 0
- 		ifTrue: [^ self].
  	self okToChange
  		ifFalse: [^ self].
  	messageName := self selectedMessageName.
  	(self selectedClass confirmRemovalOf: messageName)
  		ifFalse: [^ false].
  	self selectedClassOrMetaClass removeMethod: self selectedMessageName.
+ 	self selectMessageNamed: nil.
- 	self messageListIndex: 0.
  	self setClassOrganizer.
  	"In case organization not cached"
  	self changed: #messageList!

Item was changed:
  ----- Method: MessageSet>>removeMessage (in category 'message functions') -----
  removeMessage
  	"Remove the selected message from the system. 1/15/96 sw"
  	| messageName confirmation |
+ 	self hasMessageSelected
+ 		ifFalse: [^ self].
- 	messageListIndex = 0
- 		ifTrue: [^ self].
  	self okToChange
  		ifFalse: [^ self].
  	messageName := self selectedMessageName.
  	confirmation := self systemNavigation  confirmRemovalOf: messageName on: self selectedClassOrMetaClass.
  	confirmation = 3
  		ifTrue: [^ self].
  	self selectedClassOrMetaClass removeSelector: messageName.
  	self deleteFromMessageList: self selection.
  	self reformulateList.
  	confirmation = 2
  		ifTrue: [self systemNavigation browseAllCallsOn: messageName]!



More information about the Packages mailing list