[Pkg] The Trunk: HelpSystem-Core-ul.55.mcz

[commits at source.squeak.org]

Levente Uzonyi uploaded a new version of HelpSystem-Core to project The Trunk:
http://source.squeak.org/trunk/HelpSystem-Core-ul.55.mcz

==================== Summary ====================

Name: HelpSystem-Core-ul.55
Author: ul
Time: 30 April 2011, 3:46:54.613 am
UUID: c08fa36e-76fb-f54a-8747-356b8be3e315
Ancestors: HelpSystem-Core-tbn.54

- avoid possible speed degradation for large APIs
- minor refactoring for cleaner and faster code

=============== Diff against HelpSystem-Core-tbn.54 ===============

Item was changed:
  ----- Method: ClassAPIHelpBuilder>>build (in category 'building') -----
  build
  
+ 	CurrentReadOnlySourceFiles cacheDuring: [
+ 		topicToBuild := (HelpTopic named: rootToBuildFrom name).
+ 		topicToBuild icon: (HelpIcons iconNamed: #pageIcon).
+ 		topicToBuild contents: rootToBuildFrom comment.
- 	| instanceSide classSide |
- 	topicToBuild := (HelpTopic named: rootToBuildFrom name).
- 	topicToBuild icon: (HelpIcons iconNamed: #pageIcon).
- 	topicToBuild contents: rootToBuildFrom comment.
  	
+ 		addMethods ifTrue: [ self buildSubnodesForMethods ].
+ 		addSubclasses	 ifTrue: [ self buildSubnodesForSubclasses ] ].
- 	addMethods ifTrue: [ self buildSubnodesForMethods ].
- 	addSubclasses	 ifTrue: [ self buildSubnodesForSubclasses ].
  	 !

Item was changed:
  ----- Method: ClassAPIHelpBuilder>>buildMethodTopicsOn:for: (in category 'private building') -----
  buildMethodTopicsOn: topic for: aClass
- 	|stream comments methodComment|
- 	stream := String new writeStream.
- 	aClass selectors asSortedCollection do:
- 			[:selector | 		
- 			  stream 
- 				 nextPutAll: aClass name;
- 			    nextPutAll: '>>';
- 			  	 nextPutAll: selector asString;
- 				 cr.		
- 			  comments := aClass commentsAt: selector.
- 			  methodComment := (comments size = 0)
- 									ifTrue: [ 'Method has no comment.' ]
- 									ifFalse: [ comments first ].
- 									
- 			  stream nextPutAll: methodComment;cr;cr.
- 	].
- 	topic contents: stream contents.
  	
+ 	topic contents: (String streamContents: [ :stream |
+ 		aClass selectors sort do: [ :selector |
+ 			stream 
+ 				nextPutAll: aClass name;
+ 				nextPutAll: '>>';
+ 				nextPutAll: selector asString;
+ 				cr;
+ 				nextPutAll: (
+ 					(aClass commentsAt: selector)
+ 						at: 1
+ 						ifAbsent: [ 'Method has no comment.' ]);
+ 				cr; cr ] ])!
- 	!