[Pkg] The Trunk: SMLoader-cmm.73.mcz
commits at source.squeak.org
commits at source.squeak.org
Sat Feb 12 22:52:19 UTC 2011
Chris Muller uploaded a new version of SMLoader to project The Trunk:
http://source.squeak.org/trunk/SMLoader-cmm.73.mcz
==================== Summary ====================
Name: SMLoader-cmm.73
Author: cmm
Time: 12 February 2011, 4:52:02.294 pm
UUID: 212e9095-b3d2-4a79-9d1b-3253ca86257d
Ancestors: SMLoader-cmm.72
- Disallow '+' in version names because it's reserved by HTTP.
=============== Diff against SMLoader-cmm.72 ===============
Item was changed:
----- Method: SMReleaseBrowser>>save (in category 'initialize-release') -----
save
"Save the release to SqueakMap."
- self validateCanSave.
Cursor wait showWhile:
[ self dependents do:
[ : eachWidget | #(#username #password #note #version #content ) do:
[ : eachName | eachWidget knownName = eachName ifTrue:
[ eachWidget hasUnacceptedEdits ifTrue: [ eachWidget accept ] ] ] ].
+ self validateCanSave.
[ self
writeInstallFile ;
login.
"Save without a downloadUrl so that SM will update its cache and we can also verify success before uploading the file."
self savePackageRelease: nil.
self loadScript isEmptyOrNil ifFalse:
[ self uploadInstallFile.
release package addRelease: release.
"Now save with the correct downloadUrl."
self
savePackageRelease: self downloadUrl ;
deleteInstallFile ] ] ensure: [ self logout ] ].
self closeWindow!
Item was changed:
+ ----- Method: SMReleaseBrowser>>validateCanSave (in category 'private') -----
- ----- Method: SMReleaseBrowser>>validateCanSave (in category 'initialize-release') -----
validateCanSave
+ self username isEmptyOrNil ifTrue: [ self userError: 'username required' ].
+ self note isEmptyOrNil ifTrue: [ self userError: 'note required' ].
- self username isEmptyOrNil
- ifTrue: [self userError: 'username required'].
- self note isEmptyOrNil
- ifTrue: [self userError: 'note required'].
self version isEmptyOrNil
+ ifTrue: [ self userError: 'version required' ]
+ ifFalse:
+ [ (self version includes: $+) ifTrue: [ self userError: 'Plus sign not allowed in version name because it is reserved by HTTP.' ] ]!
- ifTrue: [self userError: 'version required']!
More information about the Packages
mailing list