[Pkg] The Trunk: Tools-nice.303.mcz

[commits at source.squeak.org]

Nicolas Cellier uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-nice.303.mcz

==================== Summary ====================

Name: Tools-nice.303
Author: nice
Time: 30 March 2011, 10:57:43.746 pm
UUID: d9673fd5-327b-ae4c-ab27-25f055a80463
Ancestors: Tools-nice.302

minor ifNil refactoring (Cuis)

=============== Diff against Tools-nice.302 ===============

Item was changed:
  ----- Method: Browser>>toggleBreakOnEntry (in category 'breakpoints') -----
  toggleBreakOnEntry
  	"Install or uninstall a halt-on-entry breakpoint"
  
  	| selectedMethod |
+ 	self selectedClassOrMetaClass ifNil: [ ^self].
- 	self selectedClassOrMetaClass isNil ifTrue:[^self].
  	selectedMethod := self selectedClassOrMetaClass >> self selectedMessageName.
  	selectedMethod hasBreakpoint
  		ifTrue:
  			[BreakpointManager unInstall: selectedMethod]
  		ifFalse:
  			[BreakpointManager 
  				installInClass: self selectedClassOrMetaClass
  				selector: self selectedMessageName].
+ 	self changed: #messageList!
- 	self changed: #messageList
- 		!

Item was changed:
  ----- Method: Debugger>>toggleBreakOnEntry (in category 'breakpoints') -----
  toggleBreakOnEntry
  	"Install or uninstall a halt-on-entry breakpoint"
  
  	| selectedMethod |
+ 	self selectedClassOrMetaClass ifNil: [ ^self].
- 	self selectedClassOrMetaClass isNil ifTrue:[^self].
  	selectedMethod := self selectedClassOrMetaClass >> self selectedMessageName.
  	selectedMethod hasBreakpoint
  		ifTrue:
  			[BreakpointManager unInstall: selectedMethod]
  		ifFalse:
  			[BreakpointManager 
  				installInClass: self selectedClassOrMetaClass
  				selector: self selectedMessageName].!

Item was changed:
  ----- Method: FileContentsBrowser>>infoString (in category 'infoView') -----
  infoString
+ 	^infoString ifNil: [infoString := StringHolder new]!
- 	^infoString isNil
- 		ifTrue:[infoString := StringHolder new]
- 		ifFalse:[infoString]!

Item was changed:
  ----- Method: FileContentsBrowser>>removeUnmodifiedClasses (in category 'removing') -----
  removeUnmodifiedClasses
  	| packageList |
  	self okToChange ifFalse:[^self].
+ 	packageList := self selectedPackage
+ 						ifNil: [ self packages] 
+ 						ifNotNil: [ Array with: self selectedPackage].
- 	packageList := self selectedPackage isNil
- 						ifTrue:[self packages] 
- 						ifFalse:[Array with: self selectedPackage].
  	packageList do:[:package|
  		package classes copy do:[:theClass|
  			Cursor wait showWhile:[
  				theClass removeAllUnmodified.
  			].
  			theClass hasChanges ifFalse:[
  				package removeClass: theClass.
  			].
  		]].
  	self classListIndex: 0.
+ 	self changed: #classList!
- 	self changed: #classList.!

Item was changed:
  ----- Method: FileContentsBrowser>>removeUnmodifiedMethods (in category 'removing') -----
  removeUnmodifiedMethods
  	| theClass cat |
  	self okToChange ifFalse:[^self].
  	theClass := self selectedClassOrMetaClass.
+ 	theClass ifNil: [ ^self].
- 	theClass isNil ifTrue:[^self].
  	cat := self selectedMessageCategoryName.
+ 	cat ifNil: [ ^self].
- 	cat isNil ifTrue:[^self].
  	Cursor wait showWhile:[
  		theClass removeUnmodifiedMethods: (theClass organization listAtCategoryNamed: cat).
  	].
  	self messageListIndex: 0.
  	self changed: #messageList.!

Item was changed:
  ----- Method: FileList>>isFileSelected (in category 'private') -----
  isFileSelected
  	"return if a file is currently selected"
  
+ 	^ fileName notNil!
- 	^ fileName isNil not!

Item was changed:
  ----- Method: PluggableFileList class>>fileNameSelectedAcceptBlock (in category 'canAcceptBlocks') -----
  fileNameSelectedAcceptBlock
  
+ 	^[:theDirectory :theFileName | theFileName notNil]!
- 	^[:theDirectory :theFileName | theFileName isNil not]!

Item was changed:
  ----- Method: SelectionMenu>>startUpWithCaption:at:allowKeyboard: (in category 'basic control sequence') -----
  startUpWithCaption: captionOrNil at: location allowKeyboard: aBoolean
  	"Overridden to return value returned by manageMarker.  The boolean parameter indicates whether the menu should be given keyboard focus (if in morphic)"
  
  	| index |
  	index := super startUpWithCaption: captionOrNil at: location allowKeyboard: aBoolean.
+ 	(selections isNil or: [(index between: 1 and: selections size) not])
- 	(selections = nil or: [(index between: 1 and: selections size) not])
  		ifTrue: [^ nil].
  	^ selections at: index!