[Pkg] The Trunk: Compiler-nice.222.mcz

commits at source.squeak.org commits at source.squeak.org
Sun Nov 20 20:56:31 UTC 2011

Nicolas Cellier uploaded a new version of Compiler to project The Trunk:

==================== Summary ====================

Name: Compiler-nice.222
Author: nice
Time: 20 November 2011, 9:56:07.638 pm
UUID: 32e53e56-3fa4-46f0-9f90-59f92b3a19ba
Ancestors: Compiler-ul.221

Correct a potential bug: there is no reason to initialize the Encoder literalStream with a ReadStream since it's always used as a WriteStream.

I don't have a test case for this, but Martin McClure encoutered some problems with this method in Pharo.

=============== Diff against Compiler-ul.221 ===============

Item was changed:
  ----- Method: Encoder>>temps:literals:class: (in category 'initialize-release') -----
  temps: tempVars literals: lits class: cl 
+ 	"Initialize this encoder for decompilation."
- 	"Decompile."
  	supered := false.
  	class := cl.
  	nTemps := tempVars size.
  	tempVars do: [:node | scopeTable at: node name put: node].
+ 	literalStream := WriteStream on: (Array new: lits size).
+ 	literalStream nextPutAll: lits.
- 	literalStream := ReadStream on: lits.
- 	literalStream position: lits size.
  	sourceRanges := Dictionary new: 32.
+ 	globalSourceRanges := OrderedCollection new: 32.!
- 	globalSourceRanges := OrderedCollection new: 32.
- !

More information about the Packages mailing list