[Pkg] The Trunk: Tests-nice.145.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Feb 22 21:16:24 UTC 2012


Nicolas Cellier uploaded a new version of Tests to project The Trunk:
http://source.squeak.org/trunk/Tests-nice.145.mcz

==================== Summary ====================

Name: Tests-nice.145
Author: nice
Time: 22 February 2012, 10:15:52.226 pm
UUID: 3ee328b5-5eae-4302-99b6-06e2a501e851
Ancestors: Tests-nice.144

1) Register the 4 CompilerNotifyingTest that insert Compiler notifications at wong place as expectedFailures because this is kind of wishful testing.
Indeed, these notifications are not emitted immediately during parsing/scanning phase but rather during transformation of the AST (inlining) or during encoding phase, when positional infomation might exist, but not in a handy form. 
2) Remove CompilerNotifyingTest>>testTooManyTemporaries because the Closure Compiler raise other Errors before notification get a chance to occur.
3) Correct CompilerNotifyingTest>>testAlltogether whose specification was missing a sub-selection separator.

The CompilerNotifyingTest are now green.

=============== Diff against Tests-nice.144 ===============

Item was added:
+ ----- Method: CompilerNotifyingTest>>expectedFailures (in category 'accessing') -----
+ expectedFailures
+ 	"For these tests, the Compiler does not insert the notification where it would be most informative."
+ 	
+ 	^#(
+ 		"Notifying before the literal (which can be a message send) would be more informative"
+ 		testTooManyLiterals
+ 		
+ 		"Notifying right before the 16th argument would be informative"
+ 		testTooManyArguments
+ 		
+ 		"Notifying before the extraneous argument in the right block woul be useful"
+ 		testifTrueBlockWithArgument  testCaseOtherwiseBlockWithArgument
+ 		)!

Item was changed:
  ----- Method: CompilerNotifyingTest>>testAlltogether (in category 'testing') -----
  testAlltogether
  	"Initialize for all known error conditions.
  	Note that the chunk to be evaluated are separated by %, and expected errors enclosed in back quotes."
  	
  	self setUpForErrorsIn: '  "First, the senders of #offEnd:"
  #` Unmatched bracket ->`[ 1 2 %
  #[ 1 2 ` 8-bit integer or right bracket expected ->`256 4]%
  $` A Character was expected ->`%
  1+2   ` Unmatched comment quote ->`"unfinished comment%
  #` Unmatched parenthesis ->`( 1 2%
  #` Unmatched parenthesis ->`( 1 2 %
  ^nil printString ,  ` Unmatched string quote ->`''unfinished string%
  	"Then, the senders of #expected:"
  2r` a digit between 0 and 1 expected ->`3%
  | x | x := ` Expression expected ->`%
  [ :x : ` Argument name expected ->`1]%
  [ :x ` Vertical bar expected ->`x + 1 ]%
  [:x | 1 ` Period or right bracket expected ->`( 1 ) ]%
  { 1. 2` Period or right brace expected ->`%
  { 1. 2 ` Period or right brace expected ->`%
  { 1. 2 ` Period or right brace expected ->`3 %
  { 1. 2. ` Variable or expression expected ->`| x | %
+ super yourself` Cascading not expected ->`; yourself%
- super yourself` Cascading not expected ->`; yourself
  nil yourself; ` Cascade expected ->`^ 2%
  	"#externalFunctionDeclaration is skipped, this cannot be evaluated"
  1 to: ` Argument expected ->`:=%
  1 +` Argument expected ->`%
  1 + ` Argument expected ->`* 2 + 3%
  1+(2 ` right parenthesis expected ->`.  %
  1 + 2 ` Nothing more expected ->`^nil%
  	"#pattern:inContext: skipped, cannot be evaluated"
  	"#pragmaLiteral: #pragmaSequence #pragmaStatement skipped, cannot be evaluated"
  (  ` expression expected ->`. 2  . )%
  ( 1  ` right parenthesis expected ->`. 2  . )%
  	"#primitive:error: #primitive:module:error: skipped, cannot be evaluated"
  ^ ` Expression to return expected ->`. 1 + 2%
  [ ^1 ` End of block expected ->`2]%
  | x y ` Vertical bar expected ->`%
  [:z | | x y ` Vertical bar expected ->`]%
  1` an integer greater than 1 as valid radix expected ->`r0'.
  	self enumerateAllSelections!

Item was changed:
  ----- Method: CompilerNotifyingTest>>testTooManyTemporaries (in category 'testing-byteCode limits') -----
  testTooManyTemporaries
+ 	"Nope, with Closure Compiler, an Error is raised before the Encoder has a chance to notify"!
- 	self setUpForErrorsIn: '| x1 x2 x3 x4 x5 x6 x7 x8 x9 x10 x11 x12 x13 x14 x15 x16 x17 x18 x19 x20 x21 x22 x23 x24 x25 x26 x27 x28 x29 x30 x31 x32 x33 x34 x35 x36 x37 x38 x39 x40 x41 x42 x43 x44 x45 x46 x47 x48 x49 x50 x51 x52 x53 x54 x55 x56 x57 x58 x59 x60 x61 x62 x63 ` Too many temporaries ->`x64 x65 |
- 	x1 := x2 := x3 := x4 := x5 := x6 := x7 := x8 := x9 := x10 := x11 := x12 := x13 := x14 := x15 := x16 := x17 := x18 := x19 := x20 := x21 := x22 := x23 := x24 := x25 := x26 := x27 := x28 := x29 := x30 := x31 := x32 := x33 := x34 := x35 := x36 := x37 := x38 := x39 := x40 := x41 := x42 := x43 := x44 := x45 := x46 := x47 := x48 := x49 := x50 := x51 := x52 := x53 := x54 := x55 := x56 := x57 := x58 := x59 := x60 := x61 := x62 := x63 := x64 := x65 := 0.
- 	{x1. x2. x3. x4. x5. x6. x7. x8. x9. x10. x11. x12. x13. x14. x15. x16. x17. x18. x19. x20. x21. x22. x23. x24. x25. x26. x27. x28. x29. x30. x31. x32. x33. x34. x35. x36. x37. x38. x39. x40. x41. x42. x43. x44. x45. x46. x47. x48. x49. x50. x51. x52. x53. x54. x55. x56. x57. x58. x59. x60. x61. x62. x63. x64. x65}'.
- 	self enumerateAllSelections.!



More information about the Packages mailing list