[Pkg] The Trunk: System-fbs.634.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Dec 6 20:36:53 UTC 2013

Frank Shearar uploaded a new version of System to project The Trunk:

==================== Summary ====================

Name: System-fbs.634
Author: fbs
Time: 6 December 2013, 8:36:08.84 pm
UUID: 18ae1969-821b-5945-b9cc-46109800ebc0
Ancestors: System-fbs.633

If you want to know what kind of Browser to use, ask the AppRegistry that knows - SystemBrowser.

Also, the old #browseThemes implementation (a) referred directly to Browser, and (b) did almost exactly the usual thing - browsing a method selects the correct category, and just the label changes. Not worth extending ToolSet's API for such a small use case.

=============== Diff against System-fbs.633 ===============

Item was changed:
  ----- Method: Preferences class>>browseThemes (in category 'misc') -----
  	"Open up a message-category browser on the theme-defining methods"
+ 	ToolSet browse: Preferences class selector: #outOfTheBox.!
- 	| aBrowser |
- 	aBrowser := Browser new setClass: Preferences class selector: #outOfTheBox.
- 	aBrowser messageCategoryListIndex: ((Preferences class organization categories indexOf: 'themes' ifAbsent: [^ self inform: 'no themes found']) + 1).
- 	Browser openBrowserView: (aBrowser openMessageCatEditString: nil)
- 		label: 'Preference themes'
- 	"Preferences browseThemes"!

Item was removed:
- ----- Method: Preferences class>>browseToolClass (in category 'hard-coded prefs') -----
- browseToolClass
- 	"This method is used for returning the appropiate class for the #browserShowsPackagePane preference. Now that preference modifies the registry so here we query directly to the registry"
- 	^ SystemBrowser default.!

More information about the Packages mailing list