[Pkg] The Trunk: Tools-nice.498.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Sep 20 19:43:18 UTC 2013


Nicolas Cellier uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-nice.498.mcz

==================== Summary ====================

Name: Tools-nice.498
Author: nice
Time: 20 September 2013, 9:42:31.285 pm
UUID: d5aa8306-8e71-42a3-ad1a-b9294d6f0f06
Ancestors: Tools-nice.497

A SyntaxError does not really need to display a category, this little feature has big complexity costs that we want to trade.

=============== Diff against Tools-nice.497 ===============

Item was changed:
  SystemOrganization addCategory: #'Tools-ArchiveViewer'!
  SystemOrganization addCategory: #'Tools-Base'!
  SystemOrganization addCategory: #'Tools-Browser'!
  SystemOrganization addCategory: #'Tools-Changes'!
  SystemOrganization addCategory: #'Tools-Debugger'!
  SystemOrganization addCategory: #'Tools-Explorer'!
  SystemOrganization addCategory: #'Tools-File Contents Browser'!
  SystemOrganization addCategory: #'Tools-FileList'!
  SystemOrganization addCategory: #'Tools-Inspector'!
  SystemOrganization addCategory: #'Tools-Menus'!
  SystemOrganization addCategory: #'Tools-Process Browser'!
  SystemOrganization addCategory: #'Tools-MethodFinder'!
+ SystemOrganization addCategory: #'Tools-CommandLine'!

Item was changed:
  StringHolder subclass: #SyntaxError
+ 	instanceVariableNames: 'class selector debugger notification'
- 	instanceVariableNames: 'class selector category debugger notification'
  	classVariableNames: ''
  	poolDictionaries: ''
  	category: 'Tools-Debugger'!
  
  !SyntaxError commentStamp: '<historical>' prior: 0!
  I represent syntax error report for syntax errors encountered when filing in class descriptions from a non-interactive source such as an external file. As a StringHolder, the string to be viewed is the method code or expression containing the error.
  
  The user may fix the error and accept the method to continue the fileIn.
  !

Item was changed:
  ----- Method: SyntaxError>>list (in category 'message list') -----
  list
+ 	"Answer an array of one element made up of the class name and message selector in which the syntax error was found. This is the single item in the message list of a view/browser on the receiver."
- 	"Answer an array of one element made up of the class name, message category, and message selector in which the syntax error was found. This is the single item in the message list of a view/browser on the receiver."
  
+ 	^ Array with: (class name, '  ', (selector ifNil: ['<none>']))
- 	^ Array with: (class name, '  ', (notification category ifNil: ['<none>']), '  ', (selector ifNil: ['<none>']))
  !

Item was changed:
  ----- Method: SyntaxError>>setNotification: (in category 'accessing') -----
  setNotification: aSyntaxErrorNotification
  
  	| types printables badChar code |
  	notification := aSyntaxErrorNotification.
  	class := aSyntaxErrorNotification errorClass.
  	debugger := Debugger context: aSyntaxErrorNotification signalerContext.
  	code := aSyntaxErrorNotification errorCode.
  	selector := class newParser parseSelector: code.
- 	category := aSyntaxErrorNotification category.
  	types := Scanner classPool at: #TypeTable.	"dictionary"
  	printables := '!!@#$%&*-_=+<>{}?/\,·£¢§¶ªº–—“‘”’…Úæگ׿«»`~`' asSet.
  	badChar := code detect: [:aChar | (types at: aChar asciiValue ifAbsent: [#xLetter]) == #xBinary and: [
  			(printables includes: aChar) not]] ifNone: [nil].
  	contents := badChar 
  		ifNil: [code]
  		ifNotNil: ['<<<This string contains a character (ascii value ', 
  			badChar asciiValue printString,
+ 			') that is not normally used in code>>> ', code].!
- 			') that is not normally used in code>>> ', code].
- 	category ifNil: [category := class organization categoryOfElement: selector].
- 	category ifNil: [category := ClassOrganizer default].!



More information about the Packages mailing list