[Pkg] The Trunk: Tools-fbs.499.mcz

[commits at source.squeak.org]

Frank Shearar uploaded a new version of Tools to project The Trunk:
http://source.squeak.org/trunk/Tools-fbs.499.mcz

==================== Summary ====================

Name: Tools-fbs.499
Author: fbs
Time: 24 September 2013, 10:21:46.681 pm
UUID: 7de58629-3d96-7f48-9c78-25f16a8b8ad9
Ancestors: Tools-nice.498

Make Tools use RecentMessages.

=============== Diff against Tools-nice.498 ===============

Item was changed:
  SystemOrganization addCategory: #'Tools-ArchiveViewer'!
  SystemOrganization addCategory: #'Tools-Base'!
  SystemOrganization addCategory: #'Tools-Browser'!
  SystemOrganization addCategory: #'Tools-Changes'!
  SystemOrganization addCategory: #'Tools-Debugger'!
  SystemOrganization addCategory: #'Tools-Explorer'!
  SystemOrganization addCategory: #'Tools-File Contents Browser'!
  SystemOrganization addCategory: #'Tools-FileList'!
  SystemOrganization addCategory: #'Tools-Inspector'!
  SystemOrganization addCategory: #'Tools-Menus'!
  SystemOrganization addCategory: #'Tools-Process Browser'!
  SystemOrganization addCategory: #'Tools-MethodFinder'!
- SystemOrganization addCategory: #'Tools-CommandLine'!

Item was changed:
  MessageSet subclass: #RecentMessageSet
  	instanceVariableNames: ''
+ 	classVariableNames: 'NumberOfRecentSubmissionsToStore'
- 	classVariableNames: ''
  	poolDictionaries: ''
  	category: 'Tools-Browser'!
  
  !RecentMessageSet commentStamp: 'sw 8/1/2002 17:40' prior: 0!
  RecentMessageSet is a message set that shows the most recently-submitted methods, in chronological order.!

Item was added:
+ ----- Method: RecentMessageSet class>>numberOfRecentSubmissionsToStore (in category 'preferences') -----
+ numberOfRecentSubmissionsToStore
+ 	<preference: 'Number of recent submissions to store'
+ 		category: 'Tools'
+ 		description: 'Answer how many methods back the ''recent method submissions'' history should store'
+ 		type: #Number>
+ 	^NumberOfRecentSubmissionsToStore
+ 		ifNil: [NumberOfRecentSubmissionsToStore := 30].!

Item was changed:
  ----- Method: RecentMessageSet>>addExtraShiftedItemsTo: (in category 'message list') -----
  addExtraShiftedItemsTo: aMenu
  	"The shifted selector-list menu is being built.  Overridden here to defeat the presence of the items that add or change order, since RecentMessageSet defines methods & order explicitly based on external criteria"
  
+ 	aMenu add: 'set size of recent history...' target: RecentMessages action: #setRecentHistorySize!
- 	aMenu add: 'set size of recent history...' action: #setRecentHistorySize!

Item was changed:
  ----- Method: RecentMessageSet>>reformulateList (in category 'update') -----
  reformulateList
  	| myList |
  	"Reformulate the receiver's list.  Exclude methods now deleted"
  
+ 	myList := RecentMessages default methodReferences reversed select: [ :each | each isValid].
- 	myList := Utilities recentMethodSubmissions reversed select: [ :each | each isValid].
  	self initializeMessageList: myList.
  	self messageListIndex: (messageList size min: 1).	"0 or 1"
  	self changed: #messageList.
  	self changed: #messageListIndex!

Item was changed:
  ----- Method: RecentMessageSet>>removeFromRecentSubmissions (in category 'message functions') -----
  removeFromRecentSubmissions
+ 	"Remove the currently-selected method from the RecentMessages list"
- 	"Remove the currently-selected method from the RecentSubmissions list"
  
  	| aClass methodSym |
  	((aClass := self selectedClassOrMetaClass) notNil and: [(methodSym := self selectedMessageName) notNil])
  		ifTrue: 
+ 			[RecentMessages default purgeFromRecentSubmissions: (MethodReference class: aClass selector: methodSym).
- 			[Utilities purgeFromRecentSubmissions: (MethodReference class: aClass selector: methodSym).
  			self reformulateList]!

Item was changed:
  ----- Method: RecentMessageSet>>setRecentHistorySize (in category 'message list') -----
  setRecentHistorySize
  	"Let the user specify the recent history size"
  
  	| aReply aNumber |
  	aReply := UIManager default request: 'How many recent methods
+ should be maintained?' initialAnswer: RecentMessages numberOfRecentSubmissionsToStore asString.
- should be maintained?' initialAnswer: Utilities numberOfRecentSubmissionsToStore asString.
  	aReply isEmptyOrNil ifFalse:
  		[aNumber := aReply asNumber rounded.
  		(aNumber > 1 and: [aNumber <= 1000])
  			ifTrue:
+ 				[RecentMessages numberOfRecentSubmissionsToStore: aNumber.
- 				[Utilities numberOfRecentSubmissionsToStore: aNumber.
  				self inform: 'Okay, ', aNumber asString, ' is the new size of the recent method history']
  			ifFalse:
+ 				[self inform: 'Sorry, must be a number between 2 & 1000']]!
- 				[self inform: 'Sorry, must be a number between 2 & 1000']]
- 			!

Item was changed:
  ----- Method: RecentMessageSet>>updateListsAndCodeIn: (in category 'update') -----
  updateListsAndCodeIn: aWindow
  
  	| recentFromUtilities |
  	"RAA 20 june 2000 - a recent change to how messages were displayed in the list caused them not to match what was stored in Utilities. This caused the recent submissions to be continuously updated. The hack below fixed that problem"
  
  	self flag: #mref.	"in second pass, use simpler test"
  
  	self canDiscardEdits ifFalse: [^ self].
+ 	recentFromUtilities := RecentMessages default mostRecent asString,' '.
- 	recentFromUtilities := Utilities mostRecentlySubmittedMessage,' '.
  	(messageList first asStringOrText asString beginsWith: recentFromUtilities)
  		ifFalse:
  			[self reformulateList]
  		ifTrue:
  			[self updateCodePaneIfNeeded]!

Item was changed:
  ----- Method: Utilities class>>browseRecentSubmissions (in category '*Tools') -----
  browseRecentSubmissions
  	"Open up a browser on the most recent methods submitted in the image.  5/96 sw."
  
  	"Utilities browseRecentSubmissions"
  
  	| recentMessages |
  
+ 	RecentMessages default isEmpty ifTrue:
- 	self recentMethodSubmissions size = 0 ifTrue:
  		[^ self inform: 'There are no recent submissions'].
  	
+ 	recentMessages := RecentMessages default methodReferences reversed.
+ 	^ RecentMessageSet 
+ 		openMessageList: recentMessages
- 	recentMessages := RecentSubmissions copy reversed.
- 	RecentMessageSet 
- 		openMessageList: recentMessages 
  		name: 'Recent submissions -- youngest first ' 
+ 		autoSelect: nil.!
- 		autoSelect: nil!

Item was changed:
  ----- Method: Utilities class>>recentSubmissionsWindow (in category '*Tools') -----
  recentSubmissionsWindow
  	"Answer a SystemWindow holding recent submissions"
  
  	| recentMessages messageSet |
+ 	recentMessages := RecentMessages default methodReferences reversed.
- 	recentMessages := RecentSubmissions copy reversed.
  	messageSet := RecentMessageSet messageList: recentMessages.
  	messageSet autoSelectString: nil.
  	^ ToolBuilder build: messageSet
  
  	"Utilities recentSubmissionsWindow openInHand"
  
  !