[Pkg] The Trunk: CollectionsTests-dtl.211.mcz

[commits at source.squeak.org]

David T. Lewis uploaded a new version of CollectionsTests to project The Trunk:
http://source.squeak.org/trunk/CollectionsTests-dtl.211.mcz

==================== Summary ====================

Name: CollectionsTests-dtl.211
Author: dtl
Time: 6 January 2014, 6:24:37.996 pm
UUID: 2b18d5e2-5b7e-4dc9-bc0c-b5565614dec2
Ancestors: CollectionsTests-dtl.210

Test TextFontReference with a TTCFont specification. This introduces a new failure, because TextFontReference was designed to work with StrikeFont and is not able to uniquely specify a TTCFont.

=============== Diff against CollectionsTests-dtl.210 ===============

Item was changed:
  ----- Method: TextAttributesScanningTest>>testTextFontReference (in category 'testing') -----
  testTextFontReference
+ 	"Test TextFontReference with a StrikeFont"
  	| font att strm identifierCharacter fontReferenceString att3 |
  	font := StrikeFont someInstance.
  	att := TextFontReference toFont: font.
  	strm := ReadWriteStream on: ''.
  	att writeScanOn: strm.
  	strm reset.
  	identifierCharacter := strm next.
  	self assert: $F equals: identifierCharacter.
  	fontReferenceString := strm upToEnd.
  	self assert: font familyName, '#', font height equals: fontReferenceString.
  	self assert: TextFontReference equals: (TextAttribute classFor: $F).
  	strm reset.
  	att3 := TextAttribute newFrom: strm.
  	self assert: att equals: att3.
  !

Item was added:
+ ----- Method: TextAttributesScanningTest>>testTextFontReferenceTTC (in category 'testing') -----
+ testTextFontReferenceTTC
+ 	"n.b. A TextFontReference specifies font height only, which is not sufficient
+ 	to identify a unique TTCFont. Here we test only that the font height of the
+ 	selected font matches the TextFontReference specification."
+ 
+ 	"(self selector: #testTextFontReferenceTTC) debug"
+ 
+ 	"Test TextFontReference with a TTCFont"
+ 	| font att strm identifierCharacter fontReferenceString att3 |
+ 	font := TTCFont someInstance.
+ 	att := TextFontReference toFont: font.
+ 	strm := ReadWriteStream on: ''.
+ 	att writeScanOn: strm.
+ 	strm reset.
+ 	identifierCharacter := strm next.
+ 	self assert: $F equals: identifierCharacter.
+ 	fontReferenceString := strm upToEnd.
+ 	self assert: font familyName, '#', font height equals: fontReferenceString.
+ 	self assert: TextFontReference equals: (TextAttribute classFor: $F).
+ 	strm reset.
+ 	att3 := TextAttribute newFrom: strm.
+ 	"test font height only, see comment above"
+ 	self assert: att font height equals: att3 font height.
+ 	"we really want an exact match, which probably requires different implentation of TextFontReference"
+ 	self assert: att equals: att3.
+ !