[Pkg] The Trunk: Morphic-cmm.721.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Mar 7 17:01:07 UTC 2014


Chris Muller uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-cmm.721.mcz

==================== Summary ====================

Name: Morphic-cmm.721
Author: cmm
Time: 7 March 2014, 10:59:11.347 am
UUID: de79188f-637e-4ccd-9ef2-1b9b39f6de21
Ancestors: Morphic-cmm.720

It's not necessary to use a random pause for smart-splitters, I never noticed any patternistic emergence, but the call to atRandom from Morphic did result in an image lockup once when there was a lock on Collection class' #mutexForPicking.

=============== Diff against Morphic-cmm.720 ===============

Item was changed:
  ----- Method: ProportionalSplitterMorph>>stepTime (in category 'events') -----
  stepTime
  	"When a splitter finds itself in the right place, let it rest for about 3 seconds to avoid performance impacts of constant, rapid stepping."
  	| pause |
+ 	pause := 3000. "Frozen image when atRandom failed due to lock on its Mutex."
- 	pause := (2900 to: 3100) atRandom "to discourage any patternistic emergence".
  	^ ({#(1 -1 1 ).  #(-1 1 -1 )} includes: self movements asArray)
  		ifTrue: [ pause "don't twitch" ]
  		ifFalse:
  			[ splitsTopAndBottom
  				ifTrue:
  					[ self topBottomCorrection isZero
  						ifTrue: [ pause ]
  						ifFalse: [ 0 ] ]
  				ifFalse:
  					[ self leftRightImbalance abs > 1
  						ifTrue: [ ">1 rather than 0 to discourage one-off twitching"
  							0 ]
  						ifFalse: [ pause ] ] ]!



More information about the Packages mailing list