[Pkg] The Trunk: Monticello-cmm.616.mcz

commits at source.squeak.org commits at source.squeak.org
Tue May 19 02:01:27 UTC 2015


Chris Muller uploaded a new version of Monticello to project The Trunk:
http://source.squeak.org/trunk/Monticello-cmm.616.mcz

==================== Summary ====================

Name: Monticello-cmm.616
Author: cmm
Time: 18 May 2015, 9:00:52.601 pm
UUID: 2421b210-91a1-420a-bf0c-1f665533c904
Ancestors: Monticello-mt.615

- Fix potential security hole with clearPasswords and clearPasswordsAndUsers -- renamed them to #clearCredentials so we don't have my initials in the repositories of this release.
- Clarify message about adding historical repository.

=============== Diff against Monticello-mt.615 ===============

Item was changed:
  ----- Method: MCHttpRepository class>>cleanUp: (in category 'class initialization') -----
  cleanUp: aggressive
  	super cleanUp: aggressive.
+ 	aggressive ifTrue: [ self clearCredentials ]!
- 	aggressive ifTrue: [ self clearPasswords ]!

Item was added:
+ ----- Method: MCHttpRepository class>>clearCredentials (in category 'class initialization') -----
+ clearCredentials
+ 	self allSubInstancesDo: [ : each | each clearCredentials ]!

Item was removed:
- ----- Method: MCHttpRepository class>>clearPasswords (in category 'class initialization') -----
- clearPasswords
- 	self allSubInstancesDo: [:ea | ea password: ''].
- !

Item was removed:
- ----- Method: MCHttpRepository class>>clearPasswordsAndUsers (in category 'class initialization') -----
- clearPasswordsAndUsers
- 	self allSubInstancesDo: [:ea | ea user: ''; password: ''].
- !

Item was added:
+ ----- Method: MCHttpRepository>>clearCredentials (in category 'accessing') -----
+ clearCredentials
+ 	user atAllPut: $x.
+ 	password atAllPut: $x.
+ 	user := password := String empty!

Item was changed:
  ----- Method: MCWorkingCopyBrowser class>>mcModelFor: (in category 'hooks') -----
  mcModelFor: aClassOrMethodReference 
  	^ aClassOrMethodReference mcModel ifNil:
+ 		[ | pkgName rep | (UIManager confirm: 'Okay to add historical repository ' , (rep := MCHttpRepository trunkBackup) description , ' to ' , (pkgName := aClassOrMethodReference packageInfo packageName) , '?') ifTrue:
+ 			[ (MCWorkingCopy forPackageNamed: pkgName) repositoryGroup addRepository: rep.
- 		[ | pkgName | (UIManager confirm: 'Okay to add historical repository to ' , (pkgName := aClassOrMethodReference packageInfo packageName) , '?') ifTrue:
- 			[ (MCWorkingCopy forPackageNamed: pkgName) repositoryGroup addRepository: MCHttpRepository trunkBackup.
  			aClassOrMethodReference mcModel ] ]!



More information about the Packages mailing list