[Pkg] The Trunk: Kernel-eem.952.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Sep 16 23:42:32 UTC 2015

Eliot Miranda uploaded a new version of Kernel to project The Trunk:

==================== Summary ====================

Name: Kernel-eem.952
Author: eem
Time: 16 September 2015, 4:42:02.543 pm
UUID: 31ef882e-64d5-4e23-8e4f-d870d3bc0086
Ancestors: Kernel-eem.951

The comparison of the initial literal in plugin primitive methods needs to compare the first two entries, not the first three.

=============== Diff against Kernel-eem.951 ===============

Item was changed:
  ----- Method: CompiledMethod>>= (in category 'comparing') -----
  = method
  	"Answer whether the receiver implements the same code as the argument, method.
  	 Here ``same code'' means that if the receiver's source is compiled with the same
  	 compiler it should produce the same sequence of bytecodes and literals, same
  	 trailer and same properties.  Hence this definition of #= (only one of many plausible
  	 definitions) can be used to quickly identify changes in the compiler's output."
  	| numLits |
  	method isCompiledMethod ifFalse: [^false].
  	self size = method size ifFalse: [^false].
  	self header = method header ifFalse: [^false]. "N.B. includes numLiterals comparison."
  	self initialPC to: self endPC do:
  		[:i | (self at: i) = (method at: i) ifFalse: [^false]].
  	numLits := self numLiterals.
  	1 to: numLits do:
  		[:i| | lit1 lit2 |
  		lit1 := self literalAt: i.
  		lit2 := method literalAt: i.
  		(lit1 == lit2 or: [lit1 literalEqual: lit2]) ifFalse:
  			[(i = 1 and: [#(117 120) includes: self primitive])
  					[lit1 isArray
+ 							[(lit2 isArray and: [(lit1 first: 2) = (lit2 first: 2)]) ifFalse:
- 							[(lit2 isArray and: [lit1 allButLast = lit2 allButLast]) ifFalse:
  						ifFalse: "ExternalLibraryFunction"
  							[(lit1 analogousCodeTo: lit2) ifFalse:
  					[i = (numLits - 1)
  						ifTrue: "properties"
  							[(self properties analogousCodeTo: method properties)
  								ifFalse: [^false]]
  						ifFalse: "last literal (methodClassAssociation) of class-side methods is not unique"
  							[(i = numLits
  							 and: [lit1 isVariableBinding
  							 and: [lit2 isVariableBinding
  							 and: [lit1 key == lit2 key
  							 and: [lit1 value == lit2 value]]]]) ifFalse:

More information about the Packages mailing list