[Pkg] The Trunk: ToolBuilder-Morphic-mt.170.mcz

commits at source.squeak.org commits at source.squeak.org
Sat Jul 23 09:23:42 UTC 2016

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk:

==================== Summary ====================

Name: ToolBuilder-Morphic-mt.170
Author: mt
Time: 23 July 2016, 11:23:30.185969 am
UUID: dd12d103-fc6a-f341-8075-c12e14322142
Ancestors: ToolBuilder-Morphic-mt.169

Action buttons being white was surprising and overridden long time ago in PluggableButtonMorphPlus.

Still, retain the hook to build action buttions. Maybe we can distinguish them in the future like tool buttons distinguish from push buttons in other UI frameworks such as Qt.

=============== Diff against ToolBuilder-Morphic-mt.169 ===============

Item was removed:
- ----- Method: MorphicToolBuilder>>buildPluggableActionButton: (in category 'widgets optional') -----
- buildPluggableActionButton: aSpec
- 	| button |
- 	button := self buildPluggableButton: aSpec.
- 	button color: Color white.
- 	^button!

Item was changed:
  ----- Method: MorphicToolBuilder>>buildPluggableButton: (in category 'widgets required') -----
  buildPluggableButton: aSpec
  	| widget label state action enabled |
  	label := aSpec label.
  	state := aSpec state.
  	action := aSpec action.
  	widget := self buttonClass on: aSpec model
  				getState: (state isSymbol ifTrue:[state])
  				action: nil
  				label: (label isSymbol ifTrue:[label]).
  	widget style: aSpec style.
  	aSpec changeLabelWhen
  		ifNotNilDo: [ :event | widget whenChanged: event update: aSpec label].
  	self register: widget id: aSpec name.
  	enabled := aSpec enabled.
  	enabled isSymbol
  		ifTrue:[widget getEnabledSelector: enabled]
  		ifFalse:[widget enabled:enabled].
  	widget action: action.
  	aSpec color isColor
+ 		ifTrue: [widget offColor: aSpec color]
+ 		ifFalse: [widget getColorSelector: aSpec color].
- 		ifTrue: [widget
- 			onColor: aSpec color
- 			offColor: aSpec color]
- 		ifFalse: [
- 			widget getColorSelector: aSpec color.
- 			widget update: aSpec color].
  	self buildHelpFor: widget spec: aSpec. 
  	(label isSymbol or:[label == nil]) ifFalse:[widget label: label].
  	self setFrame: aSpec frame in: widget.
  	self setLayoutHintsFor: widget spec: aSpec.
  	parent ifNotNil:[self add: widget to: parent].

More information about the Packages mailing list