[Pkg] The Trunk: NetworkTests-pre.50.mcz

commits at source.squeak.org commits at source.squeak.org
Wed Sep 6 17:53:24 UTC 2017


Patrick Rein uploaded a new version of NetworkTests to project The Trunk:
http://source.squeak.org/trunk/NetworkTests-pre.50.mcz

==================== Summary ====================

Name: NetworkTests-pre.50
Author: pre
Time: 6 September 2017, 7:53:00.334204 pm
UUID: b7cc6ccd-9d08-0141-a4d7-b3ad3eaca877
Ancestors: NetworkTests-pre.49

Changes the test case for the logic of the mail address parser to only accept actual lists of email addresses, also adds a test case for parsing out the names in front of email addresses.

=============== Diff against NetworkTests-pre.49 ===============

Item was added:
+ ----- Method: MailAddressParserTest>>stringOfMailAddresses (in category 'fixtures') -----
+ stringOfMailAddresses
+ 	^ 'joe at lama.com, joe2 at lama.com, joe3 at lama.com, joe4 , Not an Address <joe5 at address>, joe.(annoying (nested) comment)literal@[1.2.3.4], "an annoying" group : joe1 at groupie, joe2 at groupie, "Joey3" joe3 at groupy, "joe6"."joe8"@group.com;,  Lex''s email account <lex>, foo+bar at baz.com, romeo&juliet at shakespeare.uk, "Name" mail at email.com'.!

Item was added:
+ ----- Method: MailAddressParserTest>>testAddressesAndNamePairsIn (in category 'tests') -----
+ testAddressesAndNamePairsIn
+ 
+ 	| correctAnswer parsedParis |
+ 
+ 	correctAnswer := #(
+ 		('' 'joe at lama.com') 
+ 		('' 'joe2 at lama.com') 
+ 		('' 'joe3 at lama.com') 
+ 		('' 'joe4')
+ 		('Not an Address' 'joe5 at address') 
+ 		('' 'joe.literal@[1.2.3.4]') 
+ 		('' 'joe1 at groupie') 
+ 		('' 'joe2 at groupie') 
+ 		('Joey3' 'joe3 at groupy') 
+ 		('' '"joe6"."joe8"@group.com')
+ 		('Lex''s email account' 'lex')
+ 		('' 'foo+bar at baz.com')
+ 		('' 'romeo&juliet at shakespeare.uk')
+ 		('Name' 'mail at email.com')) asOrderedCollection.
+ 
+ 	parsedParis := MailAddressParser addressesAndNamePairsIn: self stringOfMailAddresses.
+ 	self assert: correctAnswer equals: parsedParis.!

Item was changed:
  ----- Method: MailAddressParserTest>>testAddressesIn (in category 'tests') -----
  testAddressesIn
  
+ 	| correctAnswer |
- 	| testString correctAnswer |
  
+ 	correctAnswer := #(
+ 		'joe at lama.com' 
+ 		'joe2 at lama.com' 
+ 		'joe3 at lama.com' 
+ 		'joe4' 
+ 		'joe5 at address' 
+ 		'joe.literal@[1.2.3.4]' 
+ 		'joe1 at groupie' 
+ 		'joe2 at groupie' 
+ 		'joe3 at groupy' 
+ 		'"joe6"."joe8"@group.com' 
+ 		'lex' 
+ 		'foo+bar at baz.com' 
+ 		'romeo&juliet at shakespeare.uk'
+ 		'mail at email.com') asOrderedCollection.
- 	testString := 'joe at lama.com, joe2 at lama.com joe3 at lama.com joe4 , Not an Address <joe5 at address>, joe.(annoying (nested) comment)literal@[1.2.3.4], "an annoying" group : joe1 at groupie, joe2 at groupie, "Joey" joe3 at groupy, "joe6"."joe8"@group.com;,  Lex''s email account <lex>, foo+bar at baz.com romeo&juliet at shakespeare.uk'.
  
+ 	self assert: correctAnswer equals: (MailAddressParser addressesIn: self stringOfMailAddresses).!
- correctAnswer := #('joe at lama.com' 'joe2 at lama.com' 'joe3 at lama.com' 'joe4' 'joe5 at address' 'joe.literal@[1.2.3.4]' 'joe1 at groupie' 'joe2 at groupie' '"Joey"' 'joe3 at groupy' '"joe6"."joe8"@group.com' 'lex' 'foo+bar at baz.com' 'romeo&juliet at shakespeare.uk') asOrderedCollection.
- 
- 	self assert: ((MailAddressParser addressesIn: testString) =  correctAnswer).!



More information about the Packages mailing list