[Pkg] The Trunk: CollectionsTests-pre.322.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Oct 4 09:05:49 UTC 2019


Patrick Rein uploaded a new version of CollectionsTests to project The Trunk:
http://source.squeak.org/trunk/CollectionsTests-pre.322.mcz

==================== Summary ====================

Name: CollectionsTests-pre.322
Author: pre
Time: 4 October 2019, 11:05:48.184303 am
UUID: 4bef770f-19b8-de40-9b19-210a16043d23
Ancestors: CollectionsTests-pre.321

Updates the TextAttributesScanningTests to reflect the difference between unused attributes and not fully implemented serialization

=============== Diff against CollectionsTests-pre.321 ===============

Item was changed:
  ----- Method: TextAttributesScanningTest>>expectedFailures (in category 'failures') -----
  expectedFailures
  	"Tests for text attributes that are apparently unused, and that may be candidates
  	for removal from the image"
  	^#(
- 		testTextAnchor
  		testTextIndent
  		testTextMessageLink
  		testTextPlusJumpStart
  		testTextPlusJumpEnd
  		
  		"Actually failing tests which document bugs to be fixed (pre)"
+ 		testTextAnchor "Is actually used but does not have a writeScanOn: implementation"
  		testTextFontReferenceForBoldFont
  		testTextFontReferenceTTCForBoldFont
  		)!

Item was changed:
  ----- Method: TextAttributesScanningTest>>testTextAnchor (in category 'tests') -----
  testTextAnchor
  	| att strm |
  	att := TextAnchor new anchoredMorph: RectangleMorph new initialize.
  	strm := WriteStream on: ''.
  	self assert: (att respondsTo: #writeScanOn:).
+ 	att writeScanOn: strm.
+ 	self assert: strm contents notEmpty.!
- 	att writeScanOn: strm. "FIXME - is TextAnchor used for anything?"
- !

Item was changed:
  ----- Method: TextAttributesScanningTest>>testTextMessageLink (in category 'tests') -----
  testTextMessageLink
  	| att strm |
  	att := TextMessageLink message: Message someInstance.
  	strm := WriteStream on: ''.
  	self assert: (att respondsTo: #writeScanOn:).
  	att writeScanOn: strm. "FIXME - is TextMessageLink used for anything?"
+ 	self assert: strm contents notEmpty.
  !

Item was changed:
  ----- Method: TextAttributesScanningTest>>testTextPlusJumpEnd (in category 'tests') -----
  testTextPlusJumpEnd
  	| att strm |
  	att := TextPlusJumpEnd new jumpLabel: 'this is a jump label'.
  	strm := WriteStream on: ''.
  	self assert: (att respondsTo: #writeScanOn:).
  	att writeScanOn: strm. "FIXME - is TextPlusJumpEnd used for anything?"
+ 	self assert: strm contents notEmpty.!
- !

Item was changed:
  ----- Method: TextAttributesScanningTest>>testTextPlusJumpStart (in category 'tests') -----
  testTextPlusJumpStart
  	| att strm |
  	att := TextPlusJumpStart new jumpLabel: 'this is a jump label'.
  	strm := WriteStream on: ''.
  	self assert: (att respondsTo: #writeScanOn:).
  	att writeScanOn: strm. "FIXME - is TextPlusJumpStart used for anything?"
+ 	self assert: strm contents notEmpty.
  !



More information about the Packages mailing list