[Seaside-dev] Seaside-Development-Core-a.41

[Julian Fitzell]

Ok, fixed I think:

Name: Seaside-Core-jf.212
Author: jf
Time: 11 September 2008, 11:51:55 am
UUID: 94298965-38a5-474d-9759-f55c0bf269c2
Ancestors: Seaside-Core-pmm.211

Gerhard Obermann reported a bug when clearing an AddRemoveExpressions
from a configuration. It seems the default value was not restored
properly.

The fix in Seaside-Development-Core-a.41 was not correct and has been
reverted. This is the correct fix (I think), which is to ensure that
WACollectionAttribute>>default returns a copy of its collection.
WAAddRemoveExpression>>determineValueWithContext: was also modified to
ensure that it always makes a new set before doing the removals and
additions.

This commit also includes a rename of the 'values' instance variable
on WAConfigurationDescription to 'expressions', which should have been
done when it started storing expressions.

On Wed, Sep 10, 2008 at 4:19 PM, Gerhard Obermann <obi068 at gmail.com> wrote:
> Yes just undo this one change and press "clear" after you have e.g. assigned
> some libs!
> cheers
> gerhard
>
> On Wed, Sep 10, 2008 at 4:02 PM, Julian Fitzell <julian at fitzell.ca> wrote:
>>
>> Hm... I still don't understand. The only thing that is cached is the
>> definition of the attribute (its name, its type, its default value,
>> and so on). The values you assign to the configuration are stored in a
>> WAUserConfiguration, not anywhere in the attribute object itself, so I
>> don't see how your change would have affected the problem.
>>
>> Anyway, I'll try to have a look at it in the next couple of days (or
>> Lukas could since he wrote the configuration UI for collection
>> attributes :) ). If I revert that change will the problem be obvious
>> or do I need a reproduction recipe?
>>
>> Julian
>>
>> On Wed, Sep 10, 2008 at 9:28 AM, Gerhard Obermann <obi068 at gmail.com>
>> wrote:
>> > There is a problem if you press clear after you have e.g. assigned some
>> > libraries.
>> > After pressing "clear" the values are still cached and are still
>> > displayed
>> > e.g. aSet(WA..., SU....).
>> > But you are right to clear the cache is also not the best solution,
>> > because i think in that case it should return to default value.
>> > br
>> > Gerhard
>> >
>> > On Wed, Sep 10, 2008 at 9:00 AM, Julian Fitzell <jfitzell at gmail.com>
>> > wrote:
>> >>
>> >> Can you explain the change to #renderInheritanceForAttribute:on: in
>> >> this
>> >> commit?
>> >>
>> >> I don't understand the rationale or need to reinitialize the
>> >> attribute. The attributes should be built once and then cached... they
>> >> shouldn't be modified after that (in fact, I wonder if we should be
>> >> returning copies all the time to prevent them being modified?).
>> >>
>> >> It seems like all you're doing is temporarily clearing the default
>> >> value as specified in the attribute description, which will then be
>> >> put back next time the attribute cache is cleared.
>> >>
>> >> Julian
>> >>
>> >>
>> >> On Sat, Sep 6, 2008 at 11:32 PM, Philippe Marschall
>> >> <philippe.marschall at gmail.com> wrote:
>> >> > 2008/9/6 Gerhard Obermann <obi068 at gmail.com>:
>> >> >> Sorry it wasn't my intention.
>> >> >
>> >> > No harm was done. We all screw up from time to time.
>> >> >
>> >> >> How to change the default author initials in squeak.
>> >> >
>> >> > Utilities setAuthorInitials: 'obi'
>> >> >
>> >> > Cheers
>> >> > Philippe
>> >> > _______________________________________________
>> >> > seaside-dev mailing list
>> >> > seaside-dev at lists.squeakfoundation.org
>> >> > http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>> >> >
>> >> _______________________________________________
>> >> seaside-dev mailing list
>> >> seaside-dev at lists.squeakfoundation.org
>> >> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>> >
>> >
>> > _______________________________________________
>> > seaside-dev mailing list
>> > seaside-dev at lists.squeakfoundation.org
>> > http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>> >
>> >
>> _______________________________________________
>> seaside-dev mailing list
>> seaside-dev at lists.squeakfoundation.org
>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
>
> _______________________________________________
> seaside-dev mailing list
> seaside-dev at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
>