[Seaside-dev] Re: [Seaside Commits] Seaside 3.0:
JQuery-Tests-Core-obi.97.mcz
Lukas Renggli
renggli at gmail.com
Thu Dec 24 14:53:23 UTC 2009
I don't like these changes.
The goal of the tests is to demonstrate the concise implementation of
some basic features. If the code and result is hidden by default this
purpose is lost. Also the usability (clicking on the headings is not
obvious) and the design (the boxes do not fit the existing css)
doesn't look too nice in my eyes. What is the intent of your changes?
Lukas
2009/12/24 <squeak-dev-noreply at lists.squeakfoundation.org>:
> Gerhard Obermann uploaded a new version of JQuery-Tests-Core to project Seaside 3.0:
> http://www.squeaksource.com/Seaside30/JQuery-Tests-Core-obi.97.mcz
>
> ==================== Summary ====================
>
> Name: JQuery-Tests-Core-obi.97
> Author: obi
> Time: 24 December 2009, 3:26:11 pm
> UUID: fbba5893-20dc-1641-b897-07ede0b0f8c7
> Ancestors: JQuery-Tests-Core-lr.96, JQuery-Tests-Core-obi.95
>
> - merged with obi.95
>
> =============== Diff against JQuery-Tests-Core-lr.96 ===============
>
> Item was changed:
> ----- Method: JQAllTests>>renderSmalltalkOn: (in category 'rendering-browser') -----
> renderSmalltalkOn: html
> + | source id |
> + id := html nextId.
> + html heading level: 4;
> + with: [html anchor
> + onClick: ((html jQuery id: id) slideToggle: 0.5 seconds);
> + with: 'Smalltalk'].
> + html div
> + id: id;
> + class: 'hide codeBox';
> + with: [
> + contents selectors do: [ :selector |
> + source := ((contents class whichClassIncludesSelector: selector)
> + sourceCodeAt: selector) greaseString readStream.
> + html div class: 'code'; with: [
> + html span
> + class: 'signature';
> + with: [ html text: contents class name; text: '>>'; text: source nextLine ].
> + html break.
> + [ source atEnd ] whileFalse: [
> + [ source peek = Character tab ] whileTrue: [
> + html space; space; space.
> + source next ].
> + html render: source nextLine; break ] ] ]
> + separatedBy: [ html break ] ]!
> - | source |
> - html heading level: 4; with: 'Smalltalk'.
> - contents selectors do: [ :selector |
> - source := ((contents class whichClassIncludesSelector: selector)
> - sourceCodeAt: selector) greaseString readStream.
> - html div class: 'code'; with: [
> - html span
> - class: 'signature';
> - with: [ html text: contents class name; text: '>>'; text: source nextLine ].
> - html break.
> - [ source atEnd ] whileFalse: [
> - [ source peek = Character tab ] whileTrue: [
> - html space; space; space.
> - source next ].
> - html render: source nextLine; break ] ] ]
> - separatedBy: [ html break ]!
>
> Item was changed:
> ----- Method: JQAllTestsLibrary>>defaultCss (in category 'styles') -----
> defaultCss
> ^ 'html { overflow-y: scroll; }
> body { margin: 0; padding: 0; background: #434242 url(background.png) repeat-x; font-family: Helvetica,Arial,Verdana,sans-serif; font-size: 80%; line-height: 1.5; color: #222; }
> a { text-decoration: none; color: #ff7200; outline: none; cursor: pointer; }
> h1, h2, h3, h4, h5, h6 { border: 0; margin: 0; font-weight: normal; letter-spacing: 1px; }
>
> #canvas { position: relative; margin: 0 auto; width: 1000px; }
>
> #header h1.logo { float: left; margin: 50px 0; }
> #header h1.logo a { display: block; width: 350px; height: 70px; background-image: url(logo.png); }
> + #header h1.logo a span, #content .hide { display: none; }
> - #header h1.logo a span { display: none; }
>
> #menu { float: right; margin: 50px 0 10px 0; height: 50px; }
> #menu .left, #menu .right { width: 15px; height: 50px; float: left; }
> #menu .left { background-image: url(menuLeft.png); }
> #menu .right { background-image: url(menuRight.png); }
> #menu ul { background-image: url(menu.png); }
> #menu ul, #menu ul li { float: left; margin: 0; padding: 0; height: 50px; list-style-type: none; }
> #menu ul li a { padding: 0 15px; color: #bbb; line-height: 50px; font-size: 14px; }
> #menu ul li a:hover { color: #fff; }
>
> #content { position: relative; margin-bottom: 15px; }
> #content { clear: both; background-color: white; }
> + #content .codeBox {border:1px solid #ccc; overflow:auto; width:100%; height:400px}
> #content .top,
> #content .bottom { height: 15px; background: url(frame.png); }
> #content .head, .body { border: 1px solid #ddd; }
> #content .head { height: 70px; border-bottom: none; }
> #content .head h2 { float: left; margin: 10px; color: #ff7200; line-height: 50px; font-size: 30px; }
> #content .head p { float: left; margin: 10px; padding-left: 20px; line-height: 50px; font-size: 20px; border-left: 1px solid #ddd; }
> #content .head { padding: 10px; }
>
> #content .tests { position: relative; padding: 20px; float: left; width: 180px; border-right: 1px solid #ddd; }
> #content .tests h3 { font-size: 20px; margin-bottom: 6px; color: #ff7200; }
> #content .tests ul, #content .tests ul li { padding: 0; margin: 0; list-style-type: none; }
> #content .tests ul { margin-bottom: 20px; }
> #content .tests ul li { line-height: 25px; border-bottom: 1px solid #eee; }
> #content .tests ul li.active { background-color: #ddd; border-bottom: 1px solid #ccc; }
> #content .tests ul li a { padding-left: 10px; color: #222; text-decoration: none; display: block; }
> #content .tests ul li a:hover { background:#eee; }
>
> #content .main { position: relative; padding: 20px; float: left; width: 735px; border-left: 1px solid #ddd; margin-left: -1px; }
> #content .main h3 { font-size: 20px; margin-bottom: 10px; }
> #content .main h4 { font-size: 16px; border-bottom: 1px solid #eee; margin-top: 20px; margin-bottom: 10px; }
> #content .main .demo { position: relative; }
> #content .main .code { font-family: "Bitstream Vera Sans Mono", Courier, monospace; font-size: 1.2em; line-height: 1.2; overflow-x: hidden; overflow-y: auto; white-space: pre; width: 735px; }
> #content .main .code .signature { font-weight: bold; }
> #content .main .code .wa-tag { font-weight: bold; color: purple; }
> #content .main .code .wa-attribute-key { font-weight: bold; color: black; }
> #content .main .code .wa-attribute-value { color: blue; }
> #content .main .code .wa-attribute-value a { color: blue; text-decoration: underline; }
>
> .actions a { padding-right: 1em; }
> #seastar { position: relative; }'!
>
> Item was changed:
> ----- Method: JQAllTests>>renderJavascriptOn: (in category 'rendering-browser') -----
> renderJavascriptOn: html
> + | context id |
> + id := html nextId.
> + html heading level: 4;
> + with: [ html anchor
> + onClick: ((html jQuery id: id) slideToggle: 0.5 seconds);
> + with: 'Source'].
> + html div id: id;
> + class: 'code';
> + class: 'hide';
> + class: 'codeBox';
> + with: [
> + context := html context copy.
> + context document: (WAPrettyPrintedDocument context: html context).
> + contents renderWithContext: context.
> + context document close ].!
> - | context |
> - html heading level: 4; with: 'Source'.
> - html div class: 'code'; with: [
> - context := html context copy.
> - context document: (WAPrettyPrintedDocument context: html context).
> - contents renderWithContext: context.
> - context document close ].!
>
>
> _______________________________________________
> commits mailing list
> To unsubscribe, email commits-leave at lists.seaside.st
> http://lists.seaside.st/listinfo/commits
>
--
Lukas Renggli
http://www.lukas-renggli.ch
More information about the seaside-dev
mailing list