[Seaside-dev] Re: [Seaside Commits] Seaside 3.0: Seaside-Tests-Core-obi.171.mcz

[Lukas Renggli]

Shouldn't there be a new tests for the new callback types?

2009/12/30  <squeak-dev-noreply at lists.squeakfoundation.org>:
> Gerhard Obermann uploaded a new version of Seaside-Tests-Core to project Seaside 3.0:
> http://www.squeaksource.com/Seaside30/Seaside-Tests-Core-obi.171.mcz
>
> ==================== Summary ====================
>
> Name: Seaside-Tests-Core-obi.171
> Author: obi
> Time: 30 December 2009, 4:03:37 pm
> UUID: 8473efbd-dfb6-fe4d-87cd-db19f3df7ef7
> Ancestors: Seaside-Tests-Core-jf.170
>
> - remove test for WAMultiDispatchCallback
>
> =============== Diff against Seaside-Tests-Core-jf.170 ===============
>
> Item was removed:
> - ----- Method: WACallbackTest>>testMultiDispatchCallback (in category 'testing-callbacks') -----
> - testMultiDispatchCallback
> -       | key key1 key2 |
> -       key := registry store: WAMultiDispatchCallback new.
> -       key1 := registry store: (WAValueCallback on:
> -                       [ :v |
> -                       log
> -                               add: 1;
> -                               add: v ]).
> -       key2 := registry store: (WAValueCallback on:
> -                       [ :v |
> -                       log
> -                               add: 2;
> -                               add: v ]).
> -
> -       " an empty callback "
> -       self
> -               shouldnt:
> -                       [ self request: (GRSmallDictionary new
> -                                       at: key
> -                                               put: nil;
> -                                       yourself) ]
> -               raise: WARenderNotification.
> -       self assertLog: #().
> -
> -       " another empty callback "
> -       self
> -               shouldnt:
> -                       [ self request: (GRSmallDictionary new
> -                                       at: key
> -                                               put: '';
> -                                       yourself) ]
> -               raise: WARenderNotification.
> -       self assertLog: #().
> -
> -       " the first callback "
> -       self
> -               shouldnt:
> -                       [ self request: (GRSmallDictionary new
> -                                       at: key
> -                                               put: key1;
> -                                       yourself) ]
> -               raise: WARenderNotification.
> -       self assertLog: #(1 '' ).
> -
> -       " the second callback within array "
> -       self
> -               shouldnt:
> -                       [ self request: (GRSmallDictionary new
> -                                       at: key
> -                                               put: (Array with: key2);
> -                                       yourself) ]
> -               raise: WARenderNotification.
> -       self assertLog: #(2 '' ).
> -
> -       " the first and second callback "
> -       self
> -               shouldnt:
> -                       [ self request: (GRSmallDictionary new
> -                                       at: key
> -                                               put: (Array
> -                                                               with: key1
> -                                                               with: key2);
> -                                       yourself) ]
> -               raise: WARenderNotification.
> -       self assertLog: #(1 '' 2 '' ).
> -
> -       " the second and first callback "
> -       self
> -               shouldnt:
> -                       [ self request: (GRSmallDictionary new
> -                                       at: key
> -                                               put: (Array
> -                                                               with: key2
> -                                                               with: key1);
> -                                       yourself) ]
> -               raise: WARenderNotification.
> -       self assertLog: #(1 '' 2 '' )!
>
>
> _______________________________________________
> commits mailing list
> To unsubscribe, email commits-leave at lists.seaside.st
> http://lists.seaside.st/listinfo/commits
>



-- 
Lukas Renggli
http://www.lukas-renggli.ch