[Seaside-dev] Re: [Seaside Commits] Seaside 3.0: Seaside-Tests-Functional-obi.101.mcz

[Lukas Renggli]

I think this is a good improvement, but we have to be careful.
Behavior seems to be a bit distributed at the moment, for example the
callback is on the group but the selection is still on the individual
options?

I would prefer if you'd continued in a separate branch before merging
everything. Also I'd like to hear the comments of Julian and Philippe,
they didn't reply yet and might have other ideas. Also there is a
certain risk with so deep changes that potentially break a lot of code
so close to beta ...

Lukas

2009/12/30 Gerhard Obermann <obi068 at gmail.com>:
> That should be possible, but then I cant delete WADispatchCallback (Its
> laready deleted with my latest commits).
> It should be added to the seaside 3.0 change list on the seaside homepage.
> At least it should be marked as deprecated.
>
> On Wed, Dec 30, 2009 at 5:49 PM, Lukas Renggli <renggli at gmail.com> wrote:
>>
>> While I think this is a cool technique, it would be good to also
>> support the old way, because otherwise we break *a lot* of existing
>> code.
>>
>> 2009/12/30  <squeak-dev-noreply at lists.squeakfoundation.org>:
>> > Gerhard Obermann uploaded a new version of Seaside-Tests-Functional to
>> > project Seaside 3.0:
>> >
>> > http://www.squeaksource.com/Seaside30/Seaside-Tests-Functional-obi.101.mcz
>> >
>> > ==================== Summary ====================
>> >
>> > Name: Seaside-Tests-Functional-obi.101
>> > Author: obi
>> > Time: 30 December 2009, 5:06:20 pm
>> > UUID: d44d6c88-776c-5341-8cf6-d955c240d44d
>> > Ancestors: Seaside-Tests-Functional-obi.100
>> >
>> > - get rid of WADispatchCallback
>> > - use new rendering technique for radio group
>> >
>> > =============== Diff against Seaside-Tests-Functional-obi.100
>> > ===============
>> >
>> > Item was changed:
>> >  ----- Method: WAInputElementContainer>>renderRadioButtonsOn: (in
>> > category 'rendering-elements') -----
>> >  renderRadioButtonsOn: html
>> > +       | radioGroup |
>> >        self
>> >                renderLabel: 'Radiogroup'
>> >                input: [
>> > +                       html radioGroup
>> > +                               callback: [:value | radio := value];
>> > +                               with: [ :group |
>> > +                                       self elements do: [ :each |
>> > +                                               html label: [
>> > +                                                       group
>> > radioButton
>> > +
>> > selected: radio = each;
>> > +                                                               value:
>> > (group valueFor: each).
>> > +                                                       html text: each
>> > ].
>> > +                                               html break ] ] ]
>> > -                       html radioGroup: [ :group |
>> > -                               self elements do: [ :each |
>> > -                                       html label: [
>> > -                                               group radioButton
>> > -                                                       selected: radio
>> > = each;
>> > -                                                       callback: [
>> > radio := each ].
>> > -                                               html text: each ].
>> > -                                       html break ] ] ]
>> >                output: radio printString
>> >                on: html!
>> >
>> >
>> > _______________________________________________
>> > commits mailing list
>> > To unsubscribe, email commits-leave at lists.seaside.st
>> > http://lists.seaside.st/listinfo/commits
>> >
>>
>>
>>
>> --
>> Lukas Renggli
>> http://www.lukas-renggli.ch
>>
>> _______________________________________________
>> seaside-dev mailing list
>> seaside-dev at lists.squeakfoundation.org
>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>>
>
>
> _______________________________________________
> seaside-dev mailing list
> seaside-dev at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
>



-- 
Lukas Renggli
http://www.lukas-renggli.ch