[Seaside-dev] Seaside-Core-jok.482.mcz

Julian Fitzell jfitzell at gmail.com
Fri Feb 20 16:14:59 UTC 2009


John,

I'm the error handler there must not have been there just to deal with
#at: failing (though obviously it is handling that too) but also to
handle the case where keyString is a collection (not a string) and is
empty. I'm just surmising by looking at the code because it would not
have made sense for someone to write it that way otherwise (clearly
#at:ifAbsent: would be better for the #at: case).

I don't quite understand the compatibility issue you mention. I
certainly don't care if the code is rewritten without the #on:do: but
it seems like your version is not at robust as the previous version
was.

Julian

>Seaside-Core-jok.482.mcz
>from Seaside 2.9 by John O'Keefe <john_okeefe at instantiations.com>
>Since a WARequest understands at:ifAbsent:, use it.
>This fixes a VA Smalltalk portability issue -- Dictionary>>#at:
>signals an instance-based exception when the key cannot be found and that exception cannot be handled by an empty #on:do: handler block.


More information about the seaside-dev mailing list