[Seaside-dev] Issue 293 in seaside: Refactor WAResponse and subclasses to encapsulate stream and use WriteStream instead of ReadWriteStream

[codesite-noreply at google.com]

Comment #18 on issue 293 by renggli: Refactor WAResponse and subclasses to  
encapsulate stream and use WriteStream instead of ReadWriteStream
http://code.google.com/p/seaside/issues/detail?id=293

1. WAResponse and friends are designed to not create unnecessary copies of  
objects. Copying or converting
objects is extremely slow, especially when large arrays, strings or streams  
are involved. Memory leaks can
easily appear when stack frames reference these copies and end up in  
continuations.

2. RWBinaryOrTextStream is the stream implementation used in Pharo. You  
might need to provide your own
binary-or-ascii stream in GemStone doing the necessary conversion yourself.  
We will have to discuss if a
simple write stream would be better to use, the thing is that we need to be  
able to stream properly encoded
ASCII strings and binary data. This is currently done after the fact using  
the content-type, but I think we
should do it on the fly.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings