[Seaside-dev] Issue 296 in seaside: WAFileHandler default is nil when running tests

[codesite-noreply at google.com]

Updates:
	Status: Fixed
	Owner: WeybridgeWay
	Labels: Version-Seaside2.9

Comment #1 on issue 296 by WeybridgeWay: WAFileHandler default is nil when  
running tests
http://code.google.com/p/seaside/issues/detail?id=296

Seaside-Tests-Core-jgf.69.mcz contains my changes to address the above  
issues.

Modify WATestingFiles so that WAFileLibraryTest>>#'testUrlOf' passes.  
Specifically, because (WAFileHandler default) is nil the test
was failing. I don't see any indication in Seaside-Platform or Seaside-Core  
that a default is defined (either eagerly or passively).
There are only four references to WAFileHandler when Seaside-Core is  
loaded, and all the other references explicitly create an
instance rather than expecting the default to be defined. Since this test  
appears to be testing the #'urlOf:' method rather than the
existance of a default WAFileHandler, this seems to be a safe change and I  
think points the way to a refactoring of
WAFileHandler>>#'urlOf:' so that subclasses can provide their own defailt  
file handler.

If (WAFileLibrary default) should exist and work in this situation, then  
I've taken the wrong approach and would be happy to be
set straight. However, since this issue didn't prompt any discussion for a  
few days I thought I'd address it since it is the last
remaining unexpected failure in Core.

As of this point there are no unexpected failures or errors in the tests  
through Seaside-Tests-Squeak-Core!

--James Foster

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings