[Seaside-dev] Issue 307 in seaside: WAEncoder class>>#'initializeBMP' fails to initialize max character value

[codesite-noreply at google.com]

Status: Fixed
Owner: WeybridgeWay
Labels: Type-Defect Priority-Medium Version-Seaside2.9

New issue 307 by WeybridgeWay: WAEncoder class>>#'initializeBMP' fails to  
initialize max character value
http://code.google.com/p/seaside/issues/detail?id=307

It appears to me that there is an off-by-one error in the initialization.  
The code creates an Array
(stored in the inst var 'table') with either 255 or 65535 slots and then  
saves an encoded value of 0
to 254 (or 65534). Without understanding much of what is going on with  
encoding, it seems that
with values of 0-255, there should be 256 characters. I've made that  
change, but would be happy
to have someone explain why the previous implementation was better.
* Seaside-Core-jgf.427.mcz

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings