[Seaside-dev] experience porting Grease-Tests to GNU Smalltalk

Paolo Bonzini bonzini at gnu.org
Wed Apr 7 06:25:29 UTC 2010


On 04/07/2010 07:41 AM, Philippe Marschall wrote:
>> >  3) GRCodecTest>>#testCodecLatin1Binary and
>> >  GRUtf8CodecTest>>#testCodecUtf8Binary assume presence of a #binary method
>> >  that apparently allows using ByteArrays instead of Strings. Again, is this
>> >  method needed?  What is the spec, or can we remove the tests altogether?
>
> Currently at least WAListenerAdaptor uses it.

What package is it in?

>> >  4) Codec tests are a bit broken, in that they assume ISO-8859-1 is special
>> >  in some way that I cannot really understand (and more so after the brief
>> >  discussion of a few days ago).  In general, the tests must not assume that
>> >  the literal 'Übèrstrîñgé' is expressed as ISO-8859-1,   as long as it is
>> >  equal (#=) to whatever #decode: answers.  For example, gst literals use
>> >  whatever is in the LC_ALL or LANG environment variables; typically UTF-8.
>
> Hmm, that one feels familiar. Would a String class>>  #streamContents:
> and Character class>>  #value: work better?

Not really.  But it is probably not too bad, let me post my solution as 
code as it is much easier understood that way.

Paolo


More information about the seaside-dev mailing list