[Seaside-dev] Seaside-Core-pmm.693 and Seaside-HTML5-pmm.19 define same method

[Dale Henrichs]

Using the following script:

| dirtied |
dirtied := OrderedCollection new.
MCWorkingCopy allManagers do: [:wc | | patch |
   (wc modified not and: [ wc package name ~= 'Sport' ])
     ifTrue: [
       (MCCacheRepository default
           closestAncestorVersionFor: wc ancestry ifNone: []) ~~ nil
         ifTrue: [
           (patch := wc
             changesRelativeToRepository: MCCacheRepository default)
                             isEmpty
             ifFalse: [
               (patch operations select: [:op |
                 op definition isOrganizationDefinition not ]) notEmpty
                   ifTrue: [
                     dirtied add: { wc package name. wc. patch. } ]]]]].
dirtied

I only found differences in Seaside-Core and Seaside-HTML5, so there 
don't appear to be any other problems ... The WAOrderedListTag>>type: 
problem seems to be unrelated reverting Seaside-HTML5 always shos the 
diffs ... ?????? characters in a comment ... maybe mutlibyte characters 
are involved? I'm working in PharoCore1.0 at the moment so maybe it's a 
bug there ...

Sport gets stomped on by Swazoo, so it will always show up as dirty.

We're down to

   - restoring the missing edits for Seaside-Core
   - should wait for Issue 641 to be fixed (not marked as fixed nor
     listed on wiki, but Seaside-Development-as.144 has a comment
     relating to Issue641)
   - any other bugfixes you want me to wait for...

before snapping off 3.0.4...I'll just need a couple of hours, but I'd 
rather not pick up half a fix if there's active development.

Dale


On 02/09/2011 03:56 PM, Dale Henrichs wrote:
> As of right now, those are the latest versions of the two packages and
> the method WABaseElement>>target: is defined in both, so I'm not sure
> which package is the correct one ...
>
> I found this out by accident when I moved the methods between
> Grease-Pharo-Core and Seaside-Pharo-Core....
>
> It is beginning to look like some packages were not dirtied correctly
> during development...or....some mcz files were lost:
>
> Name: Seaside-Core-pmm.693
> Author: pmm
> Time: 5 February 2011, 10:32:16 am
> UUID: f138cacb-220e-418d-91b2-0f01b792f065
> Ancestors: Seaside-Core-as.692
>
> Name: Seaside-HTML5-pmm.19
> Author: pmm
> Time: 8 February 2011, 10:17:04 pm
> UUID: b0de019c-bfae-424d-9ac4-fb54fecfaca5
> Ancestors: Seaside-HTML5-as.18
>
> So it's possible that a later Seaside-Core mcz file went missing...
>
> Another odd thing about Seaside-HTML5 that I haven't figured out yet is
> that WAOrderedListTag>>type: in the image, doesn't match the version
> that is in the package?
>
> I'll spend a little more time today checking for more oddities (check
> for differences for all packages...)
>
> But I will hold off the repackaging of the WAUrlEncoder methods until
> things...
>
> Looking at Issue 640, there were later versions of Seaside-Core
> committed somewhere:
>
> Name: Seaside-Core-as.694
> Author: as
> Time: 6 February 2011, 9:08:58 pm
> UUID: 5450d506-8db5-414b-996a-b434ec532cea
> Ancestors: Seaside-Core-pmm.693
>
> Name: Seaside-Core-as.695
> Author: as
> Time: 6 February 2011, 9:39:13 pm
> UUID: f017aa59-fdf2-604e-84c2-776bfdab18c2
> Ancestors: Seaside-Core-as.694
>
> These files are no longer present in the Seaside30 repository (if they
> ever were), so perhaps, Philippe's changes got lost along the way
> (committed after Seaside-Core-as.695 possibly)...not a good idea to
> delete packages, in case a mistake like this one is made...hard to tell
> what other work was lost by the deletion... if indeed mcz files were
> deleted...
>
> Also it looks like there is active seaside30 development work going on
> on today (Issue 641) is this something that I should wait to be finished
> or should I try to exclude the additional work or what ... Normally I
> can get my snapshot of mcz files done in an hour or two, but since the
> packaging is messed up and possibly mcz files missing I'll have to wait
> until at least tomorrow before I pick up the latest mcz files ...
>
> Dale
> _______________________________________________
> seaside-dev mailing list
> seaside-dev at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev